fix(benchmark): require declared paired-bootstrap coverage - #1090
Draft
seonghobae wants to merge 1 commit into
Draft
fix(benchmark): require declared paired-bootstrap coverage#1090seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Remove the hidden 2,000-resample 95% interval and the baked-in conduct/route/cheapest/hindsight comparison subset. Report schema 4.0.0 records operator declarations in provenance.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Draft successor of #1074 (
9f5d0ce2). Parent #1067 remains the psychometric KPI owner and still needs independent review. This PR does not close #1074.Exact head:
5e952933d4dd97057ba76b70ea17983314a4babe.Problem
Paired NIM comparisons used a hidden 2,000-resample 95% percentile interval and a baked-in policy subset (
conduct_boundedvsroute_once, optional cheapest vsroute_once, plus hindsight pairs). Those choices were not reconstructible as operator declarations.Change
resample_count,confidence_level,seed, andcomparison_pairsare required declarations.Noneis a fail-closed sentinel, not a statistical default.paired_bootstrap_percentile; coverage is a separate numeric field.Verification
Local three-file coverage command matching hosted quality:
nim_benchmark.py1328 statements / 504 branches, 0 missedThis is calculation-contract evidence, not buyer-held-out accuracy, p95 latency, or protected merge. Production route/conduct defaults stay locked.
Remaining no-heuristics work
Repository-authored
MAX_WORKFLOW_DEPTHandDEFAULT_MAX_OUTPUT_TOKENS, and the psychometric held-out harness's 2,000-sample 95% interval on parent #1067, remain later slices. No production policy or release is authorized.