fix(heldout): declare held-out context population - #1097
Conversation
Accuracy and decision-latency helpers must fail closed without a positive context_count, and the declared count must be the actual quality loop.
Remove the hidden 24-context TRAIN_CONTEXTS default from evidence construction, quality evaluation, and paired timings. The harness run still writes 24 as this run's choice.
ADR 0048 is Proposed. Production route/conduct defaults stay locked.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Integrated predecessor b8a7b3b by a normal merge, preserving the original 525991d context-population delta. New head: 0771905. This carries the no-detection censoring repair, explicit false-alarm/detection denominators, null candidate when calibration has no eligible threshold, and all calibration results into this successor. Validation on the merged tree: 25 boundary/ADR identifier tests passed in 21.47 seconds; Ruff passed; git diff --cached --check passed. An initial test command referenced a nonexistent ADR test filename and ran no tests; the corrected command used tests/test_planning_adr_identifiers.py and completed with exit 0. No delta discarded, no force push, no production-default change or release claim. Earlier hosted checks belong to the previous head and must be rerun for this head. |
Stack
Draft successor of #1096 (
8ccf011d). Parents #1095, #1093, #1092, #1091, #1090, #1074, and psychometric KPI owner #1067 stay open. This PR does not close #1096.Exact head:
525991db1ebb0adc58a1a5a895329769ad445672.Problem
Held-out accuracy and decision-latency averages hid
TRAIN_CONTEXTS = 24, so buyer-facing Brier, log loss, regret, and latency p50/p95 used a repository-selected population.Change
context_counton_build_evidence,_evaluate_quality, and_measure_paired_latency. Missing, boolean, or non-positive values fail closed.contexts_held_out/contexts_train.Verification
Local smallest tests:
tests/test_psychometric_routing.py,tests/test_psychometric_benchmark_boundaries.py,tests/test_planning_adr_identifiers.py)This is declaration-contract evidence, not buyer-held-out accuracy, p95 latency, or protected merge.
Remaining no-heuristics work
Other harness sample sizes (assignment, DIF, reliability) remain later slices. No production policy or release is authorized. Parent #1067 still needs independent review.