fix(heldout): declare judge-effect sample size

[seonghobae]

Stack

Draft successor of #1100 (9ff12b5d). Parents #1099, #1098, #1097, #1096, #1095, #1093, #1092, #1091, #1090, #1074, and psychometric KPI owner #1067 stay open. This PR does not close #1100.

Exact head: cdbc6a03605bff2d3a66b6404b324c3e376b30f2.

Problem

Held-out judge-severity evidence hid JUDGE_SAMPLE_SIZE = 1_000, so the fully crossed many-facet design used a repository-selected person population.

Change

• Require declared sample_size on _validate_judge_effects. Missing, boolean, or non-positive values fail closed.
• The harness run still writes 1,000 as this run's choice and records sample_size.
• ADR 0052 is Proposed. Production route/conduct defaults stay locked.

Verification

Local smallest tests:

• 66 passed in 16.32s (tests/test_psychometric_routing.py, tests/test_psychometric_benchmark_boundaries.py, tests/test_planning_adr_identifiers.py)
• interrogate on the held-out script: 100%

This is declaration-contract evidence, not buyer-held-out accuracy, p95 latency, or protected merge.

Remaining no-heuristics work

Other harness sample sizes (exploration rate, item-covariate) remain later slices. No production policy or release is authorized. Parent #1067 still needs independent review.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

Normal predecessor integration at 8a04a5c retains original judge sample declaration cdbc6a0 and includes predecessor 3e85d32. No-detection censoring, alarm/detection denominators, null ineligible calibration candidate and retained calibration results now propagate through this stack. Merged-tree validation: 33 boundary/ADR identifier tests passed in 5.80 seconds; Ruff and diff whitespace checks passed; CodeGraph indexing completed. No force push or discarded delta. This is local regression evidence, not real-data accuracy, protected merge or release evidence. Required checks and reviews must use the new head.