fix(benchmark): require declared workflow depth and token budgets - #1091
Draft
seonghobae wants to merge 3 commits into
Draft
fix(benchmark): require declared workflow depth and token budgets#1091seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
RED: omitted maximum_calls, max_output_tokens, and max_workflow_depth still succeed through hidden module defaults. The next commit must fail closed without inventing a five-step envelope or 264-token cap.
Remove hidden five-step and 264-token defaults from request planning, equal-budget cells, CLI, and provenance. Missing or non-positive declarations fail closed. Workflow YAML still writes 5 and 264 as this run's choices. Production route/conduct defaults stay locked.
ADR 0043 is Proposed. Gap baseline, changelog, doctoring, and NIM operator docs keep 5 and 264 as run declarations. Held-out 2,000-sample interval remains later work.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 7, 2026
seonghobae
added
bug
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Draft successor of #1090 (
5e952933). Parent #1074 and psychometric KPI owner #1067 stay open. This PR does not close #1090.Exact head:
6a32c676eada0e3b49b98f5093a0cf3c13b7b981.Problem
NIM equal-budget cells used a hidden five-step workflow and a 264-token per-call output cap. Those numbers allocated evaluation compute and shaped request planning without an operator declaration.
Change
maximum_calls/max_workflow_depthandmax_output_tokens/total_token_budgetare required positive integers.Noneis a fail-closed sentinel, not a default.--max-workflow-depthand--max-output-tokenshave no hidden default. Workflow YAML still writes 5 and 264 as this run's choices.Verification
Local three-file coverage command matching hosted quality:
nim_benchmark.py1331 statements / 502 branches, 0 missedThis is calculation-contract evidence, not buyer-held-out accuracy, p95 latency, or protected merge.
Remaining no-heuristics work
The psychometric held-out harness's 2,000-sample 95% interval on parent #1067 remains a later slice. No production policy or release is authorized.