fix(heldout): require declared paired-bootstrap coverage - #1092
Draft
seonghobae wants to merge 3 commits into
Draft
fix(heldout): require declared paired-bootstrap coverage#1092seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
RED: omitted resample_count, coverage, and seed still succeed through hidden 2,000-sample 95% module constants. The next commit must fail closed without inventing those defaults.
Remove hidden 2,000-sample 95% defaults from the held-out interval helper, run_benchmark, and adaptive calibration. Missing or non-representable declarations fail closed. The script entry still writes 2,000, 0.95, and seed 568 as this run's choices. Production route/conduct defaults stay locked.
ADR 0044 is Proposed. Gap baseline, changelog, and doctoring keep 2,000 and 0.95 as run declarations. Other harness sample sizes remain later work.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 7, 2026
seonghobae
added
bug
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Draft successor of #1091 (
6a32c676). Parents #1090, #1074, and psychometric KPI owner #1067 stay open. This PR does not close #1091.Exact head:
5bc0cd52e32faaf8b6be5168272cd226aed942de.Problem
The psychometric held-out harness used a hidden 2,000-sample 95% paired interval. Those numbers chose Monte Carlo precision without an operator declaration.
Change
resample_count,confidence_level, andseedare required declarations on the interval helper,run_benchmark, and adaptive calibration.Noneis a fail-closed sentinel.Verification
Local smallest tests:
This is calculation-contract evidence, not buyer-held-out accuracy, p95 latency, or protected merge. The full harness wiring test was not re-run in this fire; 2,000/0.95 maps to the same floor/ceil indices as the previous constants.
Remaining no-heuristics work
Other harness sample sizes and nested
*_ci95JSON key names remain later slices. No production policy or release is authorized.