fix(heldout): use coverage-neutral interval field names - #1093
Draft
seonghobae wants to merge 3 commits into
Draft
fix(heldout): use coverage-neutral interval field names#1093seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
RED: nested JSON fields still embed 95 in the name even though coverage is a run declaration. The next commit must rename those fields.
Rename nested *_ci95 JSON keys to *_interval. Declared coverage stays in bootstrap_confidence_level. IRT interval_95_coverage_rate diagnostics are unchanged. Production route/conduct defaults stay locked.
ADR 0045 is Proposed. Gap baseline, changelog, and doctoring keep coverage in the declared field rather than the JSON name.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Draft successor of #1092 (
5bc0cd52). Parents #1091, #1090, #1074, and psychometric KPI owner #1067 stay open. This PR does not close #1092.Exact head:
d40a4981a258b4d0194bda3cdb6c99ae3097da50.Problem
After declared coverage, nested held-out JSON fields still named
*_ci95implied 95% even when the run declared a different interval.Change
delta_ci95,paired_delta_ci95,query_delta_ci95,accuracy_delta_ci95, andheldout_paired_delta_ci95to*_interval.bootstrap_confidence_level.interval_95_coverage_ratediagnostics are unchanged.Verification
Local smallest tests:
This is naming-contract evidence, not buyer-held-out accuracy, p95 latency, or protected merge.
Remaining no-heuristics work
Other harness sample sizes remain later slices. No production policy or release is authorized.