Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
❌ Deploy Preview for explorer-cash failed.
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
explorer | a9eab06 | Nov 14 2026, 08:24 PM |
This was referenced Nov 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19.
The converter already offered token, regular, and legacy strings, but its apparent cross-check called the same Libauth routines twice. P2SH32 silently lost its legacy row, the output network was implicit, and the page had no QR output or clipboard-failure guidance.
This change uses one local conversion path backed by Libauth, makes the output network explicit, and separates token-aware and regular BCH outputs with exact copy and QR controls. A token-aware address signals support; converting an address never makes a wallet token-compatible. P2SH32 now explains why legacy output is unavailable. Empty, malformed, mixed-case, and unsupported-prefix input produces guidance without stale outputs or exceptions.
Based on cleanup PR #32; merge #32 first
Cleanup dependency: #32. This PR targets
mainas requested and currently includes cleanup ancestry. Its prepared base was exactly4cd0fb6c2fe09a60dfbf6889fa7b67d72c23a949, with one issue-specific commit on top.Focused review: chore/dependency-upgrades-cleanup...fix/19-token-address-converter
Acceptance
bitcoincash:and mainnet Base58 versions; Chipnet outputs usebchtest:and testnet versions. Copy explains that test chains share encodings and conversion does not move funds.docs/address-converter.md.The output cards use existing slate/zinc/emerald tokens. Visible format explanations and full wrapping addresses keep the destination and token-support signal clear; QR disclosures keep long output lists compact. No packages, shared address helpers, query schema, generated schema snapshot, or unrelated settings were changed.
Verification
All passed in the isolated worktree:
bun install --frozen-lockfilebun run lint(22 informational component-name notices, no errors)bun run test— 191 passing tests, 0 failures; 148 converter cases include fixed vectors and decoding assertions for script bytes, network prefixes/versions, and token flags.bun run lint:type— checked-in-schema codegen and Nuxt typecheckbun run build— generated.output/public, including/converter; the first attempt correctly refused to run alongside this worktree's preview server, then passed after stopping that server.git diff --checkStandard built-in browser checks passed for token input, network switching, prefixless P2SH32, exact clipboard contents, QR contents/rendering, malformed-prefix rejection, clearing stale output, clipboard denial, Tab/Enter operation and focus outlines, and light/dark layouts at 320/360px with no horizontal page overflow. The owned preview tab and dev server were closed after verification.
Limits
The regression suite and converter both rely on Libauth; there is no claim of an independent addressing implementation. Browser checks verified QR contents and rendered SVGs, but did not scan them with a real wallet or send funds. Payment URIs and prefixes outside
bitcoincash:/bchtest:are intentionally rejected. The existing Alpha feature flag is preserved. Repository hooks emitted the existing “Can't find lefthook in PATH” messages; hooks were not bypassed.Parent review follow-up: the output-network selector now stays local to the converter; trying Chipnet does not change the explorer browsing network. The 148 conversion cases, lint, and Nuxt typecheck passed after this change.