Skip to content

fix: complete NFT galleries for collections and addresses (#15) - #38

Open
salemkode wants to merge 4 commits into
mainfrom
t3/nft-gallery-completion
Open

salemkode wants to merge 4 commits into
mainfrom
t3/nft-gallery-completion

Conversation

@salemkode

@salemkode salemkode commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Collection and address NFT galleries retain distinct outpoints, deterministic lookahead pagination, loading/error/retry states, metadata fallbacks, and a native image dialog. Owner addresses include the actual NFT category under Auto and preserve matching copy/link destinations. Loaded full artwork stays ready when only an inactive icon changes. Explicit null selected metadata suppresses unrelated registry names/artwork; only an omitted selection permits fallback.

Addresses #15.

This PR keeps base main and descends from cleanup commit 4cd0fb6c2fe09a60dfbf6889fa7b67d72c23a949. Immediate prerequisite: PR #35. Manual merge order: #32 → #35 → #38. These prerequisites are included in the current diff until they are merged.

Focused comparison against the immediate prerequisite. Documentation: docs/nft-gallery.md. Feature-specific documentation uses separate files so independent branches do not append competing README sections.

Validation at a9bb934b996b8f7fe508f12013f9d0ffe51b7fc2: compatible dependencies installed with bun install --frozen-lockfile; bun run lint; bun test (137 top-level passing tests, including subprocess component suites); every test file run individually; bun run lint:type (actual GraphQL document validation/codegen against the unchanged checked-in schema and Nuxt typecheck); bun run build; git diff --check. All passed. No dependencies or backend/schema changes.

The complete eleven-issue aggregate also passes lint, codegen/typecheck, static build, every test file individually, and 425 top-level tests including the preserved exact badge/component suites. Independent merge paths after #32: #33 → #37; #35 → #38 → #40 → #39 → #42 → #41; #34 → #43; #36 independently. All PR bases remain main.

Limits: this integration pass used deterministic query/reactive/component fixtures. No interactive browser, focus/layout, clipboard, real-wallet, or live-indexer verification was performed. Prior independent review findings were implemented and regression-tested; the independent reviewers have not re-reviewed these rewritten heads. Existing hook messages reported missing lefthook; no safeguard or hook was bypassed. No PR was merged and no issue was closed.

Remote check status after the integration push: GitHub Validate explorer / validate passed on this exact head. Netlify deploy-preview plus its Pages/Header/Redirect checks failed; the same failures also occur on unchanged PR #32, #33 and #36. GitHub’s output says only “Deploy failed”; the public deploy metadata reports error without a build-cause message. This integration does not claim Netlify is green and does not change cleanup PR #32. The separate Cloudflare check may finish independently.

@netlify

netlify Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for explorer-cash failed.

Name Link
🔨 Latest commit a9bb934
🔍 Latest deploy log https://app.netlify.com/projects/explorer-cash/deploys/6af91f790c3f3c5688be7ca0

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:12:43.071046Z 3f3474e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
explorer a9bb934 Nov 15 2026, 03:03 AM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant