Skip to content

fix: calculate complete exact token balances and metrics (#24) - #42

Open
salemkode wants to merge 9 commits into
mainfrom
t3/exact-token-balances-metrics
Open

salemkode wants to merge 9 commits into
mainfrom
t3/exact-token-balances-metrics

Conversation

@salemkode

@salemkode salemkode commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Address/category balances and genesis accounting scan complete keyset pages, then aggregate exact integer strings and scale only for display. Unsafe JSON numbers and invalid scalar types fail the snapshot instead of publishing rounded exact totals. One accepted node id is pinned across creation, spends and final block verification. Competing node branches and unconfirmed spends cannot duplicate/remove outputs. Genesis authorization checks every category outpoint-zero input, accepting safe numeric or string zero; selected-chain/revision publication behavior is preserved. Unknown issuer reserves/circulation are explicit. Badge precision remains owned by #33/#37, avoiding a duplicate conflicting badge edit.

Addresses #24.

This PR keeps base main and descends from cleanup commit 4cd0fb6c2fe09a60dfbf6889fa7b67d72c23a949. Immediate prerequisite: PR #39. Manual merge order: #32 → #35 → #38 → #40 → #39 → #42. These prerequisites are included in the current diff until they are merged.

Focused comparison against the immediate prerequisite. Documentation: docs/token-balances.md. Feature-specific documentation uses separate files so independent branches do not append competing README sections.

Validation at 0171abc0fa9910812a994104715822524f1f952d: compatible dependencies installed with bun install --frozen-lockfile; bun run lint; bun test (170 top-level passing tests, including subprocess component suites); every test file run individually; bun run lint:type (actual GraphQL document validation/codegen against the unchanged checked-in schema and Nuxt typecheck); bun run build; git diff --check. All passed. No dependencies or backend/schema changes.

The complete eleven-issue aggregate also passes lint, codegen/typecheck, static build, every test file individually, and 425 top-level tests including the preserved exact badge/component suites. Independent merge paths after #32: #33 → #37; #35 → #38 → #40 → #39 → #42 → #41; #34 → #43; #36 independently. All PR bases remain main.

Limits: this integration pass used deterministic query/reactive/component fixtures. No interactive browser, focus/layout, clipboard, real-wallet, or live-indexer verification was performed. Prior independent review findings were implemented and regression-tested; the independent reviewers have not re-reviewed these rewritten heads. Existing hook messages reported missing lefthook; no safeguard or hook was bypassed. No PR was merged and no issue was closed.

Remote check status after the integration push: GitHub Validate explorer / validate passed on this exact head. Netlify deploy-preview plus its Pages/Header/Redirect checks failed; the same failures also occur on unchanged PR #32, #33 and #36. GitHub’s output says only “Deploy failed”; the public deploy metadata reports error without a build-cause message. This integration does not claim Netlify is green and does not change cleanup PR #32. The separate Cloudflare check may finish independently.

Genesis query contract: the auth-chain query now retrieves all eligible output-zero inputs, including an authorizing input after unrelated inputs. A generated-query/schema execution regression applies the actual query filters and limits; it fails under the old first-input cap and passes with this fix. Full suite: 170 tests; typecheck and static build pass.

Shared-icon selection consistency

Provider/revision changes close an existing image preview. Thumbnail readiness resets only when the effective icon URL changes, so providers sharing an icon can open their own selected artwork without waiting for another image load. The regression executes the actual compiled setup with real Vue reactivity and fails under the original behavior. This branch passes 170 top-level tests (including isolated component suites), typecheck, and static build after this correction.

Merge prerequisite PRs with merge commits to preserve stack ancestry and focused diffs; squash/rebase merges require refreshing descendants. All bases remain main, and merges are manual.

@netlify

netlify Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for explorer-cash failed.

Name Link
🔨 Latest commit e261e56
🔍 Latest deploy log https://app.netlify.com/projects/explorer-cash/deploys/6af926b0648b42424f0fb916

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:15:46.115824Z f7d30b7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
explorer e261e56 Nov 15 2026, 03:29 AM

@salemkode
salemkode force-pushed the t3/exact-token-balances-metrics branch from 118aa2a to e261e56 Compare November 15, 2026 03:27

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant