Repository navigation
Conversation
❌ Deploy Preview for explorer-cash failed.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
explorer | e261e56 | Nov 15 2026, 03:29 AM |
salemkode
force-pushed
the
t3/exact-token-balances-metrics
branch
from
November 15, 2026 02:57
f7d30b7 to
0171abc
Compare
This was referenced Nov 15, 2026
salemkode
force-pushed
the
t3/exact-token-balances-metrics
branch
from
November 15, 2026 03:27
118aa2a to
e261e56
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address/category balances and genesis accounting scan complete keyset pages, then aggregate exact integer strings and scale only for display. Unsafe JSON numbers and invalid scalar types fail the snapshot instead of publishing rounded exact totals. One accepted node id is pinned across creation, spends and final block verification. Competing node branches and unconfirmed spends cannot duplicate/remove outputs. Genesis authorization checks every category outpoint-zero input, accepting safe numeric or string zero; selected-chain/revision publication behavior is preserved. Unknown issuer reserves/circulation are explicit. Badge precision remains owned by #33/#37, avoiding a duplicate conflicting badge edit.
Addresses #24.
This PR keeps base
mainand descends from cleanup commit4cd0fb6c2fe09a60dfbf6889fa7b67d72c23a949. Immediate prerequisite: PR #39. Manual merge order: #32 → #35 → #38 → #40 → #39 → #42. These prerequisites are included in the current diff until they are merged.Focused comparison against the immediate prerequisite. Documentation: docs/token-balances.md. Feature-specific documentation uses separate files so independent branches do not append competing README sections.
Validation at
0171abc0fa9910812a994104715822524f1f952d: compatible dependencies installed withbun install --frozen-lockfile;bun run lint;bun test(170 top-level passing tests, including subprocess component suites); every test file run individually;bun run lint:type(actual GraphQL document validation/codegen against the unchanged checked-in schema and Nuxt typecheck);bun run build;git diff --check. All passed. No dependencies or backend/schema changes.The complete eleven-issue aggregate also passes lint, codegen/typecheck, static build, every test file individually, and 425 top-level tests including the preserved exact badge/component suites. Independent merge paths after #32: #33 → #37; #35 → #38 → #40 → #39 → #42 → #41; #34 → #43; #36 independently. All PR bases remain
main.Limits: this integration pass used deterministic query/reactive/component fixtures. No interactive browser, focus/layout, clipboard, real-wallet, or live-indexer verification was performed. Prior independent review findings were implemented and regression-tested; the independent reviewers have not re-reviewed these rewritten heads. Existing hook messages reported missing lefthook; no safeguard or hook was bypassed. No PR was merged and no issue was closed.
Remote check status after the integration push: GitHub Validate explorer / validate passed on this exact head. Netlify deploy-preview plus its Pages/Header/Redirect checks failed; the same failures also occur on unchanged PR #32, #33 and #36. GitHub’s output says only “Deploy failed”; the public deploy metadata reports
errorwithout a build-cause message. This integration does not claim Netlify is green and does not change cleanup PR #32. The separate Cloudflare check may finish independently.Genesis query contract: the auth-chain query now retrieves all eligible output-zero inputs, including an authorizing input after unrelated inputs. A generated-query/schema execution regression applies the actual query filters and limits; it fails under the old first-input cap and passes with this fix. Full suite: 170 tests; typecheck and static build pass.
Shared-icon selection consistency
Provider/revision changes close an existing image preview. Thumbnail readiness resets only when the effective icon URL changes, so providers sharing an icon can open their own selected artwork without waiting for another image load. The regression executes the actual compiled setup with real Vue reactivity and fails under the original behavior. This branch passes 170 top-level tests (including isolated component suites), typecheck, and static build after this correction.
Merge prerequisite PRs with merge commits to preserve stack ancestry and focused diffs; squash/rebase merges require refreshing descendants. All bases remain
main, and merges are manual.