Skip to content

fix: add detected burned supply and correct CashToken circulation - #41

Open
salemkode wants to merge 10 commits into
mainfrom
fix/20-burned-supply
Open

salemkode wants to merge 10 commits into
mainfrom
fix/20-burned-supply

Conversation

@salemkode

@salemkode salemkode commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

The fungible-supply card scans confirmed category history from one node and block snapshot, counts implicit losses and provably unspendable outputs, and retains honest partial-burn warnings. Remaining supply and circulation are labelled upper bounds; burns are subtracted once. Reserves refer only to the selected BCMR authhead output zero, never all issuer balances. Changing selected authhead recalculates, and unavailable heads leave reserve/circulation unknown. The integrated page retains #42 unspent/NFT metrics and removes duplicate genesis/reserve/circulation rows and obsolete hooks.

Addresses #20.

This PR keeps base main and descends from cleanup commit 4cd0fb6c2fe09a60dfbf6889fa7b67d72c23a949. Immediate prerequisite: PR #42. Manual merge order: #32 → #35 → #38 → #40 → #39 → #42 → #41. These prerequisites are included in the current diff until they are merged.

Focused comparison against the immediate prerequisite. Documentation: docs/token-supply.md. Feature-specific documentation uses separate files so independent branches do not append competing README sections.

Validation at b1c9011d439a85e7d228498ee723b43ba0fa6687: compatible dependencies installed with bun install --frozen-lockfile; bun run lint; bun test (193 top-level passing tests, including subprocess component suites); every test file run individually; bun run lint:type (actual GraphQL document validation/codegen against the unchanged checked-in schema and Nuxt typecheck); bun run build; git diff --check. All passed. No dependencies or backend/schema changes.

The complete eleven-issue aggregate also passes lint, codegen/typecheck, static build, every test file individually, and 425 top-level tests including the preserved exact badge/component suites. Independent merge paths after #32: #33 → #37; #35 → #38 → #40 → #39 → #42 → #41; #34 → #43; #36 independently. All PR bases remain main.

Limits: this integration pass used deterministic query/reactive/component fixtures. No interactive browser, focus/layout, clipboard, real-wallet, or live-indexer verification was performed. Prior independent review findings were implemented and regression-tested; the independent reviewers have not re-reviewed these rewritten heads. Existing hook messages reported missing lefthook; no safeguard or hook was bypassed. No PR was merged and no issue was closed.

Remote check status after the integration push: GitHub Validate explorer / validate passed on this exact head. Netlify deploy-preview plus its Pages/Header/Redirect checks failed; the same failures also occur on unchanged PR #32, #33 and #36. GitHub’s output says only “Deploy failed”; the public deploy metadata reports error without a build-cause message. This integration does not claim Netlify is green and does not change cleanup PR #32. The separate Cloudflare check may finish independently.

Genesis query contract inherited from #42: the auth-chain query no longer caps eligible genesis inputs at one. The generated-query/schema execution regression covers authorizing inputs after unrelated inputs and rejects the original query limit. Full suite: 193 tests; typecheck and static build pass.

Shared-icon selection consistency

Provider/revision changes close an existing image preview. Thumbnail readiness resets only when the effective icon URL changes, so providers sharing an icon can open their own selected artwork without waiting for another image load. The regression executes the actual compiled setup with real Vue reactivity and fails under the original behavior. This branch passes 193 top-level tests (including isolated component suites), typecheck, and static build after this correction.

Merge prerequisite PRs with merge commits to preserve stack ancestry and focused diffs; squash/rebase merges require refreshing descendants. All bases remain main, and merges are manual.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:15:02.819728Z 5be5eb6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@netlify

netlify Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for explorer-cash failed.

Name Link
🔨 Latest commit a0e73f5
🔍 Latest deploy log https://app.netlify.com/projects/explorer-cash/deploys/6af926e73a71aa0584a0bf3c

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
explorer a0e73f5 Nov 15 2026, 03:30 AM

@salemkode
salemkode force-pushed the fix/20-burned-supply branch from ec7dd04 to a0e73f5 Compare November 15, 2026 03:28

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant