Skip to content

fix: isolate token and transaction navigation context - #40

Open
salemkode wants to merge 6 commits into
mainfrom
fix/token-transaction-context
Open

salemkode wants to merge 6 commits into
mainfrom
fix/token-transaction-context

Conversation

@salemkode

@salemkode salemkode commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Token and transaction queries dispose the previous observer when route or network changes, clear stale details/errors, and consume initial synchronous Apollo cache results. Cached pagination advances and duplicate page emissions do not double totals. Legacy accounting queries pin the same accepted node for creation and spending, so pending transfers cannot remove confirmed supply or minting authority. Genesis discovery checks every authorizing category input spending output zero. Transaction cards load metadata for the current network/category/publication with cancellation and content-hash validation, rather than reusing a category-only cache; selected identity and artwork are passed through Info/Icon. Refetch and cacheMetadata=false remain supported.

Addresses #18.

This PR keeps base main and descends from cleanup commit 4cd0fb6c2fe09a60dfbf6889fa7b67d72c23a949. Immediate prerequisite: PR #38. Manual merge order: #32 → #35 → #38 → #40. These prerequisites are included in the current diff until they are merged.

Focused comparison against the immediate prerequisite. Documentation: docs/token-transaction-context.md. Feature-specific documentation uses separate files so independent branches do not append competing README sections.

Validation at 548c5dfaf57cfaad927d92c73c75750e75cc3f63: compatible dependencies installed with bun install --frozen-lockfile; bun run lint; bun test (139 top-level passing tests, including subprocess component suites); every test file run individually; bun run lint:type (actual GraphQL document validation/codegen against the unchanged checked-in schema and Nuxt typecheck); bun run build; git diff --check. All passed. No dependencies or backend/schema changes.

The complete eleven-issue aggregate also passes lint, codegen/typecheck, static build, every test file individually, and 425 top-level tests including the preserved exact badge/component suites. Independent merge paths after #32: #33 → #37; #35 → #38 → #40 → #39 → #42 → #41; #34 → #43; #36 independently. All PR bases remain main.

Limits: this integration pass used deterministic query/reactive/component fixtures. No interactive browser, focus/layout, clipboard, real-wallet, or live-indexer verification was performed. Prior independent review findings were implemented and regression-tested; the independent reviewers have not re-reviewed these rewritten heads. Existing hook messages reported missing lefthook; no safeguard or hook was bypassed. No PR was merged and no issue was closed.

Remote check status after the integration push: GitHub Validate explorer / validate passed on this exact head. Netlify deploy-preview plus its Pages/Header/Redirect checks failed; the same failures also occur on unchanged PR #32, #33 and #36. GitHub’s output says only “Deploy failed”; the public deploy metadata reports error without a build-cause message. This integration does not claim Netlify is green and does not change cleanup PR #32. The separate Cloudflare check may finish independently.

Artwork selection: changing metadata providers closes an open preview but preserves thumbnail readiness when the effective icon URL is unchanged. A compiled-setup regression uses real Vue reactivity to switch same-icon/different-artwork providers, then verifies that a changed icon still requires a fresh load. The regression fails before the fix. Full suite: 139 top-level tests, including isolated component suites; typecheck and static build pass.

Shared-icon selection consistency

Provider/revision changes close an existing image preview. Thumbnail readiness resets only when the effective icon URL changes, so providers sharing an icon can open their own selected artwork without waiting for another image load. The regression executes the actual compiled setup with real Vue reactivity and fails under the original behavior. This branch passes 139 top-level tests (including isolated component suites), typecheck, and static build after this correction.

Merge prerequisite PRs with merge commits to preserve stack ancestry and focused diffs; squash/rebase merges require refreshing descendants. All bases remain main, and merges are manual.

@netlify

netlify Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for explorer-cash failed.

Name Link
🔨 Latest commit d97cc00
🔍 Latest deploy log https://app.netlify.com/projects/explorer-cash/deploys/6af9262749098bad720d3afa

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:14:44.038877Z 96a9096 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96a909684f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/hooks/nonSpentToken.ts Outdated
Comment on lines 14 to 15
transaction: { block_inclusions: { block: { accepted_by: { node: { name: { _regex: $network } } } } } }
_not: { spent_by: {} }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include network-matched mempool outputs in token totals

When a token transfer is pending, its inputs are excluded by _not: { spent_by: {} }, but this new block_inclusions predicate also excludes its replacement outputs until confirmation. Consequently, an ordinary transfer now reduces “Supply Excluding Burns” despite burning nothing; transferring the entire supply can make it display zero. The equivalent predicates in nftSupply.ts and activeMinting.ts also temporarily remove transferred NFTs and report a transferred minting baton as inactive. Preserve network isolation by accepting transactions validated by a matching node as well as transactions included in accepted blocks; the schema exposes transaction.node_validations for the mempool relationship.

Useful? React with 👍 / 👎.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
explorer d97cc00 Nov 15 2026, 03:26 AM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant