Repository navigation
Conversation
❌ Deploy Preview for explorer-cash failed.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96a909684f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| transaction: { block_inclusions: { block: { accepted_by: { node: { name: { _regex: $network } } } } } } | ||
| _not: { spent_by: {} } |
There was a problem hiding this comment.
Include network-matched mempool outputs in token totals
When a token transfer is pending, its inputs are excluded by _not: { spent_by: {} }, but this new block_inclusions predicate also excludes its replacement outputs until confirmation. Consequently, an ordinary transfer now reduces “Supply Excluding Burns” despite burning nothing; transferring the entire supply can make it display zero. The equivalent predicates in nftSupply.ts and activeMinting.ts also temporarily remove transferred NFTs and report a transferred minting baton as inactive. Preserve network isolation by accepting transactions validated by a matching node as well as transactions included in accepted blocks; the schema exposes transaction.node_validations for the mempool relationship.
Useful? React with 👍 / 👎.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
explorer | d97cc00 | Nov 15 2026, 03:26 AM |
96a9096 to
548c5df
Compare
Token and transaction queries dispose the previous observer when route or network changes, clear stale details/errors, and consume initial synchronous Apollo cache results. Cached pagination advances and duplicate page emissions do not double totals. Legacy accounting queries pin the same accepted node for creation and spending, so pending transfers cannot remove confirmed supply or minting authority. Genesis discovery checks every authorizing category input spending output zero. Transaction cards load metadata for the current network/category/publication with cancellation and content-hash validation, rather than reusing a category-only cache; selected identity and artwork are passed through Info/Icon. Refetch and cacheMetadata=false remain supported.
Addresses #18.
This PR keeps base
mainand descends from cleanup commit4cd0fb6c2fe09a60dfbf6889fa7b67d72c23a949. Immediate prerequisite: PR #38. Manual merge order: #32 → #35 → #38 → #40. These prerequisites are included in the current diff until they are merged.Focused comparison against the immediate prerequisite. Documentation: docs/token-transaction-context.md. Feature-specific documentation uses separate files so independent branches do not append competing README sections.
Validation at
548c5dfaf57cfaad927d92c73c75750e75cc3f63: compatible dependencies installed withbun install --frozen-lockfile;bun run lint;bun test(139 top-level passing tests, including subprocess component suites); every test file run individually;bun run lint:type(actual GraphQL document validation/codegen against the unchanged checked-in schema and Nuxt typecheck);bun run build;git diff --check. All passed. No dependencies or backend/schema changes.The complete eleven-issue aggregate also passes lint, codegen/typecheck, static build, every test file individually, and 425 top-level tests including the preserved exact badge/component suites. Independent merge paths after #32: #33 → #37; #35 → #38 → #40 → #39 → #42 → #41; #34 → #43; #36 independently. All PR bases remain
main.Limits: this integration pass used deterministic query/reactive/component fixtures. No interactive browser, focus/layout, clipboard, real-wallet, or live-indexer verification was performed. Prior independent review findings were implemented and regression-tested; the independent reviewers have not re-reviewed these rewritten heads. Existing hook messages reported missing lefthook; no safeguard or hook was bypassed. No PR was merged and no issue was closed.
Remote check status after the integration push: GitHub Validate explorer / validate passed on this exact head. Netlify deploy-preview plus its Pages/Header/Redirect checks failed; the same failures also occur on unchanged PR #32, #33 and #36. GitHub’s output says only “Deploy failed”; the public deploy metadata reports
errorwithout a build-cause message. This integration does not claim Netlify is green and does not change cleanup PR #32. The separate Cloudflare check may finish independently.Artwork selection: changing metadata providers closes an open preview but preserves thumbnail readiness when the effective icon URL is unchanged. A compiled-setup regression uses real Vue reactivity to switch same-icon/different-artwork providers, then verifies that a changed icon still requires a fresh load. The regression fails before the fix. Full suite: 139 top-level tests, including isolated component suites; typecheck and static build pass.
Shared-icon selection consistency
Provider/revision changes close an existing image preview. Thumbnail readiness resets only when the effective icon URL changes, so providers sharing an icon can open their own selected artwork without waiting for another image load. The regression executes the actual compiled setup with real Vue reactivity and fails under the original behavior. This branch passes 139 top-level tests (including isolated component suites), typecheck, and static build after this correction.
Merge prerequisite PRs with merge commits to preserve stack ancestry and focused diffs; squash/rebase merges require refreshing descendants. All bases remain
main, and merges are manual.