fix(ingest): replace DEMO-DOC-ID fallback with empty state by PetrefiedThunder · Pull Request #3653 · regengine/RegEngine

PetrefiedThunder · 2026-10-26T14:29:56Z

Follow-up flagged by Codex in its review of #3622 (non-blocking finding: the DEMO-DOC-ID fallback in frontend/src/app/ingest/page.tsx).

Change

The completed-ingest panel renders NormalizedDocumentViewer only when the ingest response has a non-empty document_id. Otherwise it shows a muted empty state ("No normalized document is available for this ingest."). The page no longer makes up a placeholder id.
New src/__tests__/pages/ingest-normalized-viewer.test.tsx covers three cases: document_id absent, document_id empty, and a real id passed through. Ids are generated at runtime with crypto.randomUUID().

Verification

vitest: the new file passes 3/3. Sibling ingest suites pass 29/29.
eslint on the touched files: 0 errors. There is 1 warning, which already existed at page.tsx:182 in code this PR doesn't touch.

Based on origin/main. #3622 is still open, and a test merge of the two branches shows no conflict.

Note

Low Risk
UI-only ingest completion behavior with no auth or API contract changes; reduces risk of misleading document previews.

Overview
After URL ingest completes, the completed panel no longer fabricates a document id from doc_id, job_id, or the DEMO-DOC-ID placeholder. NormalizedDocumentViewer renders only when the ingest response includes a non-empty document_id; otherwise users see a muted message: No normalized document is available for this ingest.

Tests were updated to match: an existing CSV/URL scenario that completes without document_id now asserts the empty state instead of a fake viewer receipt, and a new ingest-normalized-viewer suite covers absent, empty, and valid document_id cases.

^{Reviewed by Cursor Bugbot for commit ff2daa4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Signed-off-by: Christopher Sellers <1@christophersellers.com>

vercel · 2026-10-26T14:30:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
regengine	Ready	Preview	Oct 28, 2026 2:32pm UTC

chatgpt-codex-connector · 2026-10-26T14:30:13Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T14:40:20.841060Z	`bd036ef`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-26T14:30:27Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: regengine/RegEngine
Branch: muse/remove-demo-doc-id
File: .coderabbit.yaml
Commit: ff2daa4
Layers: Repository YAML
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 64121dfc-126c-4cf6-9fb0-a0a54d296012

Commits

Reviewing files that changed from the base of the PR and between 5144d59 and ff2daa4.

Files selected for processing: 2

frontend/src/__tests__/pages/ingest-csv.test.tsx
frontend/src/app/ingest/page.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The completed-ingest page now renders the normalized viewer only when the response contains a non-empty document_id. Otherwise, it displays a message that no normalized document is available. Tests cover missing, empty, and present document IDs.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · up to ff2da

The change consistently handles missing, empty, and valid document IDs with corresponding test coverage.

Pre-merge checks: 5

Check name	Status	Explanation
Description check		The description clearly explains the change, test coverage, verification results, and risk. It omits the template headings for Type of Change, Checklist, and Related Issues, but the main required cont…
Title check		The title is concise and accurately identifies the main change: removing the DEMO-DOC-ID fallback and using an empty state for ingest.
Docstring Coverage		Docstring coverage is inconclusive: files from earlier reviews still need to be rechecked within the check's analysis limits. Not blocking.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description clearly explains the change, test coverage, verification results, and risk. It omits the template headings for Type of Change, Checklist, and Related Issues, but the main required context is present.

Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-26T15:13:00Z

✅ Bundle Size Report

Metric	Size
Total JS	5579.8KB (5.44MB)
Total CSS	131.9KB
Limit	10.0MB

Bundle is within the 10.0MB limit.

github-actions · 2026-10-26T15:21:24Z

PR Blocker Checklist

Head SHA: ff2daa4601e87b04cfc9f85c67436b3e6f0354f9

Status: Ready

All review threads resolved
No reviews requesting changes
No blocked review engines

github-actions · 2026-10-26T15:49:10Z

Vercel preview: https://regengine-kb90xunm0-petrefiedthunders-projects.vercel.app

Access is via Vercel login (Deployment Protection).

PetrefiedThunder

REVIEW: PASS gemini 5144d59

Code Review: RegEngine #3653

1. Correctness

Derived State: completedDocumentId cleanly derives ingestMutation.data?.document_id during render without unnecessary effects or state synchronization.
Defensive Guard: The check typeof completedDocumentId === 'string' && completedDocumentId.length > 0 properly handles undefined, null, and empty string inputs, ensuring <NormalizedDocumentViewer /> is only mounted when a valid identifier exists.
Empty State: Renders an accessible, appropriately styled fallback message (text-small text-re-text-tertiary) when no document ID is present.

2. Security & Tenant Isolation

Elimination of Mock Fallback: Removes the hardcoded fallback 'DEMO-DOC-ID', which previously risked leaking demo state, triggering cross-tenant lookup anomalies, or polluting audit evidence.
Safe Handling: Sourced exclusively from authenticated mutation response data with no client-side injection vectors.

3. Tests

Coverage: Adds comprehensive unit tests covering:
- Missing/absent document_id (verifies fallback message and absence of viewer).
- Empty string document_id (verifies fallback message and absence of viewer).
- Valid document_id (verifies viewer renders with exact document ID).
Tooling & Secret Scanning: Uses vi.hoisted for Vitest mock hoisting and includes // pragma: allowlist secret for the auth mock to satisfy CI secret scanners (detect-secrets).

VERDICT: PASS

Resolve ingest page conflict: keep #3653 empty-state fallback (no DEMO-DOC-ID) and keep #3665 activeSaveError callout in the completed panel. Update ingest-csv test expectations accordingly. Signed-off-by: Christopher <131207452+PetrefiedThunder@users.noreply.github.com>

PetrefiedThunder · 2026-10-28T14:35:06Z

REVIEW: PASS hermes ff2daa4

Merge ff2daa4 (PR + origin/main 4823440) keeps both sides of ingest/page.tsx: Muse empty state (completedDocumentId = document_id only; no DEMO-DOC-ID / job_id fallback; "No normalized document is available for this ingest.") and #3665 activeSaveError Callout. ingest-csv.test.tsx asserts empty state + no viewer receipt. No hermes commits on branch. Preview badges intact; no FDA/compliance-guarantee claims; DEMO-DOC-ID only in a test comment.

Local (SSD, load~7): vitest ingest-csv + ingest-normalized-viewer 19/19; tsc --noEmit exit 0; eslint touched files 0 errors (1 preexisting react-hooks/set-state-in-effect warning at page.tsx:221 from merged main). CI at post: CodeQL Analyze + Semgrep still queued/pending; Bugbot/Vercel pass; PR Blocker fail (expected pre-PASS). No push/merge.

fix(ingest): replace DEMO-DOC-ID fallback with empty state

bd036ef

Signed-off-by: Christopher Sellers <1@christophersellers.com>

vercel Bot deployed to Preview October 26, 2026 14:31

View deployment

github-actions Bot added the frontend label Oct 26, 2026

chore: merge origin/main into muse/remove-demo-doc-id

5144d59

vercel Bot deployed to Preview October 28, 2026 03:59

View deployment

This was referenced Oct 28, 2026

feat(ftl-checker): F6 results loading + F7 Continue to exemptions (SEL-585) #3687

Merged

fix(ingest): list per-event EPCIS batch errors and clear stale results before API-key save #3665

Merged

PetrefiedThunder commented Oct 28, 2026

View reviewed changes

vercel Bot deployed to Preview October 28, 2026 14:32

View deployment

PetrefiedThunder merged commit 30d6de1 into main Oct 28, 2026
76 of 82 checks passed

PetrefiedThunder deleted the muse/remove-demo-doc-id branch October 28, 2026 18:22

Navigation Menu

Repository navigation

fix(ingest): replace DEMO-DOC-ID fallback with empty state - #3653

fix(ingest): replace DEMO-DOC-ID fallback with empty state#3653
PetrefiedThunder merged 3 commits into
mainfrom
muse/remove-demo-doc-id

PetrefiedThunder commented Oct 26, 2026 •

edited by cursor Bot

Loading

Uh oh!

vercel Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

PetrefiedThunder left a comment

Uh oh!

PetrefiedThunder commented Oct 28, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

PetrefiedThunder commented Oct 26, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change

Verification

Uh oh!

vercel Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Bundle Size Report

Uh oh!

github-actions Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Blocker Checklist

Status: Ready

Uh oh!

github-actions Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PetrefiedThunder left a comment

Choose a reason for hiding this comment

Code Review: RegEngine #3653

1. Correctness

2. Security & Tenant Isolation

3. Tests

Uh oh!

PetrefiedThunder commented Oct 28, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

PetrefiedThunder commented Oct 26, 2026 •

edited by cursor Bot

Loading

vercel Bot commented Oct 26, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 26, 2026 •

edited

Loading

coderabbitai Bot commented Oct 26, 2026 •

edited

Loading

github-actions Bot commented Oct 26, 2026 •

edited

Loading

github-actions Bot commented Oct 26, 2026 •

edited

Loading

github-actions Bot commented Oct 26, 2026 •

edited

Loading