Repository navigation
[PR] fix: tolerate JSON null content during storage identity backfill - #6055
ranxianglei merged 1 commit into
Conversation
(ai: vllm-qwen/qwen3.8-27b) Dedup check: no duplicate. Searched open+closed issues and PRs for this failure signature (identity backfill + JSON null + storage): the only entries are bug report #6045 and this PR itself. The related work the author cites (#4672 archive/restore identity carry, #4684 streaming backfill, #4888 generation retirement) covers different mechanisms; none touches null-content tolerance. Labels (judgment): Initial verification (targeted, local):
CI (read from the mirror cache, fetched 15:20 UTC): 5 lanes green (gate ×2, docs-coverage, lane-guard, unused-exports), 14 test/static shards queued, 0 failures so far. Full-suite verdict pending — my final review conclusion follows once the shards finish. |
(ai: vllm-qwen/qwen3.8-27b) CI is now fully green (mirror cache, fetched 15:55 UTC): 30 checks — 18 success, 12 skipped (e2e lanes correctly not triggered by this diff), 0 failures. Master has since moved 111 commits past the PR base ( Review verdict: pass. Direction is right (the reported failure is real and reproduced on master), the fix lands at the root-cause layer (the shared identity function, not one call site), the behavioral delta is exactly the one crashing case, the tests have teeth (the migration e2e test fails red pre-fix), and the diff is minimal and clean (one commit, 2 files, +67/−2, no version/lockfile churn). Per §7.4 this stays in the human review tier because it touches storage identity (id logic) — no auto-merge. 结构化八问
测试有效性:三条新测试均为真测试——单元级断言 9 种非对象输入的 raw-bytes 哈希 + 元数据剥离契约的双向钉死(同内容不同位置戳同 identity、改内容必变);e2e 级构造真实 SQLite v7 库插入 null 行走完 代码整洁度:3 行守卫 + 64 行测试,命名/引号/缩进与仓库一致,无死代码、无魔法值、无跑题改动。 收工判定:审核通过,可合并(human 档,请 owner 自行 merge:https://github.com/ranxianglei/billion-context/pull/6055)。 |
(ai: vllm-qwen/qwen3.8-27b) Closing summary (the substance is already on floor 3 and floor 5 above):
|
Problem
Identity backfill treats parsed JSON null as an object, throwing TypeError and aborting SQLite migration.
Changes
Hash null/scalar/array content as its unchanged raw bytes while retaining normal message metadata stripping.
Regression coverage
Raw JSON null/scalar/array identities, normal positional-metadata stripping, and real SQLite v7→v11 migration with unchanged content bytes and stable reopening.
Validation
Passed against exact fork commit
6b0cb61a6ce69241faff00164e9195c85bb4e9fcin an isolated GitHub Actions checkout: validation job. The targeted regression and related suites,npm run typecheck, andnpm run buildall passed on Node 22. This is targeted verification, not the full upstream CI matrix.Related work
Related #4672, #4684 and #4888 cover archive/migration/generation work; this is the null-content failure.
Closes #6045.