Repository navigation
Conversation
|
Thanks for the rerun. Windows Node 22 shard 1, attempt 2 succeeded on For the record, the original failure was the launcher test's elapsed-time assertion (2137 ms against a 2000 ms limit); its spawn and child assertions passed. The test uses injected spawn, health and sleep functions and does not exercise the summary SSE readers changed here. The same case passed in the #6084 control job on the same base with byte-identical launcher test/source files. The real Codex four-phase E2E gate remains outstanding. Could the owner run it on this head with the repository's working upstream configuration and attach the result before merge? The core CI rerun does not cover that gate. Windows Node 24 coverage also still needs |
(ai: vllm-qwen/qwen3.8-27b) Done — verified and rerun. What I checked. In run 42752780208 the only failing job is assert.ok(Date.now() - t0 < 2000, `early bail took ${Date.now() - t0}ms; must not burn the full wait window`);The functional assertions immediately before it ( Your diff confirms independence: PR #6102 touches only Action taken. Triggered Still needed before merge (separate from this). The real Codex four-phase E2E gate noted in your description requires a run against the repo's working upstream configuration — that's an owner-side action not covered by this shard rerun. Flagging so it isn't lost. (Dedup: no separate issue/PR tracks this — it's a direct CI-rerun request on #6102 itself; per repo CI-coordination practice I'm not opening a new issue for a CI red.) 结构化八问(中文,供人工复核)
判定:本分片的偶发红已按「核验→重跑」处理,等 attempt 2 结果落地即闭环;合并前仍需 owner 侧用可用上游配置补一次真实 Codex 四阶段 E2E gate。 |
(ai: vllm-qwen/qwen3.8-27b) Re-verified live before touching anything — everything is already green. No code changes made this run, nothing pushed. Live check state (mirror cache, fetched 2026-11-10 13:47 UTC, head Specifically for the reported blocker One observation, not a blocker: the branch is currently behind master ( 结构化八问(中文)
结论:CI 已全绿,本轮无动作,收工。 分支落后 master(非冲突),留待人工合并时处理。 |
[ework] CI fix verified green ✓ |
|
Landed via batch PR #6439 (merged) — closing as superseded. |
(ai: vllm-qwen/qwen3.8-27b) Acknowledged — CI lane for this PR is done: all 30 checks were green on the final head |
(ai: vllm-qwen/qwen3.8-27b) Verified live — this PR's work is already in master, so there's nothing left to do from this lane. No new/parallel PR opened, nothing pushed. Live state (checked via git, not just the thread):
So the SSE buffered-event fix shipped through the merged batch, superseding #6102. The flaky Windows-shard rerun I triggered earlier (attempt 2 → green, 0/28 failures) is now moot — the change went in via the batch regardless, and that run is green anyway. The description's "four-phase E2E gate still needs a working upstream" note is likewise moot: the change already shipped. No further action needed from this lane; the owner's "closing as superseded" is correct. 结构化八问(中文,供人工复核)
|
Problem
Both the preflight summary extractor and external HTTP summary validator parse each data line independently as JSON. Valid SSE events may carry multiple data fields joined with LF; pretty-printed JSON therefore yields an empty summary or invalid-frame error and unnecessary fallback.
Changes
Group buffered events in the existing sse-util module and join data fields before either summary reader parses JSON. Preserve event-type scope, malformed-JSON rejection and existing framing/terminal contracts. WHATWG data-field semantics: https://html.spec.whatwg.org/multipage/server-sent-events.html#event-stream-interpretation
Validation
The full remote-suite verdict belongs to CI. #4 handles streaming splitters, #260 handles plugin event rewriting, and #1709 handles dangling DONE sentinels. These buffered summary readers still lacked multiline event grouping. All 3,221 historical PRs were screened; independent of #6046–#6055.
Pipeline E2E gate
The repository requires the real Codex four-phase suite before merging preflight changes. E2E_CHECK=1 ran the CLI/dist preflight here, but the default local upstream /models endpoint was unreachable and no E2E upstream credentials are configured. The four-phase test is not claimed as passed. Keep the existing ACP_TEST_E2E gate and run this required merge check with a working upstream; fork CI may skip the secret-dependent lane.
Closes #6101