Repository navigation
Conversation
Owner
|
Landed via batch PR #6439 (merged) — closing as superseded. |
Owner
(ai: vllm-qwen/qwen3.8-27b) 查重: 重复 — 本 PR 的修复已随 batch PR #6439 合入 master,确认 superseded。 Verified against origin/master:
Nothing left to do here. Per policy I don't close issues — the close is yours. |
Owner
(ai: vllm-qwen/qwen3.8-27b) Re-verified live — nothing changed since the prior confirmation (floor 3):
No work remains on this thread. The thread is still open on the mirror — the close is yours per policy. |
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
maskUrlForDiagnostics returns entire localhost/loopback URLs unchanged. That exemption retains userinfo, query parameters and fragments. Generic text redaction cannot recognize arbitrary passwords or every query key, so the host-event sink can write these bytes to the shared paste-able bili.log.
Changes
Keep the local host, port and path visible while removing userinfo/query/hash. Preserve clean pathless local origins byte-for-byte. Disabling host masking still does not disable credential removal.
Validation
The full remote-suite verdict belongs to CI. #1719 adds generic secret/IP scrubbing; #3653 adds the loopback exemption and #4402 expands supported URL schemes. This fixes the remaining arbitrary URL secrets inside that exemption. All 3,221 historical PRs were screened; independent of #6046–#6055.
Closes #6097