Skip to content

[PR] fix: separate IPv6 socket hosts from CONNECT authorities - #6092

Closed
Afloat16 wants to merge 1 commit into
ranxianglei:masterfrom
Afloat16:2026-11-10_ipv6-proxy-tunnels
Closed

Afloat16 wants to merge 1 commit into
ranxianglei:masterfrom
Afloat16:2026-11-10_ipv6-proxy-tunnels

Conversation

@Afloat16

Copy link
Copy Markdown
Contributor

Problem

URL.hostname retains brackets around IPv6 literals, while net.connect expects a bare address. IPv6 proxy and bracketed direct connections try resolving [::1] as a hostname. HTTP CONNECT has the inverse problem: bare IPv6 destinations are emitted without required authority brackets.

Changes

Normalize socket hosts to bare literals and format IPv6 CONNECT request targets and Host headers with brackets. Cover HTTP/HTTPS proxy parsing, actual IPv6 connections and captured CONNECT traffic.

Validation

  • Before: tests/fix-78-connect-timeout.test.ts — 4 passed, 4 failed.
  • After: the target plus tests/upstream-proxy-routing.test.ts — 23 passed, 0 failed. All local IPv6 cases ran without skips.
  • npm run typecheck — passed.
  • npm run build — passed.
  • Published fork tree 5a4168e8164dae6f4014d8b2816f1598b07bad15 exactly matches tested local commit 30f2d170521f261601feee5f0a8fd91ebb84f652.

The full remote-suite verdict belongs to CI. Earlier cross-platform/default-host changes #21/#23 and CONNECT admission #2145 do not fix the socket-host versus HTTP-authority representations in these helpers. All 3,221 historical PRs were screened; independent of #6046–#6055.

Closes #6091

@ranxianglei ranxianglei changed the title fix: separate IPv6 socket hosts from CONNECT authorities [PR] fix: separate IPv6 socket hosts from CONNECT authorities Nov 10, 2026
@ranxianglei

Copy link
Copy Markdown
Owner

Landed via batch PR #6439 (merged) — closing as superseded.

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

Confirmed the supersession before closing. Batch PR #6439 (merged 2026-11-12 22:01 +08, branch ranxianglei/afloat-dry) carries this exact fix as commit c7e39ee51a — "fix: separate IPv6 socket hosts from CONNECT authorities", a cherry-pick of the original 95f6818d92 from this branch — touching src/upstream-proxy.ts and tests/fix-78-connect-timeout.test.ts, the same files listed here.

So #6092's change is already in master via #6439. Closing as superseded is correct. (Leaving the close to you per the close-authority rule.)

@ranxianglei

Copy link
Copy Markdown
Owner

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

Reporting after an unexpected restart (I was stuck ~32 min with no output and got force-restarted).

State — verified live just now, not from memory:

  • The fix is already in master. Batch PR [PR] chore(batch): land 50 open Afloat16 fixes in one history-preserving batch #6439 (merged, ranxianglei/afloat-dry) carries this exact fix as c7e39ee51a (cherry-pick of the original 95f6818d92), touching src/upstream-proxy.ts + tests/fix-78-connect-timeout.test.ts. git merge-base --is-ancestor c7e39ee51a master confirms it's in master.
  • This thread is still OPEN. Your Floor-1 call was "closing as superseded" — that close is your action (close authority is owner-only, I don't close).

Nothing left to work on and no decision needed: the change is already landed via #6439, so I'm not opening a parallel fix PR (it would just duplicate what #6439 merged). The only remaining step is your close.

(This confirms my earlier Floor-3 reply; no new work was produced in the stuck window.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPv6 HTTP proxy and direct tunnel hosts use the wrong bracket form

2 participants