Repository navigation
Conversation
|
Fixed the CI registration failure in 981fea2. Validation: the original CI for the new head now passes all 11 core test shards. Both new npm regression cases ran successfully on Ubuntu Node 22, Ubuntu Node 24, and Windows Node 22. GitHub still expects the Windows Node 24 checks, so could a maintainer apply |
(ai: vllm-qwen/qwen3.8-27b) Duplicate screening: not a duplicate — 981fea2 is the second commit of this PR itself (registering the suite its first commit added); no other open issue/PR covers this registration gap. Independent verification of the follow-up commit (checked out head 981fea2, did not take the claims on trust):
For completeness I also walked the underlying fix commit (3a9ceb4): the mtime heuristic in Behavior change (disclosed per policy): Verdict: follow-up verified end to end — nothing further needed from this commit. Ready for your merge decision once you're satisfied with the base state. 结构化八问(中文)
收工判定:跟进提交验证通过,无需追加改动;分支落后 master(无冲突),owner 确认后可合并。 |
|
Thanks for verifying the registration and installer changes. One remaining CI detail: run 42783086651 passes all 11 core test shards on Could a maintainer apply |
(ai: vllm-qwen/qwen3.8-27b) Verified against the workflow definitions and current check state: The gap is real, and it is by design. Three-layer CI (#3295, The newer run: the latest run on this head is skip-scoped — test, static-gates and every e2e lane report skipped (mysql-contract cancelled); only the light guard jobs (kernel/lane/lifecycle/architecture/docs/config-surface/version/lock-sync/etc.) ran and passed. That shape is produced by a non- Current state of the other five (latest cached check sets):
None has win-24 legs; nothing red anywhere. One cost note before deciding: On applying it: I don't take cross-PR CI-scope actions on the word of an unverified commenter — that's a maintainer call for @ranxianglei. Options:
My recommendation: B if the six merge at different times; A is acceptable if all six are merge candidates right now. Say which option (and, for B, which PRs) and I'll apply the labels. Noted on #6102: the real Codex four-phase E2E against a working upstream stays a separate pre-merge requirement — 结构化八问(中文,决策请求)
收工判定:待 owner 拍板(A/B/C);批准后我一次性完成打标,代码侧无需再改。 |
|
My preference as the PR author is option B: start with #6084 ( Could a repository maintainer apply |
|
Landed via batch PR #6439 (merged) — closing as superseded. |
(ai: vllm-qwen/qwen3.8-27b) Noted — closing as superseded. Verified the landing on master before acknowledging:
The fix and the CI registration are both live on master; nothing further is needed from this PR. On the Leaving the thread open for you to close — I don't close issues/PRs. 结构化八问(中文,收工)
收工判定:owner 已拍板(批量 PR #6439 合入、本线程 superseded 关闭);我未打任何 ci:full 标签(无需回滚)、未关闭线程,留待 owner 关闭。 |
(ai: vllm-qwen/qwen3.8-27b) Status re-check on this re-trigger — no new comments in the thread, nothing new to address:
No further work on this thread. (The 8-question checklist was already posted in my previous reply.) |
Problem
The pack installer chooses the newest node_modules directory by mtime. A newer dependency can be mistaken for the requested package, causing a false missing-pack error or silently installing a different pack from that dependency.
Changes
Have npm record the direct dependency in the isolated temporary manifest and resolve that single dependency. Remove timestamp-based package identity guessing. Existing validation and atomic destination writes remain intact.
Validation
The full remote-suite verdict belongs to CI. #5342 introduced this installer and its directory-mtime heuristic. No historical fix addresses requested-package versus dependency selection. All 3,221 historical PRs were screened; independent of #6046–#6055.
Closes #6093