Repository navigation
π Keep human-only follow-ups out of the owner-delegate's default approve - #19290
clubanderson wants to merge 3 commits into
Conversation
A governor follow-up quoting the security review's hand-off to a person was default-approved and landed at 010 where no agent can act (#19229). Add a structured security_routed_to_person aggregate field, classify a security hand-off as a policy sign-off, add a human-only delegate rule ahead of the defaults that keeps the park with needs-owner, show such issues as needing the owner on the dashboard, and stop owner-only from matching a PR's topic words in its title (#19226). Fixes #19289 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
The glossary already uses human-only as an alias of the blocker family, so the rule slug collided and resolved to the wrong entry. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Summary
Asks only a person can answer no longer pass through the owner-delegate's
default-approve/default-release(#19229 was default-approved to 010, claimed and dropped).review: structuredsecurity_routed_to_personon the aggregate (the security report itself returnedrequires_human, not the relay's stamp on a decision question), read viaAggregate.SecurityRequiresPerson();ClassifyDecisionQuestionreturns policy sign-off for it, so the reviewer-question auto-decide no longer merges such a head as-is and files a claimable follow-up.delegatedecision: newperson-onlyrule ahead of the defaults (issue:Input.HumanOnly; PR:Input.SecurityRequiresPerson, adopted-in-place PRs keepadopted-security-finding). Recommend-only, keeps the park, addsneeds-owner.owner-onlyon a PR reads the question, park reasons or a grant-verb title, not a topic word in the title (π fix: consistent redirect policy and credential stripping for http clientsΒ #19226 "credential stripping" was told to "set or rotate the secret named in the title"). Issues unchanged.dashboard:issueHumanOnlyAsk(human-only marker / label, notneeds-humanalone, or a governororigin/governor+follow-upissue quotingsecurity requires human:in the aggregate's own summary format) feeds the decider; the tracker row decision reads Needs the owner with Let hive decide disabled; the contributor relay withholds those follow-ups.Tests
pkg/review/security_routed_19229_test.go: field set by a security requires_human, not by a stamped decision question, needs RequiresHuman; summary matcher; classifier sign-off plus scope control.pkg/delegatedecision/human_only_19229_test.go: issue keeps park with needs-owner and no approve; default-approve control; PR security hand-off not released plus control; adopted PR keeps its rule; PR owner-only title topic vs grant title / question / reason; issue title match unchanged.pkg/dashboard/human_only_followup_19229_test.go: governor follow-up shape,issueHumanOnlyAsk(marker, label, needs-human excluded), owner-only popover disables delegate, needs-human control.Fixes #19289