Skip to content

πŸ› Keep human-only follow-ups out of the owner-delegate's default approve - #19290

Open
clubanderson wants to merge 3 commits into
v5from
fix-human-only-followups
Open

clubanderson wants to merge 3 commits into
v5from
fix-human-only-followups

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Summary

Asks only a person can answer no longer pass through the owner-delegate's default-approve / default-release (#19229 was default-approved to 010, claimed and dropped).

  • review: structured security_routed_to_person on the aggregate (the security report itself returned requires_human, not the relay's stamp on a decision question), read via Aggregate.SecurityRequiresPerson(); ClassifyDecisionQuestion returns policy sign-off for it, so the reviewer-question auto-decide no longer merges such a head as-is and files a claimable follow-up.
  • delegatedecision: new person-only rule ahead of the defaults (issue: Input.HumanOnly; PR: Input.SecurityRequiresPerson, adopted-in-place PRs keep adopted-security-finding). Recommend-only, keeps the park, adds needs-owner.
  • owner-only on a PR reads the question, park reasons or a grant-verb title, not a topic word in the title (πŸ› fix: consistent redirect policy and credential stripping for http clientsΒ #19226 "credential stripping" was told to "set or rotate the secret named in the title"). Issues unchanged.
  • dashboard: issueHumanOnlyAsk (human-only marker / label, not needs-human alone, or a governor origin/governor + follow-up issue quoting security requires human: in the aggregate's own summary format) feeds the decider; the tracker row decision reads Needs the owner with Let hive decide disabled; the contributor relay withholds those follow-ups.
  • Docs (activity monitor rules table, decision glossary) and changelog fragment.

Tests

  • pkg/review/security_routed_19229_test.go: field set by a security requires_human, not by a stamped decision question, needs RequiresHuman; summary matcher; classifier sign-off plus scope control.
  • pkg/delegatedecision/human_only_19229_test.go: issue keeps park with needs-owner and no approve; default-approve control; PR security hand-off not released plus control; adopted PR keeps its rule; PR owner-only title topic vs grant title / question / reason; issue title match unchanged.
  • pkg/dashboard/human_only_followup_19229_test.go: governor follow-up shape, issueHumanOnlyAsk (marker, label, needs-human excluded), owner-only popover disables delegate, needs-human control.

Fixes #19289

A governor follow-up quoting the security review's hand-off to a person
was default-approved and landed at 010 where no agent can act (#19229).
Add a structured security_routed_to_person aggregate field, classify a
security hand-off as a policy sign-off, add a human-only delegate rule
ahead of the defaults that keeps the park with needs-owner, show such
issues as needing the owner on the dashboard, and stop owner-only from
matching a PR's topic words in its title (#19226).

Fixes #19289

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19265 πŸ› Name how a sign-off ask was answered on the tracker Review track same files src/docs/dashboard-sections/activity-monitor.md
#19301 πŸ› Close partially-addressed issues the scanner verified complete same files src/pkg/dashboard/stage_tracker_decision.go
#19261 πŸ› Lift delegated park labels on a detached bounded context same files src/pkg/dashboard/api_repo_item_decide_delegated.go

@hivecommons-hive

hivecommons-hive Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (dashboard 2/4)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

The glossary already uses human-only as an alias of the blocker family,
so the rule slug collided and resolved to the wrong entry.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Keep human-only follow-ups out of the owner-delegate's default approve

1 participant