Repository navigation
π Close partially-addressed issues the scanner verified complete - #19301
clubanderson wants to merge 2 commits into
Conversation
The scanner's verify-once note said "this can be closed" in free text and nothing acted on it, so finished Refs-only issues sat at 010 until a person closed them (#17157, #19177). The verify-once kick now asks for a machine-readable <!-- hive:verification verdict=complete|partial prs=N --> marker; the issue stage sweep reads it from hive-authored comments and, on two reads one settle interval apart, closes the issue with an evidence comment when every cited PR merged and no linked PR is open, or parks it in a hive/verify-close 045 lane the dashboard shows with a one-click Close. verdict=partial adds hive/verified-open. Held, tracking, umbrella, open-children, person-reopened and person-unlaned issues are skipped. Fixes #19299 Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. |
The lane note carries a hive marker so it is idempotent, the label is added directly (its colour comes from the escalation label definitions), and verified_close.go joins the direct-write baseline like the tracker and decomposed-parent closes. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Summary
Finished
Refs-only issues now get closed. The scanner's verify-once note said "this can be closed" in free text (#17157, #19177) and nothing acted on it.<!-- hive:verification verdict=complete prs=N[,M] -->orverdict=partial(github.VerificationMarker).pkg/github/verified_close.go(closeVerifiedComplete, run from the issue stage sweep next to the tracker auto-close): for openhive/partially-addressedissues (or ones already in the lane), reads the marker from hive-authored timeline comments only, then on two reads one settle interval apart (reusestrackerReadDue/trackerSettled/trackerEvidenceHashfrom β¨ Close tracker and umbrella issues whose referenced work is done (opt-in)Β #19151):hive/verify-close, a hard-suppress park atstage/045-needs-decision, one status note naming the unmet guard) when a cited PR is not merged, a linked PR is open, notes disagree, no PR is cited, more than 20 PRs, or the reporter-confirmation gate applies;verdict=partialaddshive/verified-open.hive/tracking, umbrella or tracker, open sub-issue, reopened by a person, lane label removed by a person, no marker.decide:close-issue).stage/050-verify-close, but 050 is the PR stagestage/050-review-pendingand the stage table keeps issue (010 to 045) and PR (050 to 100) stages disjoint. So the lane is a 045 park label instead of a new numbered stage. It can become its own stage later if wanted.Tests
pkg/github/verified_close_test.go: marker parsing; every guard indecideVerifyClose; the candidate pre-filter; the sweep end to end (close only on the second read with evidence; lane for an unmerged cited PR, an open linked PR and disagreeing notes; partial adds verified-open; hold, tracking, umbrella, person reopen, person lane removal, foreign-author marker and free text never touched; a plain issue costs no timeline reads); the lane label parks at 045.pkg/dashboard/stage_tracker_verify_close_test.go: lane popover leads with an enabled one-click close, plus a control.Fixes #19299