Skip to content

🐛 Keep human-only follow-ups out of the owner-delegate's default approve #19289

Closed

Description

@clubanderson

Problem

Governor follow-ups whose ask is a person's security read are auto-decided by the owner-delegate rule default-approve ("an agent may claim it") and land at stage/010-actionable, where no agent can act. #19229 ("A reviewer handed this to a person: security requires human: Not deeply reviewed: the diff touches Hive proxy policy...") was claimed by a contributor, handed back to 045, then default-approved back to 010.

Root causes:

  1. The reviewer-question auto-decide (governor.review.auto_decide_questions) classified the source PR's security hand-off (🐛 fix: fail-closed fault injection for proxy policy seams #19227) as a scope question, so the PR merged as-is and the hand-off was filed as claimable follow-up work.
  2. The delegate's issue rules have nothing ahead of default-approve for an ask only a person can answer; the PR rules likewise reach default-release.
  3. Same class: rule owner-only matched the title of PR 🐛 fix: consistent redirect policy and credential stripping for http clients #19226 ("consistent redirect policy and credential stripping for http clients") on the word "credential" and answered a code-review decision with "set or rotate the secret named in the title".

Fix

  • Structured field on the review aggregate: security_routed_to_person (the security perspective's own report returned requires_human, not the stamp the relay puts on every perspective of a decision question), read through Aggregate.SecurityRequiresPerson().
  • Classifier: a security hand-off is a policy sign-off, never a scope question.
  • Delegate: new human-only rule ahead of the defaults. Issues: <!-- hive:human-only --> marker, human-only label (not needs-human alone), or a governor follow-up quoting the security hand-off. PRs: SecurityRequiresPerson. Keeps the 045 / 085 park, adds needs-owner, one owner-action comment.
  • Dashboard: such issues show as needing the owner, with Let hive decide disabled; the contributor relay does not offer them.
  • owner-only on a PR reads the question, park reasons, or a grant-verb title, not a topic word in the title.

Activity

  1. self-assigned this
    on Nov 19, 2026
  2. clubanderson commented on Nov 19, 2026

    @clubanderson
    MemberAuthor

    Claiming: fix in progress on branch fix-human-only-followups; PR to follow.

  3. clubanderson commented on Nov 19, 2026

    @clubanderson
    MemberAuthor

    PR: #19290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions