Skip to content

πŸ› Lift delegated park labels on a detached bounded context - #19261

Open
kellyaa wants to merge 1 commit into
v5from
fix/19256-park-lift-ctx
Open

kellyaa wants to merge 1 commit into
v5from
fix/19256-park-lift-ctx

Conversation

@kellyaa

@kellyaa kellyaa commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

The self-report in #19256 shows delegated decision: park label not lifted with error=context deadline exceeded (5 in 10m on PR #19253).

liftDelegatedParkLabels runs last in executeDelegatedDecision, after the decision's comment, approval and adoption writes. By then the caller's context (the request, or the 15s post-approval reporting window) is often spent. Each RemoveLabel then fails, and the next label-derived pass parks the PR in 085 again.

Change: the lift now runs on its own context.WithTimeout(context.WithoutCancel(ctx), 15s). It still finishes when the caller's budget is gone, and it stays bounded.

  • TestDelegatedParkLiftSurvivesSpentContext calls the lift with an expired context and checks that both park labels come off.
  • Changelog fragment added.

Fixes #19256

πŸ€– Generated with Claude Code

-- hive: backend=claude model=claude-opus-5-5

The park-label lift runs after the decision's own writes, so the caller's
context was often spent and every removal failed with 'context deadline
exceeded', leaving the PR parked in 085. Run the lift on its own bounded
context detached from the caller's cancellation.

Fixes #19256

Hive-Run: #19256
Hive-Plan: selfreport-fix
Hive-Spec: delegated-decision#park-lift

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: kellyaa <kellyaa@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 19, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

1 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/pkg/dashboard/api_repo_item_decide_delegated.go 936 ARITHMETIC_BASE

Verdict: uncovered (#17349).

@hivecommons-hive

hivecommons-hive Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

stage 095-pre-merge-soak β†’ 060-reviewed: untrusted-author-role

Ready for a human merge: verdict approved 7a1290e, 77/77 checks green, DCO yes, soak 10m0s elapsed. Blocked only by role/untrusted (no trusted-author role).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19290 πŸ› Keep human-only follow-ups out of the owner-delegate's default approve same files src/pkg/dashboard/api_repo_item_decide_delegated.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[selfreport] unclassified_error_repeated: delegated decision: park label not lifted

1 participant