Repository navigation
Conversation
The park-label lift runs after the decision's own writes, so the caller's context was often spent and every removal failed with 'context deadline exceeded', leaving the PR parked in 085. Run the lift on its own bounded context detached from the caller's cancellation. Fixes #19256 Hive-Run: #19256 Hive-Plan: selfreport-fix Hive-Spec: delegated-decision#park-lift Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: kellyaa <kellyaa@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Mutation testing1 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. stage 095-pre-merge-soak β 060-reviewed: untrusted-author-role Ready for a human merge: verdict approved The hive never approves on your behalf: |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
The self-report in #19256 shows
delegated decision: park label not liftedwitherror=context deadline exceeded(5 in 10m on PR #19253).liftDelegatedParkLabelsruns last inexecuteDelegatedDecision, after the decision's comment, approval and adoption writes. By then the caller's context (the request, or the 15s post-approval reporting window) is often spent. EachRemoveLabelthen fails, and the next label-derived pass parks the PR in 085 again.Change: the lift now runs on its own
context.WithTimeout(context.WithoutCancel(ctx), 15s). It still finishes when the caller's budget is gone, and it stays bounded.TestDelegatedParkLiftSurvivesSpentContextcalls the lift with an expired context and checks that both park labels come off.Fixes #19256
π€ Generated with Claude Code
-- hive: backend=claude model=claude-opus-5-5