Repository navigation
π Name how a sign-off ask was answered on the tracker Review track - #19265
clubanderson wants to merge 5 commits into
Conversation
The Review track read "no sign-off pending" whenever a sign-off ask was answered by anything other than a GitHub Approve review, which looked like a missing DCO Signed-off-by. human_gate now carries answered_via (review, dashboard, policy) and credits the dashboard approver, and the track reads "signed off", "approved by <login>", "answered by policy" or "decision answered". Fixes #19263 Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
UI render evidenceRender evidence captured. Built from
These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review follow-ups: 1 open of 1 (below
|
Summary
Once a reviewer's sign-off ask on a PR was answered, the tracker's Review track read
signed offfor a GitHub Approve review andno sign-off pendingfor everything else. The second phrase reads like a DCO failure. A dashboard approval or the owner-delegate policy answers the ask without ever settinghuman_approver(only the:human-approved@loginstage reason suffix does), so those rows always got the misleading wording.Changes
stage_tracker_gate.go:human_gategainsanswered_via(review,dashboard,policy).stageTrackerHumanGateAnswererkeeps the GitHub approver first; otherwise it reads the row's newest applied operator action on the current head:approve/queue-merge/merge-nowcredit their actor (the dashboard/approvelogin), an approvinglet-hive-decideis the owner-delegate policy (no person credited). Approvals on an older head or failed actions credit nobody.tracker-row-strip.js: new purestageTrackerGateAnsweredWord:signed offonly for a real approval,approved by <login>,answered by policy, elsedecision answered.static/index.htmlregenerated by concatenatingstatic-srcpermanifest.txt(byte-exact, asmake dashboard-gendoes).TestStageTrackerHumanGateAnsweredVia(Go) covers review, dashboard approve / queue-merge, policy, non-approving policy, stale head, failed action, nothing recorded; the sharedgate_states.jsontable now pinsanswered_via;stage_tracker_activity.test.jspins every wording and asserts no sign-off is claimed without an Approve review.api-reference/dashboard-misc.mdanddashboard-sections/activity-monitor.md; changelog fragment.Fixes #19263