Skip to content

πŸ› Name how a sign-off ask was answered on the tracker Review track - #19265

Open
clubanderson wants to merge 5 commits into
v5from
fix-tracker-signoff-wording
Open

clubanderson wants to merge 5 commits into
v5from
fix-tracker-signoff-wording

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

Once a reviewer's sign-off ask on a PR was answered, the tracker's Review track read signed off for a GitHub Approve review and no sign-off pending for everything else. The second phrase reads like a DCO failure. A dashboard approval or the owner-delegate policy answers the ask without ever setting human_approver (only the :human-approved@login stage reason suffix does), so those rows always got the misleading wording.

Changes

  • stage_tracker_gate.go: human_gate gains answered_via (review, dashboard, policy). stageTrackerHumanGateAnswerer keeps the GitHub approver first; otherwise it reads the row's newest applied operator action on the current head: approve / queue-merge / merge-now credit their actor (the dashboard /approve login), an approving let-hive-decide is the owner-delegate policy (no person credited). Approvals on an older head or failed actions credit nobody.
  • tracker-row-strip.js: new pure stageTrackerGateAnsweredWord: signed off only for a real approval, approved by <login>, answered by policy, else decision answered.
  • static/index.html regenerated by concatenating static-src per manifest.txt (byte-exact, as make dashboard-gen does).
  • Tests: TestStageTrackerHumanGateAnsweredVia (Go) covers review, dashboard approve / queue-merge, policy, non-approving policy, stale head, failed action, nothing recorded; the shared gate_states.json table now pins answered_via; stage_tracker_activity.test.js pins every wording and asserts no sign-off is claimed without an Approve review.
  • Docs: api-reference/dashboard-misc.md and dashboard-sections/activity-monitor.md; changelog fragment.

Fixes #19263

The Review track read "no sign-off pending" whenever a sign-off ask was
answered by anything other than a GitHub Approve review, which looked
like a missing DCO Signed-off-by. human_gate now carries answered_via
(review, dashboard, policy) and credits the dashboard approver, and the
track reads "signed off", "approved by <login>", "answered by policy"
or "decision answered".

Fixes #19263

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 19, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19204 ✨ ask: hive backend and hub relay for optional Ask AI help same files src/docs/api-reference/dashboard-misc.md
src/pkg/dashboard/static/index.html
#19290 πŸ› Keep human-only follow-ups out of the owner-delegate's default approve same files src/docs/dashboard-sections/activity-monitor.md
#19206 ✨ ask: hive panel and rollout verification for optional Ask AI help same files src/docs/api-reference/dashboard-misc.md
src/pkg/dashboard/static/index.html
#19281 ✨ gauge: show Claude usage credits (on/off, spent of monthly cap) same files src/pkg/dashboard/static/index.html

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

UI render evidence

Render evidence captured.

Built from 8657ab2fa588.
Screenshots: download the artifact (sign-in to GitHub required).
Run: https://github.com/hivecommons/hive/actions/runs/44576548568

Page Section Viewport Theme File Size
hive overview desktop light hive-overview-desktop-light.png 313 KB
hive overview desktop dark hive-overview-desktop-dark.png 307 KB
hive overview phone light hive-overview-phone-light.png 467 KB
hive overview phone dark hive-overview-phone-dark.png 464 KB
hub-fleet overview desktop light hub-fleet-overview-desktop-light.png 113 KB
hub-fleet overview desktop dark hub-fleet-overview-desktop-dark.png 115 KB
hub-fleet overview phone light hub-fleet-overview-phone-light.png 265 KB
hub-fleet overview phone dark hub-fleet-overview-phone-dark.png 270 KB
hub-dashboard overview desktop light hub-dashboard-overview-desktop-light.png 338 KB
hub-dashboard overview desktop dark hub-dashboard-overview-desktop-dark.png 344 KB
hub-dashboard overview phone light hub-dashboard-overview-phone-light.png 624 KB
hub-dashboard overview phone dark hub-dashboard-overview-phone-dark.png 656 KB

These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from src/scripts/fixtures/render-evidence/. They show layout and theming, not how real hives behave. How to read them: src/docs/ui-render-evidence.md.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Review follow-ups: 1 open of 1 (below review.backlog.min_severity: P2)

Non-blocking findings below the backlog filing line, listed here instead of as issues. Tick them off as they are fixed; set review.backlog.min_severity: P3 to file every finding.

  • P3 info correctness β€” Head match uses exact compare and treats empty ledger HeadSHA as current (src/pkg/dashboard/stage_tracker_gate.go:295): stageTrackerHumanGateAnswerer credits a queue-merge or merge-now action whose HeadSHA is empty without checking the head, so an old-head approval with no recorded head could still be credited. This m…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Tracker Review track says "no sign-off pending" after a dashboard or policy approval

1 participant