Skip to content

πŸ› Line up every dashboard sidebar group with the Dashboard indent - #19283

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/sidebar-child-indent
Nov 19, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/sidebar-child-indent

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #19282

What

Dashboard sidebar entries under Collaborate, Resources, Intelligence, Admin, Help and Filters now line up with the Dashboard group's entries.

Root cause

dashboardEnsureSidebarHandles() (layout.js) prepends a reorder grip (.oc-nav-drag-handle) only to links that live in #dashboard-section-nav-group. The grip is opacity: 0 until hover but still takes 1.25rem plus the row gap, which is what indented the Dashboard entries. Links in the other groups stay in their own group and never get a grip, so they had no leading space.

Fix (one shared rule, no per-group values)

  • sidebar.css: new tokens --oc-nav-grip-w, --oc-nav-item-gap, --oc-nav-item-pad-x, --oc-nav-child-inset (grip width plus gap).
  • .oc-nav-item reserves --oc-nav-child-inset in its left padding for every entry.
  • .oc-nav-item > .oc-nav-drag-handle:first-child pulls the grip back by the same inset, so it draws inside the gutter. Dashboard and agent rows keep the exact position they had; every other group moves in to match.
  • Grip and hide-toggle size now come from --oc-nav-grip-w, so the gutter tracks the grip.
  • No color changes, so light and dark themes are unaffected; the mobile drawer uses the same rules (grips are always visible on coarse pointers and still sit in the gutter). The hub dashboard does not share this sidebar code.
  • static/index.html regenerated by concatenating static-src per manifest.txt.
  • New sidebar_nav_indent_19282_test.go pins the shared gutter, the grip offset and the absence of per-group padding.
  • Changelog fragment changelog.d/fixed-19282-sidebar-group-indent.md.

Only Dashboard entries carried a reorder grip, and that hidden grip was
the only thing indenting them, so Collaborate, Resources, Intelligence,
Admin, Help and Filters entries sat flush left. Every .oc-nav-item now
reserves one grip-wide gutter from shared tokens, and a leading grip
draws inside it, so all groups line up and grip rows keep their place.

Fixes #19282

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 19, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19265 πŸ› Name how a sign-off ask was answered on the tracker Review track same files src/pkg/dashboard/static/index.html
#19281 ✨ gauge: show Claude usage credits (on/off, spent of monthly cap) same files src/pkg/dashboard/static/index.html
#19206 ✨ ask: hive panel and rollout verification for optional Ask AI help same files src/pkg/dashboard/static/index.html
#19204 ✨ ask: hive backend and hub relay for optional Ask AI help same files src/pkg/dashboard/static/index.html

@github-actions

Copy link
Copy Markdown
Contributor

UI render evidence

Render evidence captured.

Built from 888db4b40668.
Screenshots: download the artifact (sign-in to GitHub required).
Run: https://github.com/hivecommons/hive/actions/runs/44573743671

Page Section Viewport Theme File Size
hive overview desktop light hive-overview-desktop-light.png 326 KB
hive overview desktop dark hive-overview-desktop-dark.png 307 KB
hive overview phone light hive-overview-phone-light.png 467 KB
hive overview phone dark hive-overview-phone-dark.png 464 KB
hub-fleet overview desktop light hub-fleet-overview-desktop-light.png 113 KB
hub-fleet overview desktop dark hub-fleet-overview-desktop-dark.png 115 KB
hub-fleet overview phone light hub-fleet-overview-phone-light.png 265 KB
hub-fleet overview phone dark hub-fleet-overview-phone-dark.png 270 KB
hub-dashboard overview desktop light hub-dashboard-overview-desktop-light.png 338 KB
hub-dashboard overview desktop dark hub-dashboard-overview-desktop-dark.png 344 KB
hub-dashboard overview phone light hub-dashboard-overview-phone-light.png 624 KB
hub-dashboard overview phone dark hub-dashboard-overview-phone-dark.png 656 KB

These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from src/scripts/fixtures/render-evidence/. They show layout and theming, not how real hives behave. How to read them: src/docs/ui-render-evidence.md.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#19283888db4b` sha256:65cea77e947844b0acfb31536937b3e10e04d3d40e6c5ef4a52c061b706d1007 β€” download from the dashboard or `hivectl review evidence #19283`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard sidebar: only Dashboard entries are indented, other groups sit flush left

1 participant