Repository navigation
π Line up every dashboard sidebar group with the Dashboard indent - #19283
Conversation
Only Dashboard entries carried a reorder grip, and that hidden grip was the only thing indenting them, so Collaborate, Resources, Intelligence, Admin, Help and Filters entries sat flush left. Every .oc-nav-item now reserves one grip-wide gutter from shared tokens, and a leading grip draws inside it, so all groups line up and grip rows keep their place. Fixes #19282 Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
UI render evidenceRender evidence captured. Built from
These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from |
Fixes #19282
What
Dashboard sidebar entries under Collaborate, Resources, Intelligence, Admin, Help and Filters now line up with the Dashboard group's entries.
Root cause
dashboardEnsureSidebarHandles()(layout.js) prepends a reorder grip (.oc-nav-drag-handle) only to links that live in#dashboard-section-nav-group. The grip isopacity: 0until hover but still takes1.25remplus the row gap, which is what indented the Dashboard entries. Links in the other groups stay in their own group and never get a grip, so they had no leading space.Fix (one shared rule, no per-group values)
sidebar.css: new tokens--oc-nav-grip-w,--oc-nav-item-gap,--oc-nav-item-pad-x,--oc-nav-child-inset(grip width plus gap)..oc-nav-itemreserves--oc-nav-child-insetin its left padding for every entry..oc-nav-item > .oc-nav-drag-handle:first-childpulls the grip back by the same inset, so it draws inside the gutter. Dashboard and agent rows keep the exact position they had; every other group moves in to match.--oc-nav-grip-w, so the gutter tracks the grip.static/index.htmlregenerated by concatenatingstatic-srcpermanifest.txt.sidebar_nav_indent_19282_test.gopins the shared gutter, the grip offset and the absence of per-group padding.changelog.d/fixed-19282-sidebar-group-indent.md.