You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
🐛 Tracker Review track says "no sign-off pending" after a dashboard or policy approval #19263
On a PR whose reviewer verdict asked for a person's sign-off, the activity tracker's Review track switches once that ask is answered. When the answer came from a GitHub Approve review it reads Review 5/5 · signed off. In every other case it reads Review 5/5 · no sign-off pending.
"no sign-off pending" reads like a DCO failure (a missing Signed-off-by), while the PR is actually fine: someone answered the decision.
Why
human_approver (and so the "signed off" branch in src/pkg/dashboard/static-src/js/tracker-row-strip.js, case 'human_decision') is only filled from the :human-approved@login stage reason suffix, which a GitHub Approve review sets. Two other ways of answering leave it empty:
the dashboard Approve action (comment marker hive:pr-approval ... by=<login>, recorded in the operator-action ledger as approve / queue-merge / merge-now)
the owner-delegate policy (hive:delegated-decision policy=owner-delegate, recorded as an approving let-hive-decide)
Fix
Server: human_gate gains answered_via (review, dashboard, policy). answered_by credits the dashboard approver's login from the row's newest applied operator action on the current head; the policy case credits no person.
SPA: the Review track reads signed off only for a real GitHub approval, approved by <login> for a dashboard approval, answered by policy for the owner-delegate policy, and decision answered otherwise. "no sign-off pending" is gone.
Go and JS tests for each case; API reference and activity monitor docs updated.
Activity
clubanderson commentedon Nov 19, 2026
Claiming: working on this now, PR to follow.
clubanderson commentedon Nov 19, 2026
PR: #19265