Skip to content

πŸ› dashboard: band donuts include Outside so they add up to the BP totals - #19273

Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
Danathar:fix/band-donuts-outside
Nov 19, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
Danathar:fix/band-donuts-outside

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

The Overview's "Issues by band" and "PRs by band" donuts now add up to the Total open issues and Total open PRs tiles (the BP pair). A grey Outside slice holds the open items that are in no band. Andy asked for this on 11-19 ("make it whole"). This targets v5, to be forward-ported to v6.

What was wrong

The donuts draw only tracked items (actionable + held), while the tiles count every open item. On knuckle (projectbluefin hive) on 11-19:

Where Issues PRs
Tiles / BP 134 95
Donuts before 100 93
Outside tile 34 2
Donuts after 134 95

The 34 issues were 22 dependency dashboards, 11 left out by the project issue filter and 1 standing advisory. The 2 PRs were drafts. Nothing on the chart said they were left out.

What changed

  • Outside slice. Its count is the tile total minus what the bands draw, taken from the same forge totals the tiles use for the current repo selection (all repos, or the ones picked). So each donut equals its tile, and nothing already in a band is counted again.
  • Hover and legend. The slice's rule lists the same breakdown as the tile (for example 11 filtered Β· 1 hive advisory Β· 22 dependency dashboard; PRs: 2 draft). The legend gets an Outside row with count and %. It has no per-band export. Clicking it opens the same Projects filter as the Outside tile.
  • Only when needed. The slice is left out when its count is 0.
  • Colour. It uses var(--muted), the same neutral grey as the Outside tile, in both themes.
  • History and animation. Chart history samples and the animation signature use the chart slices, so they track Outside too. The KPI tiles still get the band-only slices, so their arithmetic is unchanged.
  • Subtitles. "Actionable and held issues" / "Open and held pull requests" became "Open issues" / "Open pull requests", since the charts now cover every open item.

The Outside slice can be larger than the Outside tile: needs-human and waiting-on-reporter issues that sit in no band are in the slice, while the tiles count them under Blocked / needs-human. The docs say so.

Tests

  • TestOverviewBandChartsAddUpToKPITotals (node): for all repos, a single repo, and a repo with nothing outside, the donut totals equal the Total open tiles rendered by renderOverviewKPIs. Tile arithmetic still holds (actionable + held + blocked + outside = totals). Band slices are untouched, the breakdown text is right, there's no slice at 0, and history and the animation signature carry the Outside count.
  • TestOverviewBandChartsDrawOutsideSliceStatic: the wiring and the CSS mapping.
  • static/index.html regenerated from static-src.

Docs: dashboard-sections/overview-and-metrics.md. Changelog: changelog.d/fixed-overview-band-charts-outside.md.

πŸ€– Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

The Overview band charts drew only tracked items (actionable + held) while
the Total open tiles count every open item, so the charts came up short
with nothing saying why (knuckle 11-19: tiles 134/95, charts 100/93).

The charts now get a grey Outside slice: the tile total minus what the
bands draw, read from the same forge totals as the tiles for the current
repo selection, so nothing is counted twice and each chart adds up to its
tile. Its hover carries the tile's outside breakdown; it is left out at 0,
clicks through to the Outside Projects filter and has no per-band export.
The KPI tiles keep the band slices; history samples and the animation
signature use the chart slices.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 19, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

UI render evidence

Render evidence captured.

Built from 03c0dacbe7b3.
Screenshots: download the artifact (sign-in to GitHub required).
Run: https://github.com/hivecommons/hive/actions/runs/44571296899

Page Section Viewport Theme File Size
hive overview desktop light hive-overview-desktop-light.png 351 KB
hive overview-section desktop light hive-overview-section-desktop-light.png 295 KB
hive overview desktop dark hive-overview-desktop-dark.png 326 KB
hive overview-section desktop dark hive-overview-section-desktop-dark.png 272 KB
hive overview phone light hive-overview-phone-light.png 506 KB
hive overview-section phone light hive-overview-section-phone-light.png 357 KB
hive overview phone dark hive-overview-phone-dark.png 503 KB
hive overview-section phone dark hive-overview-section-phone-dark.png 353 KB

These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from src/scripts/fixtures/render-evidence/. They show layout and theming, not how real hives behave. How to read them: src/docs/ui-render-evidence.md.

@hivecommons-hive

hivecommons-hive Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • test (dashboard 1/4)
  • test (dashboard 2/4)
  • test (dashboard 3/4)
  • test (dashboard 4/4)
  • test (dashboard shuffle 1/3)
  • test (dashboard shuffle 2/3)
  • test (dashboard shuffle 3/3)
  • build-go

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19204 ✨ ask: hive backend and hub relay for optional Ask AI help same files src/pkg/dashboard/static/index.html
#19206 ✨ ask: hive panel and rollout verification for optional Ask AI help same files src/pkg/dashboard/static/index.html
#19281 ✨ gauge: show Claude usage credits (on/off, spent of monthly cap) same files src/pkg/dashboard/static-src/css/overview.css
src/pkg/dashboard/static/index.html
#19265 πŸ› Name how a sign-off ask was answered on the tracker Review track same files src/pkg/dashboard/static/index.html
#19283 πŸ› Line up every dashboard sidebar group with the Dashboard indent same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#1927303c0dac` sha256:63e1f5c219886d60b0f4228102fe403a0fb5792e8be030db1407a03fa2c0c7b2 β€” download from the dashboard or `hivectl review evidence #19273`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant