Repository navigation
π dashboard: band donuts include Outside so they add up to the BP totals - #19273
Conversation
The Overview band charts drew only tracked items (actionable + held) while the Total open tiles count every open item, so the charts came up short with nothing saying why (knuckle 11-19: tiles 134/95, charts 100/93). The charts now get a grey Outside slice: the tile total minus what the bands draw, read from the same forge totals as the tiles for the current repo selection, so nothing is counted twice and each chart adds up to its tile. Its hover carries the tile's outside breakdown; it is left out at 0, clicks through to the Outside Projects filter and has no per-band export. The KPI tiles keep the band slices; history samples and the animation signature use the chart slices. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
UI render evidenceRender evidence captured. Built from
These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from |
|
@Danathar this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
The Overview's "Issues by band" and "PRs by band" donuts now add up to the Total open issues and Total open PRs tiles (the BP pair). A grey Outside slice holds the open items that are in no band. Andy asked for this on 11-19 ("make it whole"). This targets v5, to be forward-ported to v6.
What was wrong
The donuts draw only tracked items (actionable + held), while the tiles count every open item. On knuckle (projectbluefin hive) on 11-19:
The 34 issues were 22 dependency dashboards, 11 left out by the project issue filter and 1 standing advisory. The 2 PRs were drafts. Nothing on the chart said they were left out.
What changed
11 filtered Β· 1 hive advisory Β· 22 dependency dashboard; PRs:2 draft). The legend gets an Outside row with count and %. It has no per-band export. Clicking it opens the same Projects filter as the Outside tile.var(--muted), the same neutral grey as the Outside tile, in both themes.The Outside slice can be larger than the Outside tile: needs-human and waiting-on-reporter issues that sit in no band are in the slice, while the tiles count them under Blocked / needs-human. The docs say so.
Tests
TestOverviewBandChartsAddUpToKPITotals(node): for all repos, a single repo, and a repo with nothing outside, the donut totals equal the Total open tiles rendered byrenderOverviewKPIs. Tile arithmetic still holds (actionable + held + blocked + outside = totals). Band slices are untouched, the breakdown text is right, there's no slice at 0, and history and the animation signature carry the Outside count.TestOverviewBandChartsDrawOutsideSliceStatic: the wiring and the CSS mapping.static/index.htmlregenerated fromstatic-src.Docs:
dashboard-sections/overview-and-metrics.md. Changelog:changelog.d/fixed-overview-band-charts-outside.md.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1