Skip to content

✨ Settings UI for per-repo parent auto-close policy - #19073

Merged
kubestellar-prow[bot] merged 7 commits into
v5from
feat/parent-autoclose-settings-ui
Nov 18, 2026
Merged

kubestellar-prow[bot] merged 7 commits into
v5from
feat/parent-autoclose-settings-ui

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #19070

Owners can now set the per-repo parent/epic auto-close policy from Settings instead of editing YAML.

  • Settings, Repos tab, new "Parent auto-close" card (owner only). One row per monitored repo with a select: "Close finished parents (default)", "Also close epics and holds", "Never auto-close parents", each with a one-line explanation, plus the current effective value and whether it is inherited. The card notes that parents a person reopened are never re-closed and that issues marked as tracking issues are never auto-closed.
  • New owner-only GET/PUT /api/config/repos/parent-autoclose: validates the value and that the repo is monitored, applies live (the stage pass reads ParentAutoCloseFor, so no restart), audits config_repo_parent_autoclose, rolls back if the file cannot be written. Choosing the default clears the override so the file only holds non-default values.
  • config.SetParentAutoClose and a lock around the repos: map (it is now written while other goroutines read it).
  • Removed the repos.<key>.parent_autoclose parity allowlist TODO; docs (settings, stage-labels, operator reference, API reference), OpenAPI, changelog fragment, make dashboard-gen output, Go and JS tests.

No live hive config was changed. Closing trackers with no sub-issue children is a separate design: #19071.

🤖 Generated with Claude Code

Add a Parent auto-close card to the Settings Repos tab: per monitored repo,
choose Close finished parents (default), Also close epics and holds, or Never
auto-close parents. Owner-only GET/PUT /api/config/repos/parent-autoclose,
validated, applied without a restart, audited as config_repo_parent_autoclose.
Removes the settings parity allowlist TODO and documents where the setting
lives.

Fixes #19070

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18873 🐛 needs-sha: exempt owner/detailed issues, overrideable waiver, visible hold on the row CONFLICT dashboard/openapi.json
src/docs/api-reference/auth.md (conflict)
src/docs/api-reference/configuration.md (conflict)
src/docs/operator-reference/README.md
src/pkg/dashboard/api.go
src/pkg/dashboard/static/index.html
#19063 ✨ PR gate: fail visibly when the Commit statuses grant is missing CONFLICT src/docs/api-reference/auth.md (conflict)
src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UI render evidence

Render evidence captured.

Built from 323ec7f0dd7e.
Screenshots: download the artifact (sign-in to GitHub required).
Run: https://github.com/hivecommons/hive/actions/runs/44376559961

Page Section Viewport Theme File Size
hive overview desktop light hive-overview-desktop-light.png 308 KB
hive overview desktop dark hive-overview-desktop-dark.png 306 KB
hive overview phone light hive-overview-phone-light.png 467 KB
hive overview phone dark hive-overview-phone-dark.png 464 KB
hub-fleet overview desktop light hub-fleet-overview-desktop-light.png 113 KB
hub-fleet overview desktop dark hub-fleet-overview-desktop-dark.png 115 KB
hub-fleet overview phone light hub-fleet-overview-phone-light.png 265 KB
hub-fleet overview phone dark hub-fleet-overview-phone-dark.png 270 KB
hub-dashboard overview desktop light hub-dashboard-overview-desktop-light.png 338 KB
hub-dashboard overview desktop dark hub-dashboard-overview-desktop-dark.png 344 KB
hub-dashboard overview phone light hub-dashboard-overview-phone-light.png 624 KB
hub-dashboard overview phone dark hub-dashboard-overview-phone-dark.png 656 KB

These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from src/scripts/fixtures/render-evidence/. They show layout and theming, not how real hives behave. How to read them: src/docs/ui-render-evidence.md.

@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the branch conflicts with the base and needs a rebase

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

1 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/pkg/dashboard/api_config_parent_autoclose.go 141 CONDITIONALS_NEGATION

Verdict: uncovered (#17349).

@kubestellar-prow kubestellar-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@clubanderson clubanderson added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2026
@kubestellar-prow kubestellar-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
Resolve the settings parity allowlist conflict: keep the new #19074
entries, keep the parent_autoclose entry removed.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson clubanderson added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2026
@kubestellar-prow kubestellar-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@github-actions github-actions Bot added conflicts-with-open-pr Open PR has a merge conflict with another open PR and removed conflicts-with-open-pr Open PR has a merge conflict with another open PR labels Nov 18, 2026
Resolve the settings parity allowlist conflict (keep the new #19069
entries) and use reflect IsZero in SetParentAutoClose: RepoSettings now
carries review_preflight, which holds slices and is not comparable.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson clubanderson added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
@kubestellar-prow
kubestellar-prow Bot merged commit 48b4477 into v5 Nov 18, 2026
97 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/parent-autoclose-settings-ui branch November 18, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚙️ Settings UI for per-repo parent/epic auto-close policy (parent_autoclose)

1 participant