Skip to content

✨ Customers: country flag, likely affiliation suggestion, notes rules (spoke-local) - #19087

Merged
kubestellar-prow[bot] merged 2 commits into
v5from
feat/customers-country-affiliation
Nov 18, 2026
Merged

kubestellar-prow[bot] merged 2 commits into
v5from
feat/customers-country-affiliation

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #19085

Adds the spoke-local part of the operator's ask to the Customers profile. Nothing is read from the hub and no request is added.

  • Country: derived offline from the location text by a bundled table (names, aliases, ISO codes, US states, Canadian provinces, major cities, flag emoji in the text). Stored as profile.country (ISO alpha-2) with auto or manual provenance; a hand-set or hand-cleared country is never changed; "Auto" hands it back and re-derives. Row: compact flag plus the ISO code as text, accessible name in aria-label. Details: flag, code and name.
  • Likely affiliation: view-time suggestion, never stored. Rules: tidied GitHub company text, or (organization still empty) the domain of an email identity confirmed by hand, never free-mail or code-host domains. Shows evidence; Accept writes a by-hand organization; Dismiss is remembered (bounded). Public org membership is not used because it is not fetched today.
  • Notes: already existed (4000 bytes, owner and read-write only, hidden from read-only users, in export, deleted on Forget). Rules documented and pinned by tests.
  • Docs, openapi, API reference, design doc, changelog fragment, Go and node-harness tests; index.html regenerated.

🤖 Generated with Claude Code

… documented and tested (#19085)

Fixes #19085

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18873 🐛 needs-sha: exempt owner/detailed issues, overrideable waiver, visible hold on the row same files dashboard/openapi.json
src/pkg/dashboard/static/index.html
#19073 ✨ Settings UI for per-repo parent auto-close policy same files dashboard/openapi.json
src/pkg/dashboard/static/index.html
#19063 ✨ PR gate: fail visibly when the Commit statuses grant is missing same files src/pkg/dashboard/static/index.html
#19065 ✨ feature: show recent kick outcomes in agent details same files src/pkg/dashboard/static/index.html

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UI render evidence

Render evidence captured.

Built from bc86c75ee46c.
Screenshots: download the artifact (sign-in to GitHub required).
Run: https://github.com/hivecommons/hive/actions/runs/44372398744

Page Section Viewport Theme File Size
hive overview desktop light hive-overview-desktop-light.png 326 KB
hive overview desktop dark hive-overview-desktop-dark.png 306 KB
hive overview phone light hive-overview-phone-light.png 467 KB
hive overview phone dark hive-overview-phone-dark.png 464 KB
hub-fleet overview desktop light hub-fleet-overview-desktop-light.png 113 KB
hub-fleet overview desktop dark hub-fleet-overview-desktop-dark.png 115 KB
hub-fleet overview phone light hub-fleet-overview-phone-light.png 265 KB
hub-fleet overview phone dark hub-fleet-overview-phone-dark.png 270 KB
hub-dashboard overview desktop light hub-dashboard-overview-desktop-light.png 338 KB
hub-dashboard overview desktop dark hub-dashboard-overview-desktop-dark.png 344 KB
hub-dashboard overview phone light hub-dashboard-overview-phone-light.png 624 KB
hub-dashboard overview phone dark hub-dashboard-overview-phone-dark.png 656 KB

These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from src/scripts/fixtures/render-evidence/. They show layout and theming, not how real hives behave. How to read them: src/docs/ui-render-evidence.md.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (dashboard 2/4)
  • test (dashboard shuffle 1/3)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

gremlins found 9 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.

File Line Mutation
src/pkg/customers/affiliation.go 132 CONDITIONALS_BOUNDARY
src/pkg/customers/country.go 137 CONDITIONALS_BOUNDARY
src/pkg/customers/country.go 137 CONDITIONALS_BOUNDARY
src/pkg/customers/country.go 137 CONDITIONALS_BOUNDARY
src/pkg/customers/country.go 137 CONDITIONALS_BOUNDARY
src/pkg/customers/country.go 153 CONDITIONALS_BOUNDARY
src/pkg/customers/country.go 166 CONDITIONALS_BOUNDARY
src/pkg/customers/country.go 198 CONDITIONALS_BOUNDARY
src/pkg/customers/store.go 607 CONDITIONALS_BOUNDARY

2 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/pkg/customers/country.go 199 ARITHMETIC_BASE
src/pkg/customers/country.go 199 INVERT_NEGATIVES

ℹ️ 1 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first lines added lines of each default-context hunk, so non-contiguous edits in one hunk are partly missed. This does not affect the verdict.

File Line Mutation
src/pkg/customers/store.go 548 CONDITIONALS_NEGATION

Verdict: lived (#17349).

@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit b8f2806 into v5 Nov 18, 2026
99 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/customers-country-affiliation branch November 18, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Customers: country flag, likely affiliation suggestion and notes rules on a profile (spoke-local)

1 participant