Skip to content

🐛 contribute: never hand umbrella or owner-only issues to a contributor relay - #19081

Merged
kubestellar-prow[bot] merged 3 commits into
v5from
feat/contrib-umbrella-exclusion
Nov 18, 2026
Merged

kubestellar-prow[bot] merged 3 commits into
v5from
feat/contrib-umbrella-exclusion

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Fixes #19078

What changes

Umbrella, epic, tracker and decomposed-parent issues, and issues that wait on a person, are never handed to a contributor relay, never counted as workable, and never advertised with help wanted / good first issue. They stay actionable for the owner and the hive, keep their stage, and stay closable.

Recognition (one classifier, pkg/gfi/umbrella.go; config hub.contribute_umbrella with a per_repo override map, every field optional and inheriting):

  • Umbrella: a label from labels (default umbrella, tracker, epic, meta-tracker; case-insensitive, last segment so kind/epic), the <!-- hive:umbrella --> body marker (ignored inside code spans), a title prefix (default [Tracking], [Epic], [Umbrella], [Tracker]), a task list with at least task_list_min (default 2) issue or PR references, sub-issues, or the legacy is_tracker detector.
  • Owner-only: needs-human, human-only, human-only:* (human_only_labels), or <!-- hive:human-only -->. needs-human keeps its existing hard-suppress name in the good-first-issue picker.
  • "Refs"-only linkage from several PRs is left to a follow-up: hive/partially-addressed is not a reliable umbrella signal.

Where it applies

  • /contribute selection and the ready-work queue (shared ladder, withheld reasons umbrella and human_only).
  • /api/contribute/status: new umbrella_items, human_only_items, candidate_items_raw (the old raw count, kept for compatibility); actionable_items and candidate_items count only workable work. Also umbrella_total / human_only_total on /api/contribute/queue and umbrella_count / human_only_count on the fleet payload. No in-repo consumer reads candidate_items; actionable_items (relay neediest strategy, federation heartbeat) now means workable, which is what they want.
  • Contributor page: "N workable" and "M umbrella and owner-only items are not offered to contributors".
  • Good-first-issue sweep: an umbrella or owner-only issue is never advertised and loses help wanted and good first issue on the next sweep (logged, audited as gfi-withdraw, withdraw_advertisement: false per hive or per repo opts out). It runs before the claim gates, so a hive-claimed umbrella loses the invitation too. There is no "recently labelled by a person" guard in the existing withdrawal code, so none was added.
  • Dashboard tracker row: derived pills "Umbrella · owner" and "Owner only" (umbrella / owner_only on the stage tracker item).

Stage decision. No stage/0NN-umbrella label: a stage lives in the engine table, transition table, dashboard columns and filter vocabulary and every stage-aware test harness (the 018 change touched 53 files and cannot be validated without a local build), and umbrella is orthogonal to pipeline progress (a parent is 010 while waiting on children and 040 while a PR covers it). It is a derived pill over the shared rules instead, documented in stage-labels.md. Follow-up: a dashboard filter chip for the pill.

Auto-close untouched. The markers are not hive/tracking: CloseIssue does not refuse them and parent_autoclose does not exempt them (an epic label keeps its existing epics_too rule). umbrella_close_test.go pins an umbrella closable and a hive/tracking issue refused. Checked #19073 (Settings control for parent_autoclose): shared files only by adjacent edits (openapi.json, settings_parity_allowlist.txt, stage-labels.md, regenerated static/index.html; regenerate after either merges); per-repo overrides live under hub.contribute_umbrella.per_repo, not repos:.

Relay. #19053 is open and untouched. Follow-up for the relay: name umbrella_items / human_only_items in its empty-queue message.

Dry run: open issues the new rules would classify (nothing was labelled or edited)

Issue Rule Advertisement withdrawn Stage kept
#17054 umbrella: label Epic help wanted 018
#18596 umbrella: sub-issues (3) help wanted 010
#18916 umbrella: sub-issues (2) help wanted 010
#18986 umbrella: sub-issues (4) none worn 040
#19046 umbrella: sub-issues (3) none worn none

No open issue currently matches owner-only: none carries needs-human (those are filtered already), human-only or the marker. #18660, #18661, #18524, #18746 and the prose-only trackers #9846 and #2364 match no rule today; label them human-only / umbrella (or add the marker) to take them off the relay, which the operator can decide after reviewing this list.

Tests

Table-driven: each recognition rule, per-repo override and disable, counts and compatibility fields, shared selectTask/queue/withheld ladder cases, picker exclusion and withdrawal (including help wanted alone and withdraw_advertisement: false), dashboard text and pill, close-path eligibility. Two existing gfi tests that pinned hand-labelled epics as left alone were updated to the new decision. make dashboard-gen was run for the pill. Not run locally (CI is the gate).

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 18, 2026
…or relay

A shared classifier (hub.contribute_umbrella, per-repo overrides) marks an
umbrella by label, body marker, title prefix, issue-referencing task list or
sub-issues, and an owner-only issue by label or marker. Contributor
selection and the ready-work queue refuse them, /api/contribute/status gains
umbrella_items, human_only_items and candidate_items_raw while
actionable_items and candidate_items count only workable work, the
contributor page shows N workable plus an excluded line, and the
good-first-issue sweep withdraws help wanted and good first issue from an
umbrella. They stay actionable for the owner and stay closable, unlike
hive/tracking.

Fixes #19078

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the feat/contrib-umbrella-exclusion branch from 925a444 to 7e419ae Compare November 18, 2026 18:09
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19063 ✨ PR gate: fail visibly when the Commit statuses grant is missing same files src/pkg/dashboard/static/index.html
#19087 ✨ Customers: country flag, likely affiliation suggestion, notes rules (spoke-local) same files dashboard/openapi.json
src/pkg/dashboard/static/index.html
#19075 ✨ Reviewer preflight: repo rules, dependency advisories and release age, subtle-defect guidance same files src/hive.yaml.example
src/pkg/config/config.go
src/pkg/config/testdata/agent_runtime_golden.json
src/pkg/dashboard/settings_parity_allowlist.txt
#19073 ✨ Settings UI for per-repo parent auto-close policy same files dashboard/openapi.json
src/docs/labels-and-control-signals/stage-labels.md
src/pkg/dashboard/settings_parity_allowlist.txt
src/pkg/dashboard/static/index.html
#19065 ✨ feature: show recent kick outcomes in agent details same files src/pkg/dashboard/static/index.html
#19086 ✨ Capture reviewer-stated rules from review feedback into the hive's knowledge same files src/docs/labels-and-control-signals/reference.md
#18873 🐛 needs-sha: exempt owner/detailed issues, overrideable waiver, visible hold on the row same files dashboard/openapi.json
src/docs/labels-and-control-signals/reference.md
src/hive.yaml.example
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_build.go
src/pkg/dashboard/static/index.html

@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

@clubanderson this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • test (dashboard 4/4)
  • test (dashboard shuffle 1/3)
  • test (dashboard shuffle 2/3)
  • test (rest 2/4)
  • coverage

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UI render evidence

Render evidence captured.

Built from 662963991030.
Screenshots: download the artifact (sign-in to GitHub required).
Run: https://github.com/hivecommons/hive/actions/runs/44370284655

Page Section Viewport Theme File Size
hive overview desktop light hive-overview-desktop-light.png 326 KB
hive overview desktop dark hive-overview-desktop-dark.png 307 KB
hive overview phone light hive-overview-phone-light.png 467 KB
hive overview phone dark hive-overview-phone-dark.png 464 KB
hub-fleet overview desktop light hub-fleet-overview-desktop-light.png 113 KB
hub-fleet overview desktop dark hub-fleet-overview-desktop-dark.png 115 KB
hub-fleet overview phone light hub-fleet-overview-phone-light.png 265 KB
hub-fleet overview phone dark hub-fleet-overview-phone-dark.png 270 KB
hub-dashboard overview desktop light hub-dashboard-overview-desktop-light.png 338 KB
hub-dashboard overview desktop dark hub-dashboard-overview-desktop-dark.png 344 KB
hub-dashboard overview phone light hub-dashboard-overview-phone-light.png 624 KB
hub-dashboard overview phone dark hub-dashboard-overview-phone-dark.png 656 KB

These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from src/scripts/fixtures/render-evidence/. They show layout and theming, not how real hives behave. How to read them: src/docs/ui-render-evidence.md.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…-rules count test

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 483efdd into v5 Nov 18, 2026
101 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/contrib-umbrella-exclusion branch November 18, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🧹 contribute: never hand umbrella or owner-only issues to a contributor relay (and count them separately)

1 participant