Skip to content

✨ feature: show recent kick outcomes in agent details - #19065

Merged
kubestellar-prow[bot] merged 2 commits into
hivecommons:v5from
mendezr:feat/kick-outcomes-19032
Nov 18, 2026
Merged

kubestellar-prow[bot] merged 2 commits into
hivecommons:v5from
mendezr:feat/kick-outcomes-19032

Conversation

@mendezr

@mendezr mendezr commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Closes #19032

Summary

  • Add a Recent kick outcomes section to the focused agent panel, refreshed from GET /api/kick-outcomes.
  • Display all seven outcome kinds; owner/read-write responses include trigger, timing, PR, branch/SHA, refusal code and quoted evidence. Read-only responses display only the latest summary.
  • Escape untrusted strings, restrict PR link protocols, ignore disconnected-panel responses, and show explicit loading, empty and unavailable states.
  • Add responsive wrapping and a bounded history list, plus an isolated synthetic component capture in the existing desktop/phone, light/dark render-evidence harness.

Validation

  • Added Node regression tests for all outcome kinds, read-only filtering, escaping, unsafe URLs, empty/error states, authentication, refresh throttling and stale responses.
  • Added render-evidence section-selection coverage and synthetic API fixtures. CI will publish the render evidence; fixtures are not live data.
  • Tests and browser captures were not run locally, per AGENTS.md; execution is delegated to CI.
  • Regenerated static/index.html from its manifest and re-pinned the scripts tree as required.

-- hive: backend=pi model=openai/gpt-6.1-sol


🐝 Hive Agent: contributor | SHA: 7a24214af

Show the last ten kick outcomes and role-filtered evidence using the existing read API. Add refresh/error handling, renderer regression coverage and synthetic desktop/phone render-evidence fixtures.

Hive-Run: hivecommons#19032
Hive-Plan: kick-outcomes-ui
Hive-Spec: issue-19032#scope
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UI render evidence

Render evidence captured.

Built from b81693fbcc45.
Screenshots: download the artifact (sign-in to GitHub required).
Run: https://github.com/hivecommons/hive/actions/runs/44361598181

Page Section Viewport Theme File Size
hive overview desktop light hive-overview-desktop-light.png 351 KB
hive kick-outcomes desktop light hive-kick-outcomes-desktop-light.png 305 KB
hive overview desktop dark hive-overview-desktop-dark.png 326 KB
hive kick-outcomes desktop dark hive-kick-outcomes-desktop-dark.png 286 KB
hive overview phone light hive-overview-phone-light.png 506 KB
hive kick-outcomes phone light hive-kick-outcomes-phone-light.png 371 KB
hive overview phone dark hive-overview-phone-dark.png 503 KB
hive kick-outcomes phone dark hive-kick-outcomes-phone-dark.png 369 KB
hub-fleet overview desktop light hub-fleet-overview-desktop-light.png 114 KB
hub-fleet overview desktop dark hub-fleet-overview-desktop-dark.png 116 KB
hub-fleet overview phone light hub-fleet-overview-phone-light.png 267 KB
hub-fleet overview phone dark hub-fleet-overview-phone-dark.png 272 KB
hub-dashboard overview desktop light hub-dashboard-overview-desktop-light.png 347 KB
hub-dashboard overview desktop dark hub-dashboard-overview-desktop-dark.png 353 KB
hub-dashboard overview phone light hub-dashboard-overview-phone-light.png 667 KB
hub-dashboard overview phone dark hub-dashboard-overview-phone-dark.png 658 KB

These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from src/scripts/fixtures/render-evidence/. They show layout and theming, not how real hives behave. How to read them: src/docs/ui-render-evidence.md.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

needs-human: Prow has not run this fork PR's presubmits. Its author is not one of Prow's trusted users, so the trigger plugin waits for /ok-to-test; Hive posted it and Prow rejected hivecommons-hive[bot] ("Cannot trigger testing until a trusted user"). Hive will not post the command again on this PR.

A maintainer can comment /ok-to-test (plus /test all for the current head), or make hivecommons-hive[bot] a Prow trusted user so Hive's command counts.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@mendezr this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • test (dashboard 2/4)
  • test (dashboard shuffle 2/3)

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Your relay session received this as a fix-pr task and launched a parallel fix session; your current work continues.

Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19073 ✨ Settings UI for per-repo parent auto-close policy same files src/pkg/dashboard/static-src/manifest.txt
src/pkg/dashboard/static/index.html
#18873 🐛 needs-sha: exempt owner/detailed issues, overrideable waiver, visible hold on the row same files src/pkg/dashboard/static/index.html
#19063 ✨ PR gate: fail visibly when the Commit statuses grant is missing same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should confirm the re-pin of TRUSTED_SCRIPTS_TREE in .github/scripts/integration-governance.cjs (a CI trust surface) is acceptable on this PR.

Routing, not a defect. This PR changes TRUSTED_SCRIPTS_TREE at .github/scripts/integration-governance.cjs:12, the literal that pins which verifier tree CI trusts. That file is a trust surface, so a person should sign off.

What I verified: the new value 109f0f1af9f90cbdf4a7b433b22a0765bdb41d74 equals git rev-parse p65:src/scripts at head b81693fb, and the old value is what the guard at lines 159-164 would reject once src/scripts/lib/render-evidence.mjs and dashboard-render-evidence.mjs changed. So the pin edit is the mechanical re-pin the error message asks for, not an unrelated change.

The rest (kick-outcomes panel, escaping, http/https-only PR links, throttled refresh) reads correct to me; I found no defect. The endpoint it consumes exists on base (src/pkg/dashboard/api_kick_outcomes.go).

-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.327

@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

  • the reviewer swarm returned requires_human @b81693f
  • the review found: the reviewer marked this change high-risk
  • reviewer question: @clubanderson should confirm the re-pin of TRUSTED_SCRIPTS_TREE in .github/scripts/integration-governance.cjs (a CI trust surface) is acceptable on this PR.
  • the lane reported untrusted-author-role

Head: verdict requires_human @b81693f, 70/70 checks green, DCO yes, soak 9m0s of 10m0s.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

Updated 2026-11-18 18:16 UTC.

@mendezr

mendezr commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Review follow-up: acknowledged the TRUSTED_SCRIPTS_TREE decision request. The review confirms that the re-pin matches the scripts tree at current head b81693f and reports no code defect; I am leaving that mechanical pin intact rather than weakening the verifier or changing the trust gate. Maintainer approval remains required, and I have not cleared the hold or self-approved. The dashboard test-failure nudge targets the older 7a24214 head; current-head checks have no failures (only tide is pending). GitHub reports the PR mergeable, not DIRTY or BEHIND. No additional code fix is indicated by this review.


🐝 Hive Agent: contributor | SHA: unknown

@clubanderson clubanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving head b81693f. The TRUSTED_SCRIPTS_TREE re-pin was checked: the new pin 109f0f1 equals git rev-parse b81693f:src/scripts, and the merge with current v5 gives the same tree. The only src/scripts changes are the render-evidence script and test, plus an inert fixture, and the only edit to the pin file is that one literal. Thank you for the contribution.

@kubestellar-prow kubestellar-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 20b9757cd7fa64e49500f78eec206a39dea98f16

@clubanderson

Copy link
Copy Markdown
Member

/approve

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2026
@kubestellar-prow
kubestellar-prow Bot merged commit 421b318 into hivecommons:v5 Nov 18, 2026
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] Kick outcomes UI: show what each kick came to on the dashboard

2 participants