Repository navigation
✨ feature: show recent kick outcomes in agent details - #19065
Conversation
Show the last ten kick outcomes and role-filtered evidence using the existing read API. Add refresh/error handling, renderer regression coverage and synthetic desktop/phone render-evidence fixtures. Hive-Run: hivecommons#19032 Hive-Plan: kick-outcomes-ui Hive-Spec: issue-19032#scope Signed-off-by: mendezr <mendezr@users.noreply.github.com>
|
/ok-to-test |
|
@hivecommons-hive[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
UI render evidenceRender evidence captured. Built from
These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from |
|
needs-human: Prow has not run this fork PR's presubmits. Its author is not one of Prow's trusted users, so the trigger plugin waits for A maintainer can comment |
|
@mendezr this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm the re-pin of TRUSTED_SCRIPTS_TREE in .github/scripts/integration-governance.cjs (a CI trust surface) is acceptable on this PR.
Routing, not a defect. This PR changes TRUSTED_SCRIPTS_TREE at .github/scripts/integration-governance.cjs:12, the literal that pins which verifier tree CI trusts. That file is a trust surface, so a person should sign off.
What I verified: the new value 109f0f1af9f90cbdf4a7b433b22a0765bdb41d74 equals git rev-parse p65:src/scripts at head b81693fb, and the old value is what the guard at lines 159-164 would reject once src/scripts/lib/render-evidence.mjs and dashboard-render-evidence.mjs changed. So the pin edit is the mechanical re-pin the error message asks for, not an unrelated change.
The rest (kick-outcomes panel, escaping, http/https-only PR links, throttled refresh) reads correct to me; I found no defect. The endpoint it consumes exists on base (src/pkg/dashboard/api_kick_outcomes.go).
-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.327
|
Needs a decision, not a merge:
Head: verdict requires_human @b81693f, 70/70 checks green, DCO yes, soak 9m0s of 10m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to Updated 2026-11-18 18:16 UTC. |
|
Review follow-up: acknowledged the TRUSTED_SCRIPTS_TREE decision request. The review confirms that the re-pin matches the scripts tree at current head b81693f and reports no code defect; I am leaving that mechanical pin intact rather than weakening the verifier or changing the trust gate. Maintainer approval remains required, and I have not cleared the hold or self-approved. The dashboard test-failure nudge targets the older 7a24214 head; current-head checks have no failures (only tide is pending). GitHub reports the PR mergeable, not DIRTY or BEHIND. No additional code fix is indicated by this review. 🐝 Hive Agent: |
clubanderson
left a comment
There was a problem hiding this comment.
Approving head b81693f. The TRUSTED_SCRIPTS_TREE re-pin was checked: the new pin 109f0f1 equals git rev-parse b81693f:src/scripts, and the merge with current v5 gives the same tree. The only src/scripts changes are the render-evidence script and test, plus an inert fixture, and the only edit to the pin file is that one literal. Thank you for the contribution.
|
LGTM label has been added. DetailsGit tree hash: 20b9757cd7fa64e49500f78eec206a39dea98f16 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #19032
Summary
Validation
-- hive: backend=pi model=openai/gpt-6.1-sol
🐝 Hive Agent:
contributor| SHA:7a24214af