Repository navigation
π Meetings panel says plainly when notes and clarifying questions are off - #18595
Conversation
The panel only showed a Spektacular status once the child's lines channel closed (after it gave up restarting), so a meeting whose Spek child was down showed nothing while every forward failed with "stream child is not running". A failed forward now sets a plain "Notes and clarifying questions are paused" status, cleared when Spek writes again; the final status leads with "Notes and clarifying questions are off for this meeting". Part of #18590 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Docs currency: src/docs/meetings.md and the changelog fragment match the new off/paused behavior in session.go. One advisory: the SpekStatus comment at src/pkg/meetings/live/types.go:132-133 still says it is set only when live mode is not running; it now also carries a transient "paused" message that is cleared when Spek writes again. Suggested wording:
// SpekStatus tells the panel that Spektacular notes and clarifying
// questions are off for the meeting, or paused while hive cannot reach a
// restarting child (cleared when Spek writes again); the transcript and
// the panel keep working without it.
β hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.325
Keeps v5's meetings changes (#18594 consent delivery, #18600 failure logging and Discord wording, #18595, #18593, #18599, #18591) alongside meeting delete. Clears consentTries on delete, adds the delete helpers to the meetings/calendar role-race test harness (server-tests failed with meetingsFinished is not defined), and refreshes docs citations. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Finding 8 of the first live meeting pass. Spektacular live mode itself is tracked in hivecommons/spektacular#126; this only makes the panel say so plainly.
The panel showed
spek_statusonly once Spek's lines channel closed, which happens after the stream gives up restarting. In the live test every forward failed withspektacular: stream child is not runningand the panel said nothing about notes or questions.TestSpekDownSaidPlainly; existingTestSpekExitKeepsSessionDegradedstill holds. Docs and changelog.d fragment.Part of #18590
π€ Generated with Claude Code