Skip to content

πŸ› Meetings panel says plainly when notes and clarifying questions are off - #18595

Merged
kubestellar-prow[bot] merged 1 commit into
v5from
fix/18590-spek-status
Nov 17, 2026
Merged

kubestellar-prow[bot] merged 1 commit into
v5from
fix/18590-spek-status

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Finding 8 of the first live meeting pass. Spektacular live mode itself is tracked in hivecommons/spektacular#126; this only makes the panel say so plainly.

The panel showed spek_status only once Spek's lines channel closed, which happens after the stream gives up restarting. In the live test every forward failed with spektacular: stream child is not running and the panel said nothing about notes or questions.

  • A failed forward to Spek sets "Notes and clarifying questions are paused: Spektacular live mode is not running right now ... The transcript, the persona and research still work."; it is cleared when Spek writes again.
  • When the child is gone for good the status leads with "Notes and clarifying questions are off for this meeting" (still citing spektacular#126).
  • TestSpekDownSaidPlainly; existing TestSpekExitKeepsSessionDegraded still holds. Docs and changelog.d fragment.

Part of #18590

πŸ€– Generated with Claude Code

The panel only showed a Spektacular status once the child's lines
channel closed (after it gave up restarting), so a meeting whose Spek
child was down showed nothing while every forward failed with
"stream child is not running". A failed forward now sets a plain
"Notes and clarifying questions are paused" status, cleared when Spek
writes again; the final status leads with "Notes and clarifying
questions are off for this meeting".

Part of #18590

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18592 πŸ› Betty closes the loop on deep dives; research agents survive config reloads same files src/docs/meetings.md
src/pkg/meetings/live/session.go
#18593 ✨ Betty answers questions about the hive from its live state same files src/docs/meetings.md
#18615 ✨ Meetings: delete finished meetings and stale join requests same files src/docs/meetings.md
#18611 ✨ meetings: desktop companion meetings (/api/companion/*) same files src/docs/meetings.md
#18599 ✨ Betty acknowledges a spoken request from the partial transcript same files src/pkg/meetings/live/session.go
#18602 πŸ“– docs: Betty on Zoom without a Zoom app, options and recommendation same files src/docs/meetings.md

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs currency: src/docs/meetings.md and the changelog fragment match the new off/paused behavior in session.go. One advisory: the SpekStatus comment at src/pkg/meetings/live/types.go:132-133 still says it is set only when live mode is not running; it now also carries a transient "paused" message that is cleared when Spek writes again. Suggested wording:

// SpekStatus tells the panel that Spektacular notes and clarifying
// questions are off for the meeting, or paused while hive cannot reach a
// restarting child (cleared when Spek writes again); the transcript and
// the panel keep working without it.

β€” hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.325

@kubestellar-prow
kubestellar-prow Bot merged commit db0afc2 into v5 Nov 17, 2026
96 of 101 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/18590-spek-status branch November 17, 2026 03:05
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#18595b139725` sha256:85ebc01d1ea1f064bb43e6d4921a728e9bc2b22bec7b73a5f2ab5e85df072284 β€” download from the dashboard or `hivectl review evidence #18595`.

clubanderson added a commit that referenced this pull request Nov 17, 2026
Keeps v5's meetings changes (#18594 consent delivery, #18600 failure
logging and Discord wording, #18595, #18593, #18599, #18591) alongside
meeting delete. Clears consentTries on delete, adds the delete helpers
to the meetings/calendar role-race test harness (server-tests failed
with meetingsFinished is not defined), and refreshes docs citations.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant