Skip to content

πŸ› Dashboard: keep the Collaborate sidebar group and place it after Dashboard - #18562

Merged
kubestellar-prow[bot] merged 2 commits into
v5from
fix/collaborate-sidebar-group
Nov 17, 2026
Merged

kubestellar-prow[bot] merged 2 commits into
v5from
fix/collaborate-sidebar-group

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Problem

On a hosted hive at v5 5b5921e, the Collaborate heading added in #18523 never shows. Inbox, Calendar, Meetings and Inception (spek) end up inside the Dashboard group.

Root cause

dashboardSortSidebar (in static-src/js/layout.js) sorts every .oc-nav-item[data-section] whose section is in DASHBOARD_LAYOUT_TEMPLATE and appends it to #dashboard-section-nav-group. Any other group left with no items is then hidden. inbox-section and sessions-section were already in the template, and #18527 added calendar-section and meetings-section. So on every layout apply, all four Collaborate links were moved into Dashboard and the empty Collaborate group was hidden. Resources, Intelligence and Admin links in the template were pulled in the same way.

Fix

  • dashboardSidebarNavItems now returns only layout links that sit in the Dashboard group. A link written inside any other named oc-nav-group (Collaborate, Resources, Intelligence, Admin, Help) stays in that group, in its authored order. Sort, drag grips and dashboardSidebarLayoutFromDom use this list.
  • Hide toggles still cover every layout section, through the new dashboardSidebarLayoutItems.
  • A sidebar reorder now only swaps the Dashboard sections' own slots in the main-page layout, so the other sections keep their saved positions. Main-page card order, collapse defaults and padding from πŸ› dashboard: Meetings and Calendar wait for the role, sit in the layout, and read cleanlyΒ #18527 are unchanged.
  • The saved layout in localStorage only stores section order, never which group a link is in. A saved layout cannot pull a link out of its group.
  • Collaborate (#collaborate-nav-group) moves between Dashboard and Agents. The order is now Dashboard, Collaborate, Agents, Resources, Intelligence, Admin, Help.

Tests

  • New dashboard/test/sidebar-collaborate-group.test.js. It parses the real sidebar from the generated page and runs the real layout functions with a saved layout that puts the Collaborate sections first, with sessions on and off. It checks that:
    • the Collaborate heading exists with exactly Inbox, Calendar, Meetings, Inception (spek), in that order;
    • none of those links is in the Dashboard group;
    • the groups run Dashboard, Collaborate, Agents and so on;
    • a sidebar reorder keeps the Collaborate sections' layout positions.
  • TestDashboardApplyResetAndSidebarSort is updated. Links in another group now stay there and that group stays visible.

Docs

The sidebar tables in dashboard-design-system.md and dashboard-glossary.md show the new order. The glossary also notes that reordering only affects the Dashboard group.

πŸ€– Generated with Claude Code

…shboard

dashboardSortSidebar re-homed every nav link whose section is in
DASHBOARD_LAYOUT_TEMPLATE into #dashboard-section-nav-group. #18527 added
calendar-section and meetings-section to the template (inbox-section and
sessions-section were already there), so every Collaborate link moved into
the Dashboard group and the emptied Collaborate group was hidden.

Only links authored in the Dashboard group are now sorted, dragged and
re-homed; links in any other named group stay in place. Sidebar reorders
only swap the Dashboard sections' slots in the main-page layout, so other
sections keep their saved positions. Collaborate now sits between Dashboard
and Agents.

Adds a node test that renders the real sidebar and layout functions with a
saved layout putting the Collaborate sections first.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18592 πŸ› Betty closes the loop on deep dives; research agents survive config reloads same files src/pkg/dashboard/static/index.html
#18584 ✨ Show why a calendar-email proof failed on its Settings row same files src/pkg/dashboard/static/index.html
#18536 ✨ feature: choose remote repository write identity same files src/pkg/dashboard/static/index.html
#18576 ✨ Owner-only Send to on model-owned stage-tracker rows same files src/pkg/dashboard/static/index.html
#18594 πŸ› Meetings: consent posted only on a confirmed delivery; speak it or leave same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • server-tests

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

…the Collaborate test

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 3dfa787 into v5 Nov 17, 2026
97 of 98 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/collaborate-sidebar-group branch November 17, 2026 02:43
clubanderson added a commit that referenced this pull request Nov 17, 2026
v5's sidebar-collaborate-group test (#18562) lists the Dashboard group without v6's runs-section link.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant