Repository navigation
π Dashboard: keep the Collaborate sidebar group and place it after Dashboard - #18562
Conversation
β¦shboard dashboardSortSidebar re-homed every nav link whose section is in DASHBOARD_LAYOUT_TEMPLATE into #dashboard-section-nav-group. #18527 added calendar-section and meetings-section to the template (inbox-section and sessions-section were already there), so every Collaborate link moved into the Dashboard group and the emptied Collaborate group was hidden. Only links authored in the Dashboard group are now sorted, dragged and re-homed; links in any other named group stay in place. Sidebar reorders only swap the Dashboard sections' slots in the main-page layout, so other sections keep their saved positions. Collaborate now sits between Dashboard and Agents. Adds a node test that renders the real sidebar and layout functions with a saved layout putting the Collaborate sections first. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
β¦the Collaborate test Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
v5's sidebar-collaborate-group test (#18562) lists the Dashboard group without v6's runs-section link. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Problem
On a hosted hive at v5
5b5921e, the Collaborate heading added in #18523 never shows. Inbox, Calendar, Meetings and Inception (spek) end up inside the Dashboard group.Root cause
dashboardSortSidebar(instatic-src/js/layout.js) sorts every.oc-nav-item[data-section]whose section is inDASHBOARD_LAYOUT_TEMPLATEand appends it to#dashboard-section-nav-group. Any other group left with no items is then hidden.inbox-sectionandsessions-sectionwere already in the template, and #18527 addedcalendar-sectionandmeetings-section. So on every layout apply, all four Collaborate links were moved into Dashboard and the empty Collaborate group was hidden. Resources, Intelligence and Admin links in the template were pulled in the same way.Fix
dashboardSidebarNavItemsnow returns only layout links that sit in the Dashboard group. A link written inside any other namedoc-nav-group(Collaborate, Resources, Intelligence, Admin, Help) stays in that group, in its authored order. Sort, drag grips anddashboardSidebarLayoutFromDomuse this list.dashboardSidebarLayoutItems.#collaborate-nav-group) moves between Dashboard and Agents. The order is now Dashboard, Collaborate, Agents, Resources, Intelligence, Admin, Help.Tests
dashboard/test/sidebar-collaborate-group.test.js. It parses the real sidebar from the generated page and runs the real layout functions with a saved layout that puts the Collaborate sections first, with sessions on and off. It checks that:TestDashboardApplyResetAndSidebarSortis updated. Links in another group now stay there and that group stays visible.Docs
The sidebar tables in
dashboard-design-system.mdanddashboard-glossary.mdshow the new order. The glossary also notes that reordering only affects the Dashboard group.π€ Generated with Claude Code