Skip to content

🌱 Inception (spek): remove the Campaigns tab - #18400

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
retire-campaigns-ui
Nov 16, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
retire-campaigns-ui

Conversation

@clubanderson

Copy link
Copy Markdown
Member

First of three PRs that retire inception Campaigns in favour of Inception (spek) sessions.

What changes

  • Removes the Campaigns tab from the Inception (spek) section. The tab strip now lists sessions only. With no sessions, the "No sessions yet" note shows. A browser that still remembers the old campaigns tab id falls back to the first session.
  • Deletes static-src/js/campaigns.js and its manifest entry.
  • Prunes the campaign-only rules from static-src/css/review-campaigns.css: filters, revision and history rows, the delete icon and Jam. The file is shared, so the list/card rules stay. The Experiment Lab cards and the sessions form still use them.
  • /spek chat command and cheat-sheet hints no longer point at "active campaigns". They now point at spec runs and sessions.
  • Removes the campaign UI guard tests: TestCampaignDeleteUI and the Jam WebSocket assertion in TestDashboardLiveConnectionsCloseBeforeReconnect. Updates sessions_ui.test.js for the tab order without Campaigns.
  • Updates the docs to point at Sessions: inception.md, spektacular.md, dashboard-sections/workflow-and-agents.md, api-reference/health-status-events.md, plus the dashboard FAQ.
  • Regenerates static/index.html.

Why

Nothing has created inception campaigns since the wizard UI was removed (#18268). Continue has no wizard to return to. The Spektacular rows repeat what the Runs view already shows.

Not in this PR

  • /api/campaigns, campaign Jam and campaign Recheck still answer API callers. The next PR retires them, after a one-time read-only export of the archives.
  • No files under /data are touched.

v6

The v5 to v6 top-up carries this change to v6. The v6-only transcript fact-confirmation panel from the old wizard was already removed by an earlier top-up.

🤖 Generated with Claude Code

Retire the Campaigns tab of the Inception (spek) section in favour of
sessions: delete static-src/js/campaigns.js and its manifest entry, drop
the tab and pane from sessions.js, prune the campaign-only CSS rules
(the shared list styles stay for the Experiment Lab and the sessions
form), point the /spek chat hints at sessions and spec runs, remove the
campaign UI guard tests, and update the docs and FAQ.

The /api/campaigns API, Jam and Recheck are retired in a follow-up.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 16, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18399 ✨ meetings: Calendar section, scheduled joins and approvals (Betty C1) same files src/docs/api-reference/health-status-events.md
src/pkg/dashboard/static-src/manifest.txt
src/pkg/dashboard/static/index.html

@hivecommons-hive
hivecommons-hive Bot merged commit e45eb2a into v5 Nov 16, 2026
86 of 91 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the retire-campaigns-ui branch November 16, 2026 12:48
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#1840015747fd` sha256:7edc243dcbb90e456388db2792bc76a54e180f976a48e60691716eef2d547a1d — download from the dashboard or `hivectl review evidence #18400`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 15747fd.

@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2026
clubanderson added a commit that referenced this pull request Nov 16, 2026
…the rewrite window

The run-detail panel (toggleCampaignRunDetail, renderRunDetailPanel and
its source badge) lived only in campaigns.js and was reached only from
Campaigns rows, which v5 retired (#18400, #18407). Drop the two static
guards that pinned it. The Dockerfile metacopy rewrite list is re-wrapped
so hivectl stays inside the window test_hivectl_extraction_contract.sh
reads.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant