Repository navigation
π mobile-shots: phone-ergonomics hit-rect only grows and uses layout size - #17199
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
docs-currency: the PR body says "Test-only (webstatic/testdata/), hence no-changelog" and the PR carries the no-changelog label β but the diff also adds changelog.d/fixed-17199.md:1. Per changelog.d/README.md ("test-adjacent code like testdata/β¦ put a no-changelog label on such PRs" / "A non-user-visible change wants no fragment and the no-changelog label instead"), the fragment should not exist. src/scripts/check-changelog-fragment.sh:111-112 passes on the label alone and does not reject a stray fragment, so this file will be folded into CHANGELOG.md's ### Fixed at the next release as an operator-facing entry about a mobile-shots test probe (and in title-echo form, not the narrative style the README asks for β compare changelog.d/fixed-17105.md).
Fix: delete the fragment (the sibling #17195 correctly shipped without one).
--- a/changelog.d/fixed-17199.md
+++ /dev/null
@@ -1 +0,0 @@
-- mobile-shots: phone-ergonomics hit-rect only grows and uses layout size (#17199)β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Intent alignment: the probe change does what the body says. Verified against the CSS it reasons about: the ?/β ring uses a positive One gap between body and diff: Changelog fragment contradicts the stated --- a/changelog.d/fixed-17199.md
+++ /dev/null
@@ -1 +0,0 @@
-- mobile-shots: phone-ergonomics hit-rect only grows and uses layout size (#17199)Review findings from Style review (head e945e4b) β one in-scope issue. Stray changelog fragment contradicts the PR's own The body says "Test-only ( Fix: delete the file. --- a/changelog.d/fixed-17199.md
+++ /dev/null
@@ -1 +0,0 @@
-- mobile-shots: phone-ergonomics hit-rect only grows and uses layout size (#17199)Advisory (readability, no verdict impact) β Review findings from Read the probe against the CSS it measures; both regressions the body describes are real and the fix matches them.
Test-only change ( Note for the maintainer: #17196 (same author, same file) also rewrites this helper to stop shrinking on positive insets, but keeps |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
Follow-up to #17195, whose
hitRecthelper regressed thetracker-phone-ergonomicsprobe in two ways (seen on its own mobile-shots run):::beforewith positive insets inside the--tap-targetsquare (responsive.css); the helper subtracted them and reported 28Γ28 for 44Γ44 controls. The pseudo box can now only grow the measured rect, never shrink it..ham-pill-movedruns a one-shotscale(.94)animation;getBoundingClientRect()mid-animation reported 43px. The helper now measures layout size (offsetWidth/Height), which transforms do not affect.Test-only (
webstatic/testdata/), henceno-changelog.