You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Activity Monitor: externally merged PR row vanishes with no bee fly-off and no merge toast #16658
Activity Monitor, hive's own spoke, repo hivecommons/hive. An approved PR row (#16644) was merged at 19:35:26Z by @clubanderson with gh pr merge --admin --squash — not by hive's automerge sweep. The row disappeared from the tracker with no bee fly-off and no merge toast. Rows hive merges itself get the bee + "merged" banner every time.
Root cause
recently_merged carried only audit pr_merged lines. Hive's own merge writes that line synchronously (RecordPRMergedAudit) in the same pass that evicts the row, so the merged fact and the row-drop land in one payload. An external merge's audit line is written only after the PR poller's settle/claim scan and its enrichment worker (minutes), while the row is evicted at once by the webhook / enumeration. The SPA saw "gone", never "merged".
webhookItemHint for issues / issue_comment deliveries on a PR never read issue.pull_request.merged_at, so it built a closed, merged=false hint. evictClosedWebhookItem runs on every delivery, so github-actions' comment on 🐛 PR in progress chevron defers to running CI/Review and never speaks the CI verdict #16644 10 s after the merge produced a closed-unmerged snapshot → recently_closed → the SPA fired the quiet "closed" toast and deleted the PR's open observation, so the merge fact arriving later was no longer a false→true transition. The celebration was permanently forfeited.
recently_merged entries named no merger, so even where the banner fired it could not say who merged.
Fix
Server: recently_merged is the union of audit pr_merged lines and the merged ledger (webhook closed read, confirming read, closed sweep — any merger), deduped, each entry carrying merged_by. issue_comment/issues hints read issue.pull_request.merged_at. A closed snapshot for a PR the ledger holds merged is not listed in recently_closed, and a later merged snapshot withdraws an earlier closed listing.
Client: a closed key stays comparable (false) instead of being deleted, so a close later corrected to a merge still celebrates once. The merge banner head names the merger: #16644 merged by @clubanderson / #16645 merged by 🐝 hive. A closed-not-merged exit keeps the quiet info toast (#N closed · reason).
Tests: Go (recently_merged union + merged_by; issue_comment merged hint; recently_closed never outranks a merge) and node (hive-merged and externally-merged ⇒ bee + banner naming the merger; closed ⇒ quiet toast; closed-then-merged ⇒ one celebration).
@clubanderson this issue was closed by @hivecommons-hive[bot] as completed.
If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.
If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.
Activity
🐛 Activity Monitor: celebrate externally merged PRs with bee + toast …
🐛 Activity Monitor: lift merger helpers into the merge-banner node ha…
github-actions commentedon Nov 4, 2026
@clubanderson this issue was closed by @hivecommons-hive[bot] as completed.
If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.
If you are still seeing the problem, comment
/reopenand it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.🐛 Activity Monitor: celebrate externally merged PRs with bee + toast …