Skip to content

✨ feat: PR in progress chevron names the actor with their kind icon - #16771

Merged
clubanderson merged 2 commits into
v5from
feat/pr-progress-actor
Nov 5, 2026
Merged

clubanderson merged 2 commits into
v5from
feat/pr-progress-actor

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16770

A lit PR in progress chevron now reads PR in progress · @login followed by the actor's kind glyph (hive honeycomb / clanker robot / person), the way Waiting for @x names its person.

  • Source order: recorded holder (claimant) → stage_actor.login → the PR's author (author/author_kind, or the one covering PR's for an issue drawn through it). An issue's own author is never used.
  • The name rides inside the clamped chevron copy (.ham-holder inside .ham-seg-t) so it truncates exactly like the holder token; the icon sits outside the copy and is never truncated; the chevron tooltip carries the full text.
  • Nobody known (bot author, unlabelled author) keeps the bare PR in progress; inactive columns stay icon-only; CI/Review co-activation and the PR-in-progress fallback rule (🐛 PR in progress chevron defers to running CI/Review and never speaks the CI verdict #16644) are untouched.
  • New pure helper stageTrackerPRProgressActor (tracker-row.js) added to the prelude lift list; focused JS cases in stage_tracker_pr_progress_actor_test.go; static/index.html regenerated.

A lit PR in progress chevron reads "PR in progress · @login" with the
actor's kind glyph (hive / clanker / person), the way "Waiting for @x"
names its person. The recorded holder leads, then stage_actor.login,
then the PR's author; the name rides inside the clamped chevron copy so
it truncates like every holder, the icon sits outside it, the tooltip
carries the full text, and nobody known keeps the bare word.

Fixes #16770

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16769 🐛 fix: keep navigation label visible on phones same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (dashboard 4/4)
  • test (dashboard shuffle 3/3)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

An issue drawn through a covering PR with no author fell back to the
issue's author via stageTrackerReturnedAuthor; the helper now resolves
the one PR drawn here itself and keeps the bare word when it has none.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 5, 2026
@clubanderson
clubanderson merged commit 7d240ec into v5 Nov 5, 2026
84 of 88 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/pr-progress-actor branch November 5, 2026 15:14
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This merged with an unrelated file: .ci-log.txt (5,095 lines, ~827 KB) is a raw GitHub Actions runner log for test (dashboard 4/4) (.ci-log.txt:1 — "Current runner version", runner hostnames, step timings through "Cleaning up orphan processes" at line 5095). It is now tracked on v5 (7d240ec) and is not on v6 yet, so the next forward-merge will carry it across. Nothing in the diff or changelog references it — it looks like a local triage artifact that got swept into the commit.

Suggested follow-up, for @clubanderson or whoever lands the next v5 change: git rm .ci-log.txt, and consider adding /.ci-log.txt to the root .gitignore (which already ignores /issue[0-9]*.txt at line 30) so the pattern does not recur.

I did not re-review the chevron feature itself (the dashboard tests passed in CI); this comment is only about the stray file.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR in progress chevron should name the actor with their kind icon like 'Waiting for'

1 participant