Repository navigation
✨ feat: PR in progress chevron names the actor with their kind icon - #16771
Conversation
A lit PR in progress chevron reads "PR in progress · @login" with the actor's kind glyph (hive / clanker / person), the way "Waiting for @x" names its person. The recorded holder leads, then stage_actor.login, then the PR's author; the name rides inside the clamped chevron copy so it truncates like every holder, the icon sits outside it, the tooltip carries the full text, and nobody known keeps the bare word. Fixes #16770 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
An issue drawn through a covering PR with no author fell back to the issue's author via stageTrackerReturnedAuthor; the helper now resolves the one PR drawn here itself and keeps the bare word when it has none. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
This merged with an unrelated file: .ci-log.txt (5,095 lines, ~827 KB) is a raw GitHub Actions runner log for test (dashboard 4/4) (.ci-log.txt:1 — "Current runner version", runner hostnames, step timings through "Cleaning up orphan processes" at line 5095). It is now tracked on v5 (7d240ec) and is not on v6 yet, so the next forward-merge will carry it across. Nothing in the diff or changelog references it — it looks like a local triage artifact that got swept into the commit.
Suggested follow-up, for @clubanderson or whoever lands the next v5 change: git rm .ci-log.txt, and consider adding /.ci-log.txt to the root .gitignore (which already ignores /issue[0-9]*.txt at line 30) so the pattern does not recur.
I did not re-review the chevron feature itself (the dashboard tests passed in CI); this comment is only about the stray file.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Fixes #16770
A lit PR in progress chevron now reads
PR in progress · @loginfollowed by the actor's kind glyph (hive honeycomb / clanker robot / person), the wayWaiting for @xnames its person.claimant) →stage_actor.login→ the PR's author (author/author_kind, or the one covering PR's for an issue drawn through it). An issue's own author is never used..ham-holderinside.ham-seg-t) so it truncates exactly like the holder token; the icon sits outside the copy and is never truncated; the chevron tooltip carries the full text.PR in progress; inactive columns stay icon-only; CI/Review co-activation and the PR-in-progress fallback rule (🐛 PR in progress chevron defers to running CI/Review and never speaks the CI verdict #16644) are untouched.stageTrackerPRProgressActor(tracker-row.js) added to the prelude lift list; focused JS cases instage_tracker_pr_progress_actor_test.go;static/index.htmlregenerated.