Skip to content

πŸ› Activity Monitor: say 'hive bot lacks permission', not 'unauthorized' - #16641

Merged
clubanderson merged 1 commit into
v5from
fix/unauthorized-pill-wording
Nov 4, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/unauthorized-pill-wording

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16639

What

The Activity Monitor pill for a PR whose next step the hive's GitHub App cannot take read "unauthorized", which implies the person or the hive did something illegitimate. Owner verdict: "'unauthorized' is wrong. permissions lacking from hive bot is better."

Operator-facing wording only:

  • Pill label: unauthorized β†’ hive bot lacks permission.
  • Pill tooltips (generic, per-step, approve-workflow-runs, merge-workflow-path): "The hive bot's GitHub App is missing the 'actions: write' permission needed to …, so a person has to take that step. The hive:unauthorized comment on the PR names the permission and the action; hive resumes and clears the label once it's done." Permission names in single quotes.
  • Row hover line Unauthorized: … β†’ Hive bot lacks permission: …; Needs-attention chip title; needs-human tip; human-merge gate word (unauthorized β†’ hive bot lacks permission) in Go and its JS mirror; decision popover questions.

Not changed (contracts)

GitHub label hive:unauthorized, the comment marker, API fields unauthorized / unauthorized_step, stage reasons unauthorized:<step>, modifier id and CSS class ham-mod-unauthorized.

Tests

  • node --test src/pkg/dashboard/*.test.js β€” 314 pass
  • go test ./pkg/dashboard/ -run 'StageTracker|HumanAttention|Ratchet|Decision|Decide|Unauthorized' β€” ok
  • make dashboard-gen-check β€” clean

The muted pill for a PR whose next step the hive's GitHub App cannot take
read 'unauthorized', which blames the person. It now reads 'hive bot lacks
permission'; the tooltip, row hover line, Needs-attention chip title,
needs-human tip, human-merge gate word and decision popover say the same.
Label hive:unauthorized, comment marker and API fields are unchanged.

Fixes #16639

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16634 πŸ› fix(dashboard): preserve settled review verdicts and explain findings same files src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html
#16637 πŸ› Stage tracker: say CI running (not activity unknown) when checks are still pending same files src/pkg/dashboard/static-src/js/tracker-row-strip.js
src/pkg/dashboard/static/index.html

@clubanderson
clubanderson merged commit da691ee into v5 Nov 4, 2026
87 of 91 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/unauthorized-pill-wording branch November 4, 2026 18:55
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity Monitor: "unauthorized" pill wording blames the person; it is the hive bot lacking a permission

1 participant