Repository navigation
🐛 Keep a not-yet-run current-phase CI/Review chevron visibly filled - #16625
Conversation
mobile-shots tracker-header-geometry failed on rows whose current-phase CI/Review track has not run yet (unknown / queued beside its running neighbour): the icon-only .todo chevron lost its fill. Give .todo.ham-current the same muted field as .done/.failing — glyph only, neutral — and make the probe's failure message name the cell. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Review findings from intent-alignment — the CSS fix does what the title says: One in-scope blocker —
Review findings from Read at e5ea1c1 against the tree. Looks correct to me.
One stale comment, not a defect: I have not approved or merged anything. Evidence bundle `#1662516252d0` sha256:e849fc60b5f6fd4a17d20b970297b6e62c00bfc170c5edff03af5a8acb75c1e7 — download from the dashboard or `hivectl review evidence #16625`.Review findings from Read the rule against the tree at
Sequencing note for whoever merges: #16621 (same author) also edits |
There was a problem hiding this comment.
The CSS fix is correct; the red checks are a changelog-fragment formatting problem, not the diff.
What is blocking (changelog-fragment-guard, and native-queue-policy which only relays it):
changelog.d/fixed-16599-current-phase-track-fill.md:1has no leading-bullet. The guard log at a4e6590:a fragment must start with a '- ' entry bullet (or a '<!-- release: ... -->' marker) — it IS the entry; the compiler owns the ### headings.- Because of that, the autofix step committed a second fragment,
changelog.d/fixed-16625.md, derived from the PR title. Both now sit in the diff, so the compiled changelog would carry two entries for one change. Suggest prefixing the hand-written fragment with-and deletingfixed-16625.md(or keeping only the autofixed one).
What I verified on the CSS (src/pkg/dashboard/static-src/css/tracker.css):
- The new
.ham-seg.ham-activity-track.todo.ham-currentrule attracker.css:389has four-class specificity, so it wins over both.ham-seg.todo(tracker.css:358, transparent / opacity 0.5) and.ham-activity-track.ham-current(tracker.css:376), regardless of source order. It mirrors the.done/.failingsiblings at:387-388exactly, so the probe'sbackgroundColor !== 'rgba(0, 0, 0, 0)'check intracker-header-geometry.js:214will now pass for atodocurrent-phase track. static/index.html:1725carries the identical rule, sodashboard-gen-checkshould stay green.- The probe change only enriches the assertion message; the assertion itself is unchanged, which is what you want — it is the pre-existing probe that was red on #16600.
Minor (info): the comment block at tracker.css:370-375 still says "not started = .todo with the glyph alone. No muted "current-phase" tint", which the new rule now contradicts for the current-phase case. Worth a one-line touch while you are fixing the fragment, so the next reader does not take it as the rule.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Looks correct to me. Read the cascade in src/pkg/dashboard/static-src/css/tracker.css and the class derivation in tracker-row-strip.js:
tracker-row-strip.js:270producestodoonly when a track is neither lit, finished, finding nor settled — so.todo.ham-currentis exactly the "current phase, track not yet run" case the PR describes, and nothing else picks up the new fill.- The new 4-class selector (
tracker.css:389) outranks both.ham-seg.todo(transparent / opacity .5, line 359) and.ham-activity-track.ham-current(line 376, opacity only), and no later rule (.pending,.ham-stalled) matches atodocell, so the muted field actually lands. static/index.htmlis in sync withstatic-srcfor this block.- The probe change is message-only; the assertion itself is unchanged.
One small follow-up (info, not blocking): the comment at tracker.css:371-375 still says not started = .todo with the glyph alone. No muted "current-phase" tint — this rule now adds exactly that tint for the current-phase case, so that comment reads as contradicting the line fourteen rows below it. Worth a one-line amendment next time the file is touched.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the rule against the rest of the cascade in tracker.css at 16252d0; the fix is sound and looks correct to me.
What I verified
- The new selector
.ham-seg.ham-activity-track.todo.ham-current(src/pkg/dashboard/static-src/css/tracker.css:395) has four classes, so it beats.ham-seg.todo { background: transparent; … opacity: 0.5 }at:364(two classes) and.ham-activity-track.ham-currentat:382(two classes) regardless of order. Nothing after it in the file re-targets.todo;.pending(:398) and.active.ham-settled-current(:400) are disjoint classes. tracker-row-strip.js:270emitstodoexactly when a track is neither lit, finished, finding nor settled, and:320addsham-currentindependently — so the combination the probe was failing on (unknown CI on a 050 row, queued Review beside running CI) is precisely what this rule catches.static/index.html:1728-1740is byte-identical to the source block, sodashboard-gen-checkstays green.- The probe change (
tracker-header-geometry.js:214) only widens the failure message; the assertion itself is unchanged.
One low note (comment drift, not a blocker)
The comment block just above at tracker.css:376-381 (from #16484) still says "not started = .todo with the glyph alone. No muted 'current-phase' tint". This PR deliberately introduces that tint for the current phase, per the #16540 block at :383-387 ("muted for pending, decided or not started"). Worth trimming the sentence at :379-380 so the two comments stop contradicting each other — same edit in static/index.html.
conflicts-with-open-pr is set; this and #16621 touch the same two files, so whichever lands second will need a rebase — not a duplicate, different rules.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 16252d0. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Resolve tracker-header-geometry.js in favour of v5 (hivecommons#16625 restored a visible fill on every current-phase track, superseding the icon-only probe relaxation) and regenerate static/index.html. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Follow-up to #16600 (merged at ce96649 with
mobile-shotsred). Refs #16599.tracker-header-geometryfailed on rows whose current-phase CI/Review track has not run yet (CI unknown on a review-pending row, Review queued beside running CI): the icon-only.todochevron rendered transparent, so the row's current location disappeared..ham-seg.ham-activity-track.todo.ham-currentgets the same muted--panel-strongfield as.done/.failing— glyph only, neutral colour, per the canonical spec.Verified locally: full
dashboard-mobile-shots.mjsmatrix passes (all viewports × themes),go test ./pkg/dashboard/JS/Rows/MotionPreview,make dashboard-gen-check.