Skip to content

🐛 Keep a not-yet-run current-phase CI/Review chevron visibly filled - #16625

Merged
hivecommons-hive[bot] merged 5 commits into
v5from
fix/current-phase-todo-track-fill
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
v5from
fix/current-phase-todo-track-fill

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Follow-up to #16600 (merged at ce96649 with mobile-shots red). Refs #16599.

tracker-header-geometry failed on rows whose current-phase CI/Review track has not run yet (CI unknown on a review-pending row, Review queued beside running CI): the icon-only .todo chevron rendered transparent, so the row's current location disappeared.

  • .ham-seg.ham-activity-track.todo.ham-current gets the same muted --panel-strong field as .done/.failing — glyph only, neutral colour, per the canonical spec.
  • The probe's failure message now names the offending cell (class, track, state, computed background).

Verified locally: full dashboard-mobile-shots.mjs matrix passes (all viewports × themes), go test ./pkg/dashboard/ JS/Rows/MotionPreview, make dashboard-gen-check.

mobile-shots tracker-header-geometry failed on rows whose current-phase
CI/Review track has not run yet (unknown / queued beside its running
neighbour): the icon-only .todo chevron lost its fill. Give
.todo.ham-current the same muted field as .done/.failing — glyph only,
neutral — and make the probe's failure message name the cell.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16621 🐛 Activity Monitor: base-branch pill sits beside the repo chip same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#16619 🐛 fix(dashboard): preserve settled review verdicts and explain findings CONFLICT src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js
#16615 ✨ feat(ci): approve gated workflows for trusted PR heads CONFLICT src/pkg/dashboard/webstatic/testdata/tracker-header-geometry.js

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 4, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • overlayfs-exec-guard

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from ci-maintainer (folded here because this head already carries its hive review):

intent-alignment — the CSS fix does what the title says: .ham-seg.ham-activity-track.todo.ham-current (tracker.css:389, mirrored at index.html:1727) outranks .ham-seg.todo { background: transparent; … opacity: 0.5 } (tracker.css:358) by specificity, and the probe's existing routeState → ham-current + visible-fill assertion (tracker-header-geometry.js:214) now covers it. Matches #16599 "inactive = icon only, neutral if not yet run".

One in-scope blocker — changelog-fragment-guard is red on a4e6590:

changelog.d/fixed-16599-current-phase-track-fill.md:1 has no leading - bullet; src/scripts/check-changelog-fragment.sh:72-74 rejects any fragment not starting with - or <!-- release:. It also duplicates changelog.d/fixed-16625.md, so the compiler would emit two bullets for one PR. Suggest dropping the terse fixed-16625.md and keeping the narrative one as a bullet:

- Activity Monitor: a CI/Review chevron that is the row's current phase but has not run yet (CI unknown on a review-pending row, Review queued beside running CI) keeps a muted fill with its glyph instead of rendering transparent, so every row's current location stays visible (#16599, #16625).

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read at e5ea1c1 against the tree. Looks correct to me.

  • Cascade: the new .ham-seg.ham-activity-track.todo.ham-current (static-src/css/tracker.css:389, specificity 0,4,0) is declared after and outranks .ham-seg.todo (:358, 0,2,0, background: transparent; opacity: 0.5) and .ham-activity-track.ham-current (:376). No other file under static-src/css/ touches ham-activity-track, so nothing re-transparents it.
  • The class pair it targets is real: tracker-row-strip.js:270 emits todo for a not-started track and :320 appends ham-current on the current phase, which is exactly the cell tracker-header-geometry.js:212-214 asserts has a non-transparent fill.
  • static/index.html:1729 carries the same line as the source, so dashboard-gen-check should agree.

One stale comment, not a defect: tracker.css:370-375 (the #16484 block) still says "not started = .todo with the glyph alone. No muted 'current-phase' tint", which this rule now contradicts for the current phase. Worth trimming that sentence so the next reader isn't told the opposite of line 389.

I have not approved or merged anything.

Evidence bundle `#1662516252d0` sha256:e849fc60b5f6fd4a17d20b970297b6e62c00bfc170c5edff03af5a8acb75c1e7 — download from the dashboard or `hivectl review evidence #16625`.

Review findings from reviewer (folded here because this head already carries its hive review):

Read the rule against the tree at 16252d0. Looks correct to me.

  • The combination is real: static-src/js/tracker-row-strip.js:270 resolves cls to 'todo' whenever a track is not lit/finished/finding/settled, and :320 appends ham-current independently of cls, so a current-phase CI-unknown or Review-queued cell renders as .ham-seg.ham-activity-track.todo.ham-current.
  • Why it was transparent: tracker.css:364 .ham-seg.todo { background: transparent; … opacity: 0.5 } and the existing :382 .ham-activity-track.ham-current only restores opacity/box-shadow, never background. The new rule at :395 is four classes (0,4,0) and later in the sheet, so it wins over both without touching non-current .todo cells elsewhere in the strip.
  • static/index.html:1728-1735 mirrors static-src byte-for-byte, so dashboard-gen-check should stay green.
  • The probe change in tracker-header-geometry.js:214 is message-only; the assertion itself is unchanged.

Sequencing note for whoever merges: #16621 (same author) also edits tracker.css and static/index.html, which is where the conflicts-with-open-pr label comes from. The hunks are in different regions, so whichever lands second needs a routine rebase, nothing semantic.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS fix is correct; the red checks are a changelog-fragment formatting problem, not the diff.

What is blocking (changelog-fragment-guard, and native-queue-policy which only relays it):

  • changelog.d/fixed-16599-current-phase-track-fill.md:1 has no leading - bullet. The guard log at a4e6590: a fragment must start with a '- ' entry bullet (or a '<!-- release: ... -->' marker) — it IS the entry; the compiler owns the ### headings.
  • Because of that, the autofix step committed a second fragment, changelog.d/fixed-16625.md, derived from the PR title. Both now sit in the diff, so the compiled changelog would carry two entries for one change. Suggest prefixing the hand-written fragment with - and deleting fixed-16625.md (or keeping only the autofixed one).

What I verified on the CSS (src/pkg/dashboard/static-src/css/tracker.css):

  • The new .ham-seg.ham-activity-track.todo.ham-current rule at tracker.css:389 has four-class specificity, so it wins over both .ham-seg.todo (tracker.css:358, transparent / opacity 0.5) and .ham-activity-track.ham-current (tracker.css:376), regardless of source order. It mirrors the .done / .failing siblings at :387-388 exactly, so the probe's backgroundColor !== 'rgba(0, 0, 0, 0)' check in tracker-header-geometry.js:214 will now pass for a todo current-phase track.
  • static/index.html:1725 carries the identical rule, so dashboard-gen-check should stay green.
  • The probe change only enriches the assertion message; the assertion itself is unchanged, which is what you want — it is the pre-existing probe that was red on #16600.

Minor (info): the comment block at tracker.css:370-375 still says "not started = .todo with the glyph alone. No muted "current-phase" tint", which the new rule now contradicts for the current-phase case. Worth a one-line touch while you are fixing the fragment, so the next reader does not take it as the rule.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Read the cascade in src/pkg/dashboard/static-src/css/tracker.css and the class derivation in tracker-row-strip.js:

  • tracker-row-strip.js:270 produces todo only when a track is neither lit, finished, finding nor settled — so .todo.ham-current is exactly the "current phase, track not yet run" case the PR describes, and nothing else picks up the new fill.
  • The new 4-class selector (tracker.css:389) outranks both .ham-seg.todo (transparent / opacity .5, line 359) and .ham-activity-track.ham-current (line 376, opacity only), and no later rule (.pending, .ham-stalled) matches a todo cell, so the muted field actually lands.
  • static/index.html is in sync with static-src for this block.
  • The probe change is message-only; the assertion itself is unchanged.

One small follow-up (info, not blocking): the comment at tracker.css:371-375 still says not started = .todo with the glyph alone. No muted "current-phase" tint — this rule now adds exactly that tint for the current-phase case, so that comment reads as contradicting the line fourteen rows below it. Worth a one-line amendment next time the file is touched.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the rule against the rest of the cascade in tracker.css at 16252d0; the fix is sound and looks correct to me.

What I verified

  • The new selector .ham-seg.ham-activity-track.todo.ham-current (src/pkg/dashboard/static-src/css/tracker.css:395) has four classes, so it beats .ham-seg.todo { background: transparent; … opacity: 0.5 } at :364 (two classes) and .ham-activity-track.ham-current at :382 (two classes) regardless of order. Nothing after it in the file re-targets .todo; .pending (:398) and .active.ham-settled-current (:400) are disjoint classes.
  • tracker-row-strip.js:270 emits todo exactly when a track is neither lit, finished, finding nor settled, and :320 adds ham-current independently — so the combination the probe was failing on (unknown CI on a 050 row, queued Review beside running CI) is precisely what this rule catches.
  • static/index.html:1728-1740 is byte-identical to the source block, so dashboard-gen-check stays green.
  • The probe change (tracker-header-geometry.js:214) only widens the failure message; the assertion itself is unchanged.

One low note (comment drift, not a blocker)

The comment block just above at tracker.css:376-381 (from #16484) still says "not started = .todo with the glyph alone. No muted 'current-phase' tint". This PR deliberately introduces that tint for the current phase, per the #16540 block at :383-387 ("muted for pending, decided or not started"). Worth trimming the sentence at :379-380 so the two comments stop contradicting each other — same edit in static/index.html.

conflicts-with-open-pr is set; this and #16621 touch the same two files, so whichever lands second will need a rebase — not a duplicate, different rules.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit ecd0151 into v5 Nov 4, 2026
83 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/current-phase-todo-track-fill branch November 4, 2026 17:55
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 16252d0.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

hivecommons-hive Bot added a commit to thatguywob/hive that referenced this pull request Nov 4, 2026
Resolve tracker-header-geometry.js in favour of v5 (hivecommons#16625 restored a visible fill on every current-phase track, superseding the icon-only probe relaxation) and regenerate static/index.html.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant