Repository navigation
π Activity Monitor: state why a human is needed on the row itself - #16624
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Style review (read head 58fffb1d; advisory β nothing here blocks the contract in #16623).
-
needs humanpill<button>skips the badge-button reset the repo already has βstatic-src/css/tracker.css:362only setscursor/font, while the sibling badge-as-buttonbutton.ham-decision-trigger(tracker.css:777) also zeroesmargin/padding/border/background. No globalbuttonreset exists inbase.css/design-system.css, so the new pill attracker-row-strip.js:673will carry the UAButtonFacebackground and margins next to the<span>pills. Also the new block is indented at col 0 and wedged between.ham-seg.done.ham-fix-pushedand its::beforerule (tracker.css:357-365).-.ham-seg.done.ham-blocker-note { color: var(--amber); opacity: 1; } -/* The "needs human" pill is a button: click scrolls to the Needs human line. */ -.ham-needs-human-pill { cursor: pointer; font: inherit; } -.ham-needs-human-pill:hover, .ham-needs-human-pill:focus-visible { text-decoration: underline; } + .ham-seg.done.ham-blocker-note { color: var(--amber); opacity: 1; } + /* The "needs human" pill is a button: click scrolls to the Needs human line. Same UA reset as ham-decision-trigger. */ + button.ham-needs-human-pill { cursor: pointer; margin: 0; background: transparent; font: inherit; color: inherit; line-height: inherit; text-align: inherit; } + .ham-needs-human-pill:hover, .ham-needs-human-pill:focus-visible { text-decoration: underline; }
(padding/border/radius come from
.ham-badgeattracker.css:251.) -
Dead clause in
asked_byβstatic-src/js/tracker-human-attention.js:41:actor.login && actor.kind === 'hive' && 'the hive'can only yield'the hive', which is already the trailing fallback.return { kind: item.kind, number: Number(item.number) || 0, reason, question, asked_by: String(d.asked_by || '').trim() || 'the hive', synthetic: true }; -
// Pure:on a non-pure helper βtracker-human-attention.js:55-62labelsstageTrackerNeedsHumanLeadLabel"Pure", but it readswindow._hiveRole/_hiveUserviastageTrackerActionCtx(tracker-actions.js:193-199), the_stageTrackerRowsglobal, and mutatesctx.rows. The file usesPure:elsewhere for side-effect-free helpers; drop the prefix (and consider passingnowMsas the sibling at:174-175does).
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Read at The rebase is semantic, not just textual. Two consistent ways through, both the author's call: keep the done column icon + person glyph and move
Review findings from Correctness review @ 58fffb1 (true merge-base is c239bcb / #16609; #16600 landed on the default branch in parallel). The behaviour in the body is all implemented and the dashboard JS suite is green on this head (304/304, incl. the 14 in 1. Branch does not merge onto the current default branch, and the new 010 "blocker note" contradicts the #16599 icon-only chevron rule that landed in #16600
} else if (blockerNote) {
β¦
inner = `<span class="ham-chevron-info config-info" β¦>${stageTrackerIcon(sg.number, 'ham-ico')}<span class="ham-chevron-copy"><span class="ham-seg-t">${esc(blockerNote)}</span></span>${stageTrackerIcon('human', β¦)}β¦`;So after a rebase, the rule #16600 introduced (and its tests, e.g. Requested change: rebase onto the current default branch and resolve the three conflicts, then rebuild - inner = `<span class="ham-chevron-info config-info" tabindex="0" title="" aria-label="${esc(noteTip)}" aria-describedby="${esc(tipID)}">${stageTrackerIcon(sg.number, 'ham-ico')}<span class="ham-chevron-copy"><span class="ham-seg-t">${esc(blockerNote)}</span></span>${stageTrackerIcon('human', 'ham-ico ham-actor-ico', 'Next move: human')}<span id="${esc(tipID)}" class="config-tooltip ham-chevron-tip" role="tooltip">${esc(noteTip)}</span></span>`;
+ // Inactive = icon only (hivecommons/hive#16599): the blocker word
+ // rides the tooltip; the person glyph marks who it waits on.
+ inner = `<span class="ham-chevron-info config-info" tabindex="0" title="" aria-label="${esc(noteTip)}" aria-describedby="${esc(tipID)}">${stageTrackerIcon(sg.number, 'ham-ico')}${stageTrackerIcon('human', 'ham-ico ham-actor-ico', 'Next move: human')}<span id="${esc(tipID)}" class="config-tooltip ham-chevron-tip" role="tooltip">${esc(noteTip)}</span></span>`;(and drop the Verified OK (no action): hive/awaiting-ci: rebased onto v5 (conflicts in tracker.css / tracker-row-strip.js / generated index.html resolved keeping #16599's icon-only pushed-fix chevron alongside this PR's blocker-note branch; index.html regenerated from static-src). CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#166241a25e2b` sha256:f7b00e2fa6b814b9bef11b51317417be839d9c1c731047ec155b1034ff152787 β download from the dashboard or `hivectl review evidence #16624`. |
A row flagged needs-human renders its reason in the hive-note line (blocker short + first sentence of the ask + asker + lead option + who is pushing a covering PR), keeps the Blocked Β· <short> π€ word in the issue's decision column when a PR strip drives the row, turns the needs-human pill into a reveal button with the full reason as hover, captions the 085 chevron 'Needs human Β· <short reason>' from a small map of known reasons, reads 'decision on #PR' on an issue blocked only by its PR's pending decision, leads with the first enabled blocker option when the server disables decide:delegate (rendered muted with reason_if_disabled), and drops the double space in the 'owed β blocked: β¦' caption. Fixes #16623 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
58fffb1 to
1a25e2b
Compare
|
@clubanderson this PR is back in your court (
Once the new head lands, CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 1a25e2b. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
Read the JS at 1a25e2b against the rest of static-src/js and ran the dashboard test standalone. Looks correct to me.
What I verified:
- The new
needs humanpill attracker-row-strip.js:784dispatchesdata-action="stageTrackerNeedsHumanReveal"through the generic resolver (tooltips-dialogs.js:219,HIVE_GEN_HANDLERS[action] || window[action]), the same path the existing note toggle attracker-motion.js:353uses;stageTrackerNeedsHumanRevealis declared at the same scope asstageTrackerNoteToggle(tracker-motion.js:289/:298), so it resolves identically. stageTrackerNeedsHumanLeadLabel(tracker-human-attention.js:58-66) setsctx.rowson the objectstageTrackerActionCtxreturns; that function builds a fresh literal per call (tracker-actions.js:193-200), so nothing shared is mutated. It calls intostageTrackerLeadActionOnRow(tracker-actions.js:564), which does not call back into the human-attention helpers, so no recursion.stageTrackerNeedsHumanAskonly synthesizes when the server put a reason on the row (question/blocker.detail/decision_needed.blocker/blocker.short/ human actorwhy); a bare 045/085 stage returns null (tracker-human-attention.js:38-40), matching the comment's intent.humanizeStageReason'sblocked:early return (stage_tracker_caption.go:343-345) sits before the generic replacer, which is where the:double space came from.node --test src/pkg/dashboard/stage_tracker_human_attention.test.jsat this head: 14/14 pass, including the two new scenarios (covered issue on a capability blocker; 085 PR withouthuman_attention).
One info-level nit, no action required: in stageTrackerNeedsHumanAsk (tracker-human-attention.js:41) the asked_by expression d.asked_by || actor.login && actor.kind === 'hive' && 'the hive' || '' is followed by || 'the hive', so the middle clause can never change the result β every synthetic ask without asked_by reads "asked by the hive" regardless of stage_actor. That is the right default; the clause is just dead.
CI note: Sign-off survives the squash and native-queue-policy show CANCELLED and mobile-shots has no conclusion at this head β looks like a re-run was interrupted rather than a failure in the diff. Not a finding.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Fixes #16623
Problem
Activity Monitor rows parked on a person did not say why. hivecommons/docs#612 (issue at 045, capability blocker, covered by human PR #620) showed a bare muted
needs humanpill andLet hive decide βΈ; rationguard#480 (PR at 085) read only "Needs human decision", and its issue #431 woreblockedpurely because of that pending decision. The payload carried the reason in every case.Changes
Row states the reason (JS,
static-src/js)tracker-human-attention.js:stageTrackerNeedsHumanAsk(item)synthesizes an ask fromdecision_needed/blockerfor flagged rows the server leaves out ofhuman_attention(085 PRs); the note line now reads#N β Needs human: <blocker.short> β <first sentence of the ask> Β· requested by <asked_by> Β· lead: <enabled option> βΈ Β· @author is pushing it in #PR. A synthesized ask keeps the fulldecision_needed.question. Existing exact-line expectations are unchanged.tracker-words-core.js:STAGE_TRACKER_NEEDS_HUMAN_SHORTmap (workflow pathβ "edits CI workflows",capability:workflows-permissionβ "App lacks workflows permission", β¦),stageTrackerNeedsHumanShort/Word.tracker-row.js: 045/085 active word becomesNeeds human Β· <short>; a done issue decision column under a covering PR carriesblockerNote.tracker-row-strip.js: renders the blocker note (Blocked Β· App lacks workflows permission π€, classham-blocker-note);needs humanpill becomes a<button class="ham-needs-human-pill">with the full reason astitle, click βstageTrackerNeedsHumanReveal;blockedpill readsdecision on #480when the only cause is a linked PR parked at 085 (stageTrackerBlockedForDecisionPR).tracker-motion.js:stageTrackerNeedsHumanReveal(rowKey)untucks and scrolls the row's note line.tracker.css:.ham-seg.done.ham-blocker-note,.ham-needs-human-pill(tokens only, no raw font-size).Lead action (
tracker-actions.js)stageTrackerDecideOptionshonours the server'sdecide:delegateenabled:false/reason_if_disabled.stageTrackerLeadAction: when delegate is server-disabled, the first enabled non-destructive blocker option leads (Grant the App workflows: write βΈβ opens its URL, elseRe-check permissions βΈ);stageTrackerLeadCompanionrendersLet hive decidemuted (ham-act-secondary,aria-disabled, reason tooltip).Go
stage_tracker_caption.go:humanizeStageReasonkeepsblocked: <short>as-is (was "owed β blocked: App lacksβ¦").Tests
stage_tracker_needs_human_reason_test.go: docs#612 + rationguard#480/fix: handle repos with org prefix in dynamic repo listΒ #431 fixtures β blocker note with person glyph, pill button with reason,Needs human Β· edits CI workflowschevron word,decision on #480, lead =open:app-settings, delegate muted with reason, caption spacing, page wiring.stage_tracker_human_attention.test.js: note line for fix: use advisory policy and preamble for non-quality agents at L3Β #612 (blocker + ask + asker + lead +@bob is pushing it in #620), synthesized 085 ask with the full question; closed/draft/held rows and evidence-less parked stages synthesize nothing.Ran
node --test src/pkg/dashboard/*.test.js(304 pass),cd src && go test ./pkg/dashboard/ -run 'StageTracker|Ratchet|SharedAsset'(ok),make dashboard-gen-check(ok).