Skip to content

[reviewer] Review backlog (docs-currency): API table row for /api/matrix/lines lacks the deprecation marker carried by the prose section #16563

Closed

Description

@hivecommons-hive

Blocked on PR #16514. This finding came from reviewing PR #16514 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16514.

PR: #16514 (#16514)
Perspective: docs-currency
Severity: info (P3)
Finding: API table row for /api/matrix/lines lacks the deprecation marker carried by the prose section
Evidence: src/docs/api-reference/dashboard-misc.md:59

| `GET` | `/api/matrix/lines` | Dashboard auth/session | Matrix Lines: serve bounded backlog of pushed lines behind dashboard.matrix with repo allowlist filtering. `max` counts only lines the repo allowlist admits, so a page is never emptied by filtered-out lines. A client paging with `max` should use the last returned line's `seq` as its next `since`, not the top-level `seq`, which is the source's latest sequence number and would skip lines still past the page. | `pkg/dashboard/api.go:191` |

src/docs/api-reference/dashboard-misc.md:59 still titles the endpoint row 'Matrix Lines' with no deprecated note, while the new 'Published-checkpoint regions' section at dashboard-misc.md:142-144 and operator-reference/README.md:287 do state that /api/matrix/lines and dashboard.matrix.* are deprecated names retained for compatibility. The contract (#16477: 'mark deprecated in docs with a note') is satisfied by the section; adding '(deprecated name, see Published-checkpoint regions)' to the table row would make it discoverable from the endpoint index too. Advisory only.

Fingerprint: 9752f87a08d1d5409384b8479511c945394108e3e40bcf0fdc041704ca2cb71b

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  4. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: source PR #16514 closed unmerged — re-triage against current base. A superseding PR often lands the same lines, so the finding may still apply; close this item only if it no longer does.

  5. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16514 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @thatguywob released (lease revoked).

    Claim history
    • 2026-11-04 14:36 UTC — claimed by thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-04 14:42 UTC — released by thatguywob (contributor; lease revoked)
  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  8. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16609 (merged c239bcb). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions