Repository navigation
π fix(deploy): open hive-hosted-matrix overlay with view=reader - #16614
Conversation
The replicas:0 hive-hosted-matrix stream overlay still requested view=matrix, which only works via the deprecated alias in boot.js. Switching to view=reader keeps the overlay working once the alias is removed. Closes #16612 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#166148b491ba` sha256:342c694604375c51c2f70dfcab48b828b1fd71b9c9e21bab77de11b5cad1a74f β download from the dashboard or `hivectl review evidence #16614`. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
8b491ba
βΉοΈ Sentinel notice β informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
There was a problem hiding this comment.
Correctness review (head 8b491ba)
The overlay change is right: view=reader is handled on v5 at src/pkg/dashboard/static-src/js/boot.js:41 (HIVE_READER = kiosk && (view === 'reader' || view === 'matrix')) and the replicas: 0 overlay stays inert.
Finding (low, in-scope): operator doc for this overlay now contradicts it.
src/docs/streaming-the-activity-monitor.md on v5 (post-#16609) documents the hive-hosted-matrix overlay itself, not the dashboard:
- line 318β319: "It opens
/?kiosk=1&view=matrix&sound=off(the deprecated alias, which now shows Code activity)" - line 329β330: step 1 tells the owner to confirm the build serves Code activity for "
view=matrix(the alias the overlay opens)".
After this PR the overlay opens view=reader, so both lines describe a URL it no longer sends; the activation checklist would have an operator verify the wrong parameter. The PR body's "No other files touched; #16609 owns the dashboard side" doesn't cover these β they are the overlay's own docs. Requested fix: update those two passages to view=reader (and drop the "deprecated alias" parenthetical) in this PR.
Note: the branch is one commit behind v5 (the #16609 merge); no file overlap, so no conflict expected.
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #16612
The
hive-hosted-matrixstream overlay (replicas: 0) still requestedview=matrix, which on v5 boots the Matrix presentation and, after #16609, only works through the deprecated alias inboot.js. Switching it toview=readerβ already supported on v5 (boot.js:45) β means the overlay keeps opening the Code reader when the alias is eventually removed instead of silently falling back to the plain kiosk. No other files touched; #16609 owns the dashboard side.β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88