Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fixed-16551-chevron-height.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Activity Monitor stage chevrons are a one-line band again on phones and touch tablets; the chevron's info wrapper no longer inherits the 40px tap-target floor (and ring) that made every chevron a 44px box ([#16551](https://github.com/hivecommons/hive/issues/16551)).
5 changes: 5 additions & 0 deletions src/pkg/dashboard/stage_tracker_activity.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,11 @@ test('known and original chevrons keep full long text inside a shared one-line c
assert.ok(known.match(/role="tooltip">([^]*?)<\/span>/)[1].includes(handle));
const css = fs.readFileSync(path.join(__dirname, 'static-src/css/tracker.css'), 'utf8');
assert.match(css, /--ham-chevron-text-lines: 1;/);
// responsive.css gives every .config-info a 40px --tap-target floor on
// phones; the chevron's info wrapper must undo it or each chevron becomes
// a 44px box (hivecommons/hive#16551).
assert.match(css, /\.ham-chevron-info\.config-info, \.ham-chevron-info\.ham-chevron-decision \{[^}]*min-height: 0;/);
assert.match(css, /\.ham-chevron-info\.config-info::before \{ content: none; \}/);
assert.match(css, /\.ham-chevron-copy \{[^}]*-webkit-line-clamp: var\(--ham-chevron-text-lines\);[^}]*white-space: normal; overflow-wrap: anywhere;/);
assert.doesNotMatch(css, /\.ham-(?:seg-t|detour)\.ham-has-holder[^}]*white-space: nowrap/);
assert.match(css, /padding: var\(--sp-1\) calc\(var\(--ham-notch\) \+ var\(--sp-2\)\)/);
Expand Down
7 changes: 6 additions & 1 deletion src/pkg/dashboard/static-src/css/tracker.css
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,12 @@
focus exposes the same full text. */
.ham-strip[aria-label="Pipeline progress"] { grid-auto-rows: minmax(calc(var(--ham-chevron-line-height) * 1em + 2 * var(--sp-1) + 2 * var(--line-width)), auto); }
.ham-strip[aria-label="Pipeline progress"] > .ham-seg { box-sizing: border-box; align-self: stretch; line-height: var(--ham-chevron-line-height); padding: var(--sp-1) calc(var(--ham-notch) + var(--sp-2)); }
.ham-chevron-info.config-info, .ham-chevron-info.ham-chevron-decision { display: flex; align-items: center; justify-content: center; gap: var(--sp-1); width: 100%; height: 100%; min-width: 0; flex-shrink: 1; margin: 0; padding: 0; border: 0; background: transparent; color: inherit; font: inherit; line-height: inherit; position: static; }
/* min-height: 0 and no ::before ring: on phones / coarse pointers
responsive.css turns every .config-info into a --tap-target (40px)
square with a drawn ring; the chevron's info wrapper is not that
icon, and its 40px floor made every chevron a 44px box. */
.ham-chevron-info.config-info, .ham-chevron-info.ham-chevron-decision { display: flex; align-items: center; justify-content: center; gap: var(--sp-1); width: 100%; height: 100%; min-width: 0; min-height: 0; flex-shrink: 1; margin: 0; padding: 0; border: 0; background: transparent; color: inherit; font: inherit; line-height: inherit; position: static; }
.ham-chevron-info.config-info::before { content: none; }
.ham-chevron-info.config-info:hover { background: transparent; border: 0; color: inherit; }
.ham-chevron-info:focus-visible, .ham-chevron-decision:focus-within { outline: var(--line-width) solid currentColor; outline-offset: var(--sp-1); }
/* The copy shrink-wraps its text (flex 0 1 auto) so the words, with
Expand Down
7 changes: 6 additions & 1 deletion src/pkg/dashboard/static/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -1769,7 +1769,12 @@
focus exposes the same full text. */
.ham-strip[aria-label="Pipeline progress"] { grid-auto-rows: minmax(calc(var(--ham-chevron-line-height) * 1em + 2 * var(--sp-1) + 2 * var(--line-width)), auto); }
.ham-strip[aria-label="Pipeline progress"] > .ham-seg { box-sizing: border-box; align-self: stretch; line-height: var(--ham-chevron-line-height); padding: var(--sp-1) calc(var(--ham-notch) + var(--sp-2)); }
.ham-chevron-info.config-info, .ham-chevron-info.ham-chevron-decision { display: flex; align-items: center; justify-content: center; gap: var(--sp-1); width: 100%; height: 100%; min-width: 0; flex-shrink: 1; margin: 0; padding: 0; border: 0; background: transparent; color: inherit; font: inherit; line-height: inherit; position: static; }
/* min-height: 0 and no ::before ring: on phones / coarse pointers
responsive.css turns every .config-info into a --tap-target (40px)
square with a drawn ring; the chevron's info wrapper is not that
icon, and its 40px floor made every chevron a 44px box. */
.ham-chevron-info.config-info, .ham-chevron-info.ham-chevron-decision { display: flex; align-items: center; justify-content: center; gap: var(--sp-1); width: 100%; height: 100%; min-width: 0; min-height: 0; flex-shrink: 1; margin: 0; padding: 0; border: 0; background: transparent; color: inherit; font: inherit; line-height: inherit; position: static; }
.ham-chevron-info.config-info::before { content: none; }
.ham-chevron-info.config-info:hover { background: transparent; border: 0; color: inherit; }
.ham-chevron-info:focus-visible, .ham-chevron-decision:focus-within { outline: var(--line-width) solid currentColor; outline-offset: var(--sp-1); }
/* The copy shrink-wraps its text (flex 0 1 auto) so the words, with
Expand Down
Loading