Skip to content

🐛 Review chevron: done-style once perspectives finish, verdict word when adopted - #16532

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/review-chevron-amber
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/review-chevron-amber

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #16531

Problem

On a PR row back in PR in progress ("Adopted by hive · activity…"), the Review chevron rendered AMBER (in-progress fill) reading Review 5/5 · awaiting huma… although all perspectives were done and nobody was running anything.

Rules implemented

  1. Amber only while running. stageTrackerActivityTrackHtml: a complete human_decision verdict is done decided (muted settled style, never the active fill, no pulse). Approved stays done, changes requested stays failing, in-progress perspectives (a.active) stay active. CI unchanged: 11/11 passed = done; amber only while checks run.
  2. No "awaiting human" when the hive owns the repair.
    • Go: stageTrackerAdoptHumanDecision (called from stageTrackerApplyRemediation) rewrites a current-head human_decision review activity to changes_requested / "Review findings · changes requested" when the row is at 074 adopted or a 07x fix stage and is not parked on a person (NeedsHuman, OnHold, Hold, 085). The decision question and +adopted-decision provenance ride in detail/source.
    • JS fallback: stageTrackerHiveOwnsRepair(item) → word "changes requested" for adopted / remediating / unassigned / fix_pushed / fixing code activity, stage 74 or adopted_by; "awaiting human decision" stands when genuinely parked.
  3. 🐛 dashboard: CI/Review chevrons show pass/total and perspectives done/total, lit while in progress #16494 kept: both tracks bright with words when CI and review are both running (new node test); never icon-only.

Tests

  • Go: TestStageTrackerAdoptedRowRewordsHumanDecision (adopted / fixing / needs-human / hold / 085 / old head); rows fixture in stage_tracker_ui_rows_test.go (adopted row + parked row); prelude now lifts stageTrackerTrackWord + helper.
  • Node: stage_tracker_remediation_chevron.test.js adopted-row shapes (decided / changes / approved / CI done) and both-running.
  • cd src && go test ./pkg/dashboard/ green (full package); make dashboard-gen && make dashboard-gen-check clean; gofmt/vet clean.

Changelog: changelog.d/fixed-review-chevron-amber.md.

…hen adopted

A complete review verdict (5/5) parked on a human decision wore the amber
in-progress fill and kept saying "awaiting human decision" even after the
hive adopted the PR back into PR in progress.

- JS: a settled human_decision track is done-style + muted (.decided); amber
  only while perspectives are running (a.active). CI unchanged: passed is done.
- JS/Go: with the hive on the repair (074 adopted, 07x fix stages, no
  needs-human/hold/085) a human_decision verdict reads "changes requested";
  the decision question and provenance ride in detail/source.
- Tests: Go per-stage table, node shapes (adopted / parked / approved /
  both-running #16494), rows fixture; prelude now lifts stageTrackerTrackWord.

Fixes #16531

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 4, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16492 ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#16514 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#16500 ✨ feat(dashboard): replace Matrix presentation with Code activity same files src/pkg/dashboard/static/index.html
#16513 ✨ feat(dashboard): feed published checkpoint diff regions to Code activity same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html

@hivecommons-hive
hivecommons-hive Bot merged commit 218785a into v5 Nov 4, 2026
85 of 89 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/review-chevron-amber branch November 4, 2026 03:56
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#165321407a2c` sha256:1081c2b7c238da3dad5dfb57afb6a969cdedb763dc2809cc8187fade7838c97d — download from the dashboard or `hivectl review evidence #16532`.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 1407a2c.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness review (read at head 1407a2c; diff plus stage_tracker_remediation.go, stage_tracker_activity.go, stage_tracker_build.go, tracker-row-strip.js). No in-scope blocker; two advisories.

  1. Undisclosed behaviour change on already-red 074 rows, untested through the real entry point — stage_tracker_remediation.go:288-291. The new if out.State == "adopted" { return } runs for every red 074 row, not just the rewritten human_decision one. Before this PR a 074 row with a genuine changes_requested verdict or failing CI and no pickup evidence fell to the default branch (:323-338) and read Changes requested · unassigned · next: <fixer>; now it keeps Adopted repair · activity unknown. That is probably the right word for an adopted row, but the PR body doesn't list it and TestStageTrackerAdoptedRowRewordsHumanDecision calls stageTrackerAdoptHumanDecision directly, so nothing exercises stageTrackerApplyRemediation on a 074 row at all (neither the new red-via-rewrite path nor the changed pre-existing one). Suggest one table case through the real function:

    +func TestStageTrackerApplyRemediationAdoptedKeepsStageWord(t *testing.T) {
    +	now := time.Now()
    +	for _, state := range []string{"human_decision", "changes_requested"} {
    +		it := &StageTrackerItem{Repo: "org/repo", Kind: "pr", Number: 9, Head: "abc", Stage: trackerNumberAdopted,
    +			CodeActivity:   &StageTrackerActivity{Head: "abc", State: "adopted", Caption: "Adopted repair · activity unknown", Source: "native-adoption"},
    +			ReviewActivity: &StageTrackerActivity{Head: "abc", State: state, Since: timePtr(now.Add(-time.Hour))}}
    +		stageTrackerApplyRemediation(it, review.DispatchState{}, nil, "fixer", now)
    +		if it.CodeActivity.State != "adopted" || it.ReviewActivity.State != "changes_requested" {
    +			t.Fatalf("%s: adopted row lost its stage word or verdict: %+v %+v", state, it.CodeActivity, it.ReviewActivity)
    +		}
    +	}
    +}
  2. JS fallback treats unassigned as "hive owns the repair" — tracker-row-strip.js:91-96 (and the generated copy in static/index.html). codeStateUnassigned is emitted when there is no pickup evidence (stage_tracker_remediation.go:323-338), and for a human-authored PR the word is next: @author (stageTrackerNextRemediator, :216-226), so nobody from the hive owns it. On a non-adopted row with failing CI and a human_decision verdict the client would therefore say changes requested where the Go side still says human_decision. Low impact since Go is authoritative and the two can only disagree when the server is older than the client, but the list is misnamed as written:

          const hive = code && code.head === item.head && ['adopted', 'remediating', 'fix_pushed', 'fixing'].includes(code.state);
    

Not verified: mobile-shots fails on this head on tracker-header-geometry across all viewports; this PR only adds a .done.decided rule, so it looks unrelated to the diff, but I could not confirm the base-branch status.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Review chevron stays amber and says awaiting human after the hive adopts a PR

1 participant