Repository navigation
✨ feat: Activity Monitor am.* URL filter state and attended display mode - #15948
Conversation
…attended display mode Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
CI triage — The arm64 hub image build failed before any code in this PR was compiled:
Log: https://github.com/hivecommons/hive/actions/runs/41162396044/job/124422629634 Not pushing a no-op commit; a re-run of the failed job should pass once the mirror serves the layer. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Read the full source diff (boot.js, layout.js, sections.js, tracker-filter-state.js, tracker-popout.js, popout.css) plus the helpers it leans on (tracker-filter.js:141-155 stageTrackerNormalizeFilter, tracker-words-stage.js:91-101 groups/default filter) at head 8175f8d. The URL-view and display-mode logic checks out: every am.* value goes through stageTrackerNormalizeFilter, stageTrackerSaveFilter/stageTrackerSetGroup short-circuit to the in-memory view so localStorage is never written when an am.* key is present, stageTrackerViewUrl strips token/access_token and userinfo, kiosk wins over display in boot.js, and setLayout/dashboardLayoutWrite are guarded in display mode. The new d hotkey has no collision (no other key === 'd' handler under static-src/js), and the capture-phase stopPropagation correctly starves row-action handlers regardless of where they are attached.
One CI failure is caused by this diff — Dashboard helper tests (build-and-test). stage_tracker_popout.test.js:114 and :116 assert the exact old rule text:
html body.popout-mode #oc-topbar[id], html body.ham-fullscreen #oc-topbar[id] { display: none !important; }body.ham-fullscreen #hive-dashboard-root > [data-dashboard-section]:not(#activity-monitor-section) { display: none !important; }
popout.css:24-25 and :27-28 now split those selectors across a line and append html body.display-mode … / body.display-mode … before the declaration, so neither string occurs in the generated index.html and the test fails at the first (missing CSS rule: html body.popout-mode #oc-topbar[id], …). Update both expected strings to the new wording (or assert on the display-mode variant you added in stage_tracker_display.test.js) and that shard goes green. The build-hub (linux/arm64) red is a cancelled/in-progress Docker job, not this diff.
Non-blocking observation: STAGE_TRACKER_URL_KEYS (tracker-filter-state.js:7) omits size, so a shared link reproduces the filter but not the page size; fine if intentional, worth a note in activity-monitor.md if so.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from The red Why CI is red (reproduced locally on
|
…g is open The display-mode Esc listener only exempted the settings overlay, so Esc on an open merged/queue popover or hive dialog reloaded out of display mode and dropped session-only am.* edits. The listener now skips whenever any tracker popover, settings/labels dialog or hive dialog is open, and the merged and queue popover closers claim Esc with preventDefault. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
…l matches The display-mode selector was folded into the popout/fullscreen topbar rule, which broke the exact-string check in stage_tracker_popout.test.js. Give display mode its own rule instead. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
…test Same cause as the topbar rule: folding display-mode into the shared popout/fullscreen selector broke the exact-string check in stage_tracker_popout.test.js. Give display mode its own rule. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Read the filter-state, boot, layout and popout sources at the head and the helpers they call. Looks correct to me and stays inside the #15924 / #15925 decision constraints.
- No-
am.*path is unchanged.stageTrackerUrlView()memoisesnullwhen noam.*key is present (tracker-filter-state.js:55-61), and every new branch instageTrackerLoadFilter/SaveFilter/GroupSetting/SetGroupisif (view) …before the originallocalStoragecode (:63-74,:85-96). The?filter=waiting-on-youone-shot still flows throughstageTrackerLoadFilter+SaveFilter(tracker-waiting.js:116-123), so in a URL view it stays session-only rather than persisting. - Validation is reused, not duplicated. URL values go through
stageTrackerNormalizeFilter(tracker-filter.js:141-160); the doc table's values foram.age/am.author/am.acted/am.sortmatchSTAGE_TRACKER_AGE_MS, theauthorlist,STAGE_TRACKER_ACTED_FILTERSandSTAGE_TRACKER_SORTS.am.labelsare lowercased by normalize, consistent with the stored filter. stageTrackerViewUrlhas no production caller yet — onlystage_tracker_url_view.test.js. That is per #15924 ("the base that … Copy display link … build on"), so not a gap; flagging so nobody reads it as dead code.- Display mode is presentation only.
boot.js:30-32gives kiosk precedence (HIVE_DISPLAY=display&&!kiosk);layout.js:61and:237short-circuitlocalStoragewrites for layout/theme in display mode;toggleStageTrackerDisplayonly doeslocation.assign(tracker-popout.js:215-219); norequestFullscreen/wakeLock, andkiosk_mode_test.gopins that. - Esc ordering. The merged/queue popovers now
preventDefault()on Esc (tracker-merged.js:751,tracker-queue.js:151) and the display handler bails ondefaultPreventedand onstageTrackerDisplayOverlayOpen(tracker-popout.js:193-213), so an open overlay never triggers the reload that would drop session-only edits. Thedhotkey mirrors the existingfgate (:133-152): bare key, not typing, focus in tracker.
Nothing to request. Pending checks are the arm64 build and tide.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Why
RFC #15860 by @hanthor asks for a wall-screen Activity Monitor that is easy to reach and easy to leave. Today a view can't be shared: the filter lives only in one browser's
localStorage, so a link opened in a fresh profile shows a different list. Two screens on the same profile also overwrite each other's saved filter. Kiosk mode (?kiosk=1) is the only chrome-less view, but it is built for the headless streamer: it hides the cursor and every control, so an attended screen can't use it without changing what the stream renders.am.*URL views ([scanner] Describe Activity Monitor filters in am.* URL parameters #15924). A link now fully describes the view, so it shows the same list anywhere. When anyam.*parameter is present, the tab keeps its filter in memory and never writes it tolocalStorage, so screens on one profile no longer overwrite each other. Values go through the existingstageTrackerNormalizeFilter, and nothing changes when noam.*parameter is present. Presets are URL-only, per the maintainer decision.waitingOnYouis per-user, so it stays on?filter=waiting-on-you.?display=1reuses the pop-out/full-screen layout for an attended screen. It keeps the cursor and the user's sound setting, hides row actions, and is left withEscord. It is presentation only: it grants nothing, adds no credential, never callsrequestFullscreenornavigator.wakeLock, and never writes theme or layout tolocalStorage. Kiosk wins when both flags are present, and kiosk still hides every header tool, so the streamer's output does not change.static/index.htmlis regenerated withgo generate ./pkg/dashboard/webstatic. Tests: newstage_tracker_url_view.test.jsandstage_tracker_display.test.js(node:test, lifting helpers from the shipped index.html), plusTestDisplayModeWiring.stage_tracker_repo_grouping_test.gonow lifts the newstageTrackerUrlViewdependency. Nothing was run locally; CI decides.Closes #15924
Closes #15925
Part of #15860
cc @hanthor
— hive: agent=scanner backend=copilot requested_by=@clubanderson