Skip to content

✨ feat: Activity Monitor am.* URL filter state and attended display mode - #15948

Merged
hivecommons-hive[bot] merged 4 commits into
v5from
scanner/fix-15924
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 4 commits into
v5from
scanner/fix-15924

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Why

RFC #15860 by @hanthor asks for a wall-screen Activity Monitor that is easy to reach and easy to leave. Today a view can't be shared: the filter lives only in one browser's localStorage, so a link opened in a fresh profile shows a different list. Two screens on the same profile also overwrite each other's saved filter. Kiosk mode (?kiosk=1) is the only chrome-less view, but it is built for the headless streamer: it hides the cursor and every control, so an attended screen can't use it without changing what the stream renders.

  • am.* URL views ([scanner] Describe Activity Monitor filters in am.* URL parameters #15924). A link now fully describes the view, so it shows the same list anywhere. When any am.* parameter is present, the tab keeps its filter in memory and never writes it to localStorage, so screens on one profile no longer overwrite each other. Values go through the existing stageTrackerNormalizeFilter, and nothing changes when no am.* parameter is present. Presets are URL-only, per the maintainer decision. waitingOnYou is per-user, so it stays on ?filter=waiting-on-you.
  • Attended display mode ([scanner] Add attended ?display=1 mode with a 📺 header button to the Activity Monitor #15925). The 📺 header button or ?display=1 reuses the pop-out/full-screen layout for an attended screen. It keeps the cursor and the user's sound setting, hides row actions, and is left with Esc or d. It is presentation only: it grants nothing, adds no credential, never calls requestFullscreen or navigator.wakeLock, and never writes theme or layout to localStorage. Kiosk wins when both flags are present, and kiosk still hides every header tool, so the streamer's output does not change.

static/index.html is regenerated with go generate ./pkg/dashboard/webstatic. Tests: new stage_tracker_url_view.test.js and stage_tracker_display.test.js (node:test, lifting helpers from the shipped index.html), plus TestDisplayModeWiring. stage_tracker_repo_grouping_test.go now lifts the new stageTrackerUrlView dependency. Nothing was run locally; CI decides.

Closes #15924
Closes #15925
Part of #15860

cc @hanthor

— hive: agent=scanner backend=copilot requested_by=@clubanderson

…attended display mode

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 31, 2026
@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15871 🐛 fix: stage tracker gives immediate Let-hive-decide feedback and says why a human is wanted same files src/docs/dashboard-sections/activity-monitor.md
src/pkg/dashboard/static/index.html
#15849 ✨ Show online ClankeR IDs on the Contributors count pill same files src/pkg/dashboard/static/index.html
#15958 ✨ feat: execute bounded integration candidates with protected promotion authority same files src/pkg/dashboard/static/index.html
#15890 🐛 dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static-src/js/sections.js
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

CI triage — build-hub (linux/arm64, true, true, 75): infrastructure failure, DEFER

The arm64 hub image build failed before any code in this PR was compiled:

#6 [builder 1/6] FROM mirror.gcr.io/library/golang:1.27-alpine@sha256:f2c872bc…
#9 [builder 2/6] RUN apk add --no-cache git
#9 ERROR: failed to copy: httpReadSeeker: failed open: could not fetch content descriptor
   sha256:4f4fb700ef54461cfa02571ae0db9a0dc1e0cdb5577484a6d75e68dc38e8acc1 from remote: not found

mirror.gcr.io returned 404 for a base-image layer blob of golang:1.27-alpine while buildx was pulling it under QEMU. This PR changes only dashboard JS/CSS, docs, and tests (no Dockerfile, workflow, or Go dependency changes), so it cannot have caused a registry blob fetch failure. The other build-hub matrix legs on the same run were unaffected.

Log: https://github.com/hivecommons/hive/actions/runs/41162396044/job/124422629634

Not pushing a no-op commit; a re-run of the failed job should pass once the mirror serves the layer.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the full source diff (boot.js, layout.js, sections.js, tracker-filter-state.js, tracker-popout.js, popout.css) plus the helpers it leans on (tracker-filter.js:141-155 stageTrackerNormalizeFilter, tracker-words-stage.js:91-101 groups/default filter) at head 8175f8d. The URL-view and display-mode logic checks out: every am.* value goes through stageTrackerNormalizeFilter, stageTrackerSaveFilter/stageTrackerSetGroup short-circuit to the in-memory view so localStorage is never written when an am.* key is present, stageTrackerViewUrl strips token/access_token and userinfo, kiosk wins over display in boot.js, and setLayout/dashboardLayoutWrite are guarded in display mode. The new d hotkey has no collision (no other key === 'd' handler under static-src/js), and the capture-phase stopPropagation correctly starves row-action handlers regardless of where they are attached.

One CI failure is caused by this diff — Dashboard helper tests (build-and-test). stage_tracker_popout.test.js:114 and :116 assert the exact old rule text:

  • html body.popout-mode #oc-topbar[id], html body.ham-fullscreen #oc-topbar[id] { display: none !important; }
  • body.ham-fullscreen #hive-dashboard-root > [data-dashboard-section]:not(#activity-monitor-section) { display: none !important; }

popout.css:24-25 and :27-28 now split those selectors across a line and append html body.display-mode … / body.display-mode … before the declaration, so neither string occurs in the generated index.html and the test fails at the first (missing CSS rule: html body.popout-mode #oc-topbar[id], …). Update both expected strings to the new wording (or assert on the display-mode variant you added in stage_tracker_display.test.js) and that shard goes green. The build-hub (linux/arm64) red is a cancelled/in-progress Docker job, not this diff.

Non-blocking observation: STAGE_TRACKER_URL_KEYS (tracker-filter-state.js:7) omits size, so a shared link reproduces the filter but not the page size; fine if intentional, worth a note in activity-monitor.md if so.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

The red build-and-test check is caused by this diff: the popout.css reflow breaks two literal-string assertions in an existing test. The feature logic itself reads correctly to me.

Why CI is red (reproduced locally on d7c7fdb)

src/pkg/dashboard/stage_tracker_popout.test.js:115-118 asserts that these exact strings appear in static/index.html:

  • html body.popout-mode #oc-topbar[id], html body.ham-fullscreen #oc-topbar[id] { display: none !important; }
  • body.ham-fullscreen #hive-dashboard-root > [data-dashboard-section]:not(#activity-monitor-section) { display: none !important; }

This PR appends ,\n body.display-mode … to both selector lists in src/pkg/dashboard/static-src/css/popout.css (the #oc-topbar[id] rule and the [data-dashboard-section] rule), so the { display: none !important; } tail now follows the new body.display-mode selector and neither literal matches (grep -cF → 0 for both). node --test stage_tracker_popout.test.js fails at :119 with missing CSS rule: html body.popout-mode #oc-topbar[id] …; the other 7 tests in that file and the two new files pass.

Smallest fix, and the one that keeps the shipped rule text stable: leave the two existing rules untouched and add body.display-mode as separate rules below them (the file already does this for the display-only .ham-row-tools block at the end). Alternatively update the two literals in the test — but then the test no longer pins the pop-out/full-screen rules on their own. Regenerate index.html after either change.

What I checked and found correct

  • stageTrackerFilterFromUrl / stageTrackerViewUrl (static-src/js/tracker-filter-state.js) round-trip cleanly: every boolean in stageTrackerDefaultFilter() (tracker-words-stage.js:101) defaults to false, so emitting =1 only when the value differs from the default is lossless; am.group alone counts as an am.* view; am.* and token/access_token are stripped before re-emitting.
  • The session-only view object is consulted in all four persistence paths (stageTrackerLoadFilter, stageTrackerSaveFilter, stageTrackerGroupSetting, stageTrackerSetGroup), so localStorage is never written while an am.* view is active.
  • stageTrackerDisplayHotkey (tracker-popout.js) refuses while typing, with modifiers, with an overlay open, or with document.fullscreenElement set; the new e.preventDefault() in the merged/queue Esc handlers (tracker-merged.js:751, tracker-queue.js:151) is what the if (e.defaultPrevented) return guard relies on — consistent.
  • boot.js: HIVE_DISPLAY = display && !kiosk, so kiosk wins as the body states; setLayout and dashboardLayoutWrite early-return in display mode, matching "never writes theme or layout".

Review findings from adjudicator-3 (folded here because this head already carries its hive review):

docs-currency (read at head d7c7fdb): the am.* grammar table in src/docs/streaming-the-activity-monitor.md matches the code enums (STAGE_TRACKER_AGE_MS, STAGE_TRACKER_SORTS, STAGE_TRACKER_ACTED_FILTERS, STAGE_TRACKER_GROUPS), and the section, private-repo warning and changelog fragment #15924 asked for are all present. One wording inaccuracy, non-blocking:

  • src/docs/dashboard-sections/activity-monitor.md:128 says 📺 reloads with ?display=1 added and "any other query, such as am.* or theme, is kept". stageTrackerDisplayUrl in src/pkg/dashboard/static-src/js/tracker-popout.js (the if (on) branch) also deletes kiosk and the one-shot filter param and replaces the hash with #section-activity-monitor-section. Suggest: "any other query, such as am.* or theme, is kept; ?kiosk=1 and the one-shot ?filter=waiting-on-you are dropped".

…g is open

The display-mode Esc listener only exempted the settings overlay, so Esc on
an open merged/queue popover or hive dialog reloaded out of display mode and
dropped session-only am.* edits. The listener now skips whenever any tracker
popover, settings/labels dialog or hive dialog is open, and the merged and
queue popover closers claim Esc with preventDefault.

Hive-Fix-Attempt: 1/6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 31, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot removed the stage/050-review-pending Review swarm requested; awaiting a verdict for the current head label Oct 31, 2026
@hivecommons-hive hivecommons-hive Bot added the stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it label Oct 31, 2026
…l matches

The display-mode selector was folded into the popout/fullscreen topbar
rule, which broke the exact-string check in stage_tracker_popout.test.js.
Give display mode its own rule instead.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
…test

Same cause as the topbar rule: folding display-mode into the shared
popout/fullscreen selector broke the exact-string check in
stage_tracker_popout.test.js. Give display mode its own rule.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 31, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the filter-state, boot, layout and popout sources at the head and the helpers they call. Looks correct to me and stays inside the #15924 / #15925 decision constraints.

  • No-am.* path is unchanged. stageTrackerUrlView() memoises null when no am.* key is present (tracker-filter-state.js:55-61), and every new branch in stageTrackerLoadFilter / SaveFilter / GroupSetting / SetGroup is if (view) … before the original localStorage code (:63-74, :85-96). The ?filter=waiting-on-you one-shot still flows through stageTrackerLoadFilter + SaveFilter (tracker-waiting.js:116-123), so in a URL view it stays session-only rather than persisting.
  • Validation is reused, not duplicated. URL values go through stageTrackerNormalizeFilter (tracker-filter.js:141-160); the doc table's values for am.age/am.author/am.acted/am.sort match STAGE_TRACKER_AGE_MS, the author list, STAGE_TRACKER_ACTED_FILTERS and STAGE_TRACKER_SORTS. am.labels are lowercased by normalize, consistent with the stored filter.
  • stageTrackerViewUrl has no production caller yet — only stage_tracker_url_view.test.js. That is per #15924 ("the base that … Copy display link … build on"), so not a gap; flagging so nobody reads it as dead code.
  • Display mode is presentation only. boot.js:30-32 gives kiosk precedence (HIVE_DISPLAY=display&&!kiosk); layout.js:61 and :237 short-circuit localStorage writes for layout/theme in display mode; toggleStageTrackerDisplay only does location.assign (tracker-popout.js:215-219); no requestFullscreen/wakeLock, and kiosk_mode_test.go pins that.
  • Esc ordering. The merged/queue popovers now preventDefault() on Esc (tracker-merged.js:751, tracker-queue.js:151) and the display handler bails on defaultPrevented and on stageTrackerDisplayOverlayOpen (tracker-popout.js:193-213), so an open overlay never triggers the reload that would drop session-only edits. The d hotkey mirrors the existing f gate (:133-152): bare key, not typing, focus in tracker.

Nothing to request. Pending checks are the arm64 build and tide.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit ceafe3f into v5 Oct 31, 2026
84 of 87 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15924 branch October 31, 2026 04:29
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#15948ed0e091` sha256:8f7c3af124092e403284ed8dc74d19fccaea809409e28001ef1c086d7fa3dab3 — download from the dashboard or `hivectl review evidence #15948`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

0 participants