Repository navigation
π fix: show running fleet costs below the count without truncation - #15914
Conversation
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
/lgtm Owner-authorized focused Activity Monitor layout fix. Reviewed source/generated parity and existing rotor accessibility/reduced-motion preservation. Waiting for the full applicable CI matrix at exact head 9f6192c before guarded squash merge; no production deployment. |
|
@clubanderson: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
docs-currency β read head 9f6192c. Code, CSS comments, test header and the new fragment all describe the new column layout consistently; --sp-1 / --fs-sm tokens the new CSS uses are defined (src/pkg/dashboard/static/index.html:45,4045). One advisory:
Unreleased fragments still describe the layout this PR removes. Both earlier fragments are still in changelog.d/ at this head and src/scripts/compile-changelog.sh folds every fragment into the same ## Unreleased block at release time (changelog.d/README.md), so the release notes will say the tile "never wraps" / "ellipsizes" and, two bullets later, that it wraps and never clips:
changelog.d/added-15614-running-cost-rotor.md:1β "agent count fixed, width reserved so the tile never wraps"changelog.d/fixed-15826-running-tile-stray-dot.md:1β "The tile is now a flex row whose rotor shrinks and ellipsizes on its own"
Suggested trims so the three bullets read as one story:
--- a/changelog.d/added-15614-running-cost-rotor.md
+++ b/changelog.d/added-15614-running-cost-rotor.md
-- The dashboard's RUNNING tile now rotates its fleet spend through `$X this hour` β `$Y today` β `$Z this week` β `$W this month` (~4 s each, a quiet vertical crossfade of just the amount and window, agent count fixed, width reserved so the tile never wraps; pauses on hover and while the tab is hidden, instant under reduced motion, hover lists all four), ...
+- The dashboard's RUNNING tile now rotates its fleet spend through `$X this hour` β `$Y today` β `$Z this week` β `$W this month` (~4 s each, a quiet vertical crossfade of just the amount and window, agent count fixed; pauses on hover and while the tab is hidden, instant under reduced motion, hover lists all four), ...
--- a/changelog.d/fixed-15826-running-tile-stray-dot.md
+++ b/changelog.d/fixed-15826-running-tile-stray-dot.md
-... The tile is now a flex row whose rotor shrinks and ellipsizes on its own, window labels are shorter ("this hr", "today", "this wk", "this mo"), ...
+... Window labels are shorter ("this hr", "today", "this wk", "this mo"), ...Not blocking; approving from this perspective.
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Style review (head 9f6192c) β approve with one advisory.
(Apply the same in Minor: Not in scope but filed: the |
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
Summary
Validation
make dashboard-genregenerated the committed SPA.