Skip to content

πŸ› fix: show running fleet costs below the count without truncation - #15914

Merged
clubanderson merged 1 commit into
v5from
fix/running-cost-layout
Oct 31, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/running-cost-layout

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

  • Keep the running count on its own line and show fleet cost plus its existing rotating period below it.
  • Let long currency amounts and period text wrap at narrow widths or browser zoom instead of ellipsizing; retain amber period styling, tooltips, hover pause and reduced-motion behavior.
  • Preserve accounting, formatting and the existing this hr / today / this wk / this mo windows.
  • Regenerate the served SPA and update the existing CI render/layout regression for large costs and both running tiles.

Validation

  • Per AGENTS.md no local tests, builds, lint or docs guards were run; CI is the verdict.
  • make dashboard-gen regenerated the committed SPA.
  • No production deployment or configuration changes.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2026
@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15853 ✨ Complete native GitHub queue CI and policy integration same files src/pkg/dashboard/static/index.html
#15913 ✨ Expose Event triggers in Settings with scoped scanner presets same files src/pkg/dashboard/static/index.html
#15871 πŸ› fix: stage tracker gives immediate Let-hive-decide feedback and says why a human is wanted same files src/pkg/dashboard/static/index.html
#15849 ✨ Show online ClankeR IDs on the Contributors count pill same files src/pkg/dashboard/static/index.html
#15890 πŸ› dashboard: point operator-reference help marks at the section sub-pages same files src/pkg/dashboard/static/index.html

@clubanderson

Copy link
Copy Markdown
Member Author

/lgtm
/approve

Owner-authorized focused Activity Monitor layout fix. Reviewed source/generated parity and existing rotor accessibility/reduced-motion preservation. Waiting for the full applicable CI matrix at exact head 9f6192c before guarded squash merge; no production deployment.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@clubanderson: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

Owner-authorized focused Activity Monitor layout fix. Reviewed source/generated parity and existing rotor accessibility/reduced-motion preservation. Waiting for the full applicable CI matrix at exact head 9f6192c before guarded squash merge; no production deployment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2026
@clubanderson
clubanderson merged commit a926ee6 into v5 Oct 31, 2026
84 of 87 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/running-cost-layout branch October 31, 2026 01:47
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency β€” read head 9f6192c. Code, CSS comments, test header and the new fragment all describe the new column layout consistently; --sp-1 / --fs-sm tokens the new CSS uses are defined (src/pkg/dashboard/static/index.html:45,4045). One advisory:

Unreleased fragments still describe the layout this PR removes. Both earlier fragments are still in changelog.d/ at this head and src/scripts/compile-changelog.sh folds every fragment into the same ## Unreleased block at release time (changelog.d/README.md), so the release notes will say the tile "never wraps" / "ellipsizes" and, two bullets later, that it wraps and never clips:

  • changelog.d/added-15614-running-cost-rotor.md:1 β€” "agent count fixed, width reserved so the tile never wraps"
  • changelog.d/fixed-15826-running-tile-stray-dot.md:1 β€” "The tile is now a flex row whose rotor shrinks and ellipsizes on its own"

Suggested trims so the three bullets read as one story:

--- a/changelog.d/added-15614-running-cost-rotor.md
+++ b/changelog.d/added-15614-running-cost-rotor.md
-- The dashboard's RUNNING tile now rotates its fleet spend through `$X this hour` β†’ `$Y today` β†’ `$Z this week` β†’ `$W this month` (~4 s each, a quiet vertical crossfade of just the amount and window, agent count fixed, width reserved so the tile never wraps; pauses on hover and while the tab is hidden, instant under reduced motion, hover lists all four), ...
+- The dashboard's RUNNING tile now rotates its fleet spend through `$X this hour` β†’ `$Y today` β†’ `$Z this week` β†’ `$W this month` (~4 s each, a quiet vertical crossfade of just the amount and window, agent count fixed; pauses on hover and while the tab is hidden, instant under reduced motion, hover lists all four), ...
--- a/changelog.d/fixed-15826-running-tile-stray-dot.md
+++ b/changelog.d/fixed-15826-running-tile-stray-dot.md
-... The tile is now a flex row whose rotor shrinks and ellipsizes on its own, window labels are shorter ("this hr", "today", "this wk", "this mo"), ...
+... Window labels are shorter ("this hr", "today", "this wk", "this mo"), ...

Not blocking; approving from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from adjudicator-2 (folded here because this head already carries its hive review):

Style review (head 9f6192c) β€” approve with one advisory.

gap: var(--sp-1) resolves to nothing on the Governor tile β€” src/pkg/dashboard/static-src/css/governor.css:24 (built: static/index.html:2289). The --sp-* spacing tokens are declared only on .config-modal (static/index.html:4039 β†’ :4049), not on :root; the running tile lives in .gov-grid (static/index.html:26703), outside any modal, so the var is invalid-at-computed-value and gap falls back to normal (0). The layout still works (count and cost stack with no spacing), but the token is doing nothing. The rest of the rule uses real root tokens (--fs-sm, --text, --amber), so this is the only dead reference the PR adds.

    .fleet-run-stat .val, .fleet-run-stat .gm-val { display: flex; flex-direction: column; align-items: stretch; gap: var(--sp-1, 2px); white-space: normal; overflow: visible; min-width: 0; }

(Apply the same in static/index.html:2289, or re-run make dashboard-gen.)

Minor: src/pkg/dashboard/webstatic/fleet_run_stat_test.go:10 still describes the figure as "running N Β· $X this hour" β€” the Β· separator is removed by this PR (agent-now.js:342,348); worth a one-word comment refresh while you're here.

Not in scope but filed: the --sp-* ramp being scoped to .config-modal affects ~300 var(--sp-*) usages outside the modal across static-src/css/*.css.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant