Skip to content

[reviewer] Review backlog (style): --sp-* spacing tokens are declared only on .config-modal, not :root #15920

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #15914.

PR: #15914 (#15914)
Perspective: style
Severity: low (P3)
Evidence: src/pkg/dashboard/static-src/css/config-dialog.css:70 (

--sp-0: 0; --sp-1: 2px; --sp-2: 4px; --sp-3: 6px; --sp-4: 8px;
)
Finding: --sp-* spacing tokens are declared only on .config-modal, not :root

The --sp-0..--sp-9 ramp is defined inside the .config-modal rule (config-dialog.css:70; built index.html:4049) while base.css :root (base.css:21 --modal-gap: var(--sp-8)) and ~300 var(--sp-) usages across static-src/css/.css (e.g. advisory-lifecycle.css:4,15,22) sit outside the modal and silently resolve to invalid/initial. Pre-existing; hoist the ramp to :root in base.css.

Fingerprint: d916babfb3b0ea118d73c0c946c0e072675b9c046b3b1215857e80e22c9ab115

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  2. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  3. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

  4. added
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    and removed on Oct 31, 2026
  5. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #15923 (#15923, merged). Closing because Hive's PR claim metadata says this PR was the full fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions