Skip to content

Review backlog (style): Prior correctness note still present: head-commit fetch precedes the compare #15630

Closed

Description

@hivecommons-hive

Blocked on PR #15621. This finding came from reviewing PR #15621 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15621.

PR: #15621 (#15621)
Perspective: style
Severity: info (P3)
Evidence: src/pkg/github/pr_empty_diff_hive_autoclose.go:201 (

facts.HeadAge = emptyDiffHeadAge(pr, c.headCommitTime(ctx, owner, name, pr), time.Now())
)
Finding: Prior correctness note still present: head-commit fetch precedes the compare

Re-check of the previous review's finding at head 1e73950: src/pkg/github/pr_empty_diff_hive_autoclose.go:201 still calls c.headCommitTime (one GetCommit REST call) before prDiffAgainstBase at :203 proves the diff empty, so a hive PR that passes the cheap guards but has a real diff pays one extra call. Unchanged since the previously approved head; it was advisory then and remains advisory. Not a style concern.

Fingerprint: bc8f53df59b46819c260f108c02b124efc5bdf120d5582ec21718e57e7359f2d

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  2. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #15603: both cite src/pkg/github/pr_empty_diff_hive_autoclose.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  5. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive lifted the blocked label it applied on 2026-10-30T02:50:03Z: #15680 merged since, so the reason for the park no longer holds and the issue is back in the normal flow. Labels applied by a human are never lifted by this sweep (#12002).

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  7. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15621 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions