You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (style): Prior correctness note still present: head-commit fetch precedes the compare #15630
Blocked on PR #15621. This finding came from reviewing PR #15621 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15621.
)
Finding: Prior correctness note still present: head-commit fetch precedes the compare
Re-check of the previous review's finding at head 1e73950: src/pkg/github/pr_empty_diff_hive_autoclose.go:201 still calls c.headCommitTime (one GetCommit REST call) before prDiffAgainstBase at :203 proves the diff empty, so a hive PR that passes the cheap guards but has a real diff pays one extra call. Unchanged since the previously approved head; it was advisory then and remains advisory. Not a style concern.
Same file as #15603: both cite src/pkg/github/pr_empty_diff_hive_autoclose.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.
Hive lifted the blocked label it applied on 2026-10-30T02:50:03Z: #15680 merged since, so the reason for the park no longer holds and the issue is back in the normal flow. Labels applied by a human are never lifted by this sweep (#12002).
Unblocked: #15621 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Oct 30, 2026
Same file as #15603: both cite
src/pkg/github/pr_empty_diff_hive_autoclose.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Oct 30, 2026
Hive lifted the
blockedlabel it applied on 2026-10-30T02:50:03Z: #15680 merged since, so the reason for the park no longer holds and the issue is back in the normal flow. Labels applied by a human are never lifted by this sweep (#12002).hivecommons-hive commentedon Oct 30, 2026
Unblocked: #15621 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.