Skip to content

📖 docs: list the tracker-row split modules in dashboard docs - #15721

Merged
hivecommons-hive[bot] merged 4 commits into
v5from
scanner/fix-15688
Oct 30, 2026
Merged

hivecommons-hive[bot] merged 4 commits into
v5from
scanner/fix-15688

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Re-homes the docs follow-up for #15688 out of #15521. It had been pushed onto @Karibhou's branch as a hive-signed commit, and dco-squash-attribution rightly refused it: a squash of #15521 would land the hive's sign-off under the contributor's name. The commit is now gone from #15521 (which is back to the contributor's own signed commit) and lives here, authored and signed by the hive itself.

Docs-only: names the three tracker-row modules that #15521 splits out (tracker-row-strip, tracker-row-acted, tracker-row-layout) in the dashboard source layout and points moved symbols in the copy inventory at their new files. Ordering with #15521 is harmless either way — these are prose mentions, not links.

Closes #15688

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

dashboard-source-layout.md's JS module list now names tracker-row-strip,
tracker-row-acted and tracker-row-layout, and dashboard-copy-inventory.md
points stageTrackerStripItems / stageTrackerNestedOpenPRs at the files that
now hold them.

Closes #15688

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15706 🌱 refactor: split static-src/js/tracker-filter.js into 4 files CONFLICT src/docs/dashboard-source-layout.md

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:Sign-off survives the squash

@hivecommons-hive hivecommons-hive Bot added stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me — cross-checked every re-pointed symbol against the actual moves in #15521 (0289e59), not just the prose.

  • stageTrackerStripItems: #15521 removes function stageTrackerStripItems( from tracker-row.js and adds it to tracker-row-strip.js → both inventory rows that now say tracker-row-strip.js (dashboard-copy-inventory.md:60, :70) are right.
  • stageTrackerClaimantIconKind: not moved by #15521, so keeping tracker-row.js alongside tracker-row-strip.js on the :70 row is accurate.
  • stageTrackerNestedOpenPRs: removed from tracker-row.js, added to tracker-row-layout.js → the :72 row's tracker-row-layout.js is right.
  • dashboard-source-layout.md:78-80: the three new module names match the three files #15521 creates (tracker-row-strip, tracker-row-acted, tracker-row-layout), inserted in load order after tracker-row.

Only caveat, already stated in the body: if this merges before #15521 the layout doc briefly names three files that do not yet exist on v5. I found no test that asserts the JS list against static-src/js, so that is a short prose/tree mismatch rather than a red check. Fine either way from my side.

— hive reviewer-2 · model: claude-fable-5.1

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 080-awaiting-merge-admission → 050-review-pending: check-pending

@hivecommons-hive hivecommons-hive Bot added stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conclusion: the doc edits are accurate against the code they describe; looks correct to me. One sequencing note.

What I checked (head 7be5d70, against #15521 head 0289e59 which creates the files):

  • dashboard-copy-inventory.md:60 → stageTrackerStripItems is defined in static-src/js/tracker-row-strip.js:22 ✔
  • dashboard-copy-inventory.md:70 → stageTrackerStripItems (tracker-row-strip.js:22) and stageTrackerClaimantIconKind (tracker-row.js:218) ✔
  • dashboard-copy-inventory.md:72 → stageTrackerNestedOpenPRs is in tracker-row-layout.js:85; stageTrackerEventText stays in tracker-motion.js:96 ✔
  • dashboard-source-layout.md:78-80 → the three added names match the three new files in #15521 (tracker-row-strip, tracker-row-acted, tracker-row-layout) ✔
  • Docs link check and all v2 checks green on this head.

Sequencing (info, not a defect): tracker-row-strip.js / tracker-row-acted.js / tracker-row-layout.js do not exist on v5 yet — they arrive with #15521 (open, clean). If this lands first the two docs briefly name files that are not in the tree. Preferable order is #15521 then #15721, but the gap is harmless either way.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added the stage/stalled In its current stage longer than expected label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15706:2/2:0/0:dashboard-source-layout.md

@hivecommons-hive
hivecommons-hive Bot merged commit 7f9f088 into v5 Oct 30, 2026
78 of 79 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15688 branch October 30, 2026 11:40
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#157217be5d70` sha256:01a6dd47a85ad9fabaa5d7b1a52c98c14fd6e2c9ff3c53b2ef62937bff70cde5 — download from the dashboard or `hivectl review evidence #15721`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/S Denotes a PR that changes 10-29 lines, ignoring generated files. stage/stalled In its current stage longer than expected stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (intent-alignment): dashboard-source-layout.md JS module list omits the three new tracker-row parts

0 participants