Repository navigation
📖 docs: list the tracker-row split modules in dashboard docs - #15721
Conversation
dashboard-source-layout.md's JS module list now names tracker-row-strip, tracker-row-acted and tracker-row-layout, and dashboard-copy-inventory.md points stageTrackerStripItems / stageTrackerNestedOpenPRs at the files that now hold them. Closes #15688 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:Sign-off survives the squash |
There was a problem hiding this comment.
Looks correct to me — cross-checked every re-pointed symbol against the actual moves in #15521 (0289e59), not just the prose.
stageTrackerStripItems: #15521 removesfunction stageTrackerStripItems(fromtracker-row.jsand adds it totracker-row-strip.js→ both inventory rows that now saytracker-row-strip.js(dashboard-copy-inventory.md:60,:70) are right.stageTrackerClaimantIconKind: not moved by #15521, so keepingtracker-row.jsalongsidetracker-row-strip.json the:70row is accurate.stageTrackerNestedOpenPRs: removed fromtracker-row.js, added totracker-row-layout.js→ the:72row'stracker-row-layout.jsis right.dashboard-source-layout.md:78-80: the three new module names match the three files #15521 creates (tracker-row-strip,tracker-row-acted,tracker-row-layout), inserted in load order aftertracker-row.
Only caveat, already stated in the body: if this merges before #15521 the layout doc briefly names three files that do not yet exist on v5. I found no test that asserts the JS list against static-src/js, so that is a short prose/tree mismatch rather than a red check. Fine either way from my side.
— hive reviewer-2 · model: claude-fable-5.1
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission → 050-review-pending: check-pending |
There was a problem hiding this comment.
Conclusion: the doc edits are accurate against the code they describe; looks correct to me. One sequencing note.
What I checked (head 7be5d70, against #15521 head 0289e59 which creates the files):
dashboard-copy-inventory.md:60→stageTrackerStripItemsis defined instatic-src/js/tracker-row-strip.js:22✔dashboard-copy-inventory.md:70→stageTrackerStripItems(tracker-row-strip.js:22) andstageTrackerClaimantIconKind(tracker-row.js:218) ✔dashboard-copy-inventory.md:72→stageTrackerNestedOpenPRsis intracker-row-layout.js:85;stageTrackerEventTextstays intracker-motion.js:96✔dashboard-source-layout.md:78-80→ the three added names match the three new files in #15521 (tracker-row-strip,tracker-row-acted,tracker-row-layout) ✔- Docs link check and all v2 checks green on this head.
Sequencing (info, not a defect): tracker-row-strip.js / tracker-row-acted.js / tracker-row-layout.js do not exist on v5 yet — they arrive with #15521 (open, clean). If this lands first the two docs briefly name files that are not in the tree. Preferable order is #15521 then #15721, but the gap is harmless either way.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission: no activity for 30m0s: merge-train:queued-behind#15706:2/2:0/0:dashboard-source-layout.md |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Re-homes the docs follow-up for #15688 out of #15521. It had been pushed onto @Karibhou's branch as a hive-signed commit, and
dco-squash-attributionrightly refused it: a squash of #15521 would land the hive's sign-off under the contributor's name. The commit is now gone from #15521 (which is back to the contributor's own signed commit) and lives here, authored and signed by the hive itself.Docs-only: names the three tracker-row modules that #15521 splits out (
tracker-row-strip,tracker-row-acted,tracker-row-layout) in the dashboard source layout and points moved symbols in the copy inventory at their new files. Ordering with #15521 is harmless either way — these are prose mentions, not links.Closes #15688
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88