Repository navigation
Conversation
β¦PRs calls stageTrackerResolveLinkedPRs gained a second open func(repo string, number int) bool parameter but TestStageTrackerLinkedPRProgressRowsAndEvents still called it with one argument, breaking the v5 build (pkg/dashboard/stage_tracker_linked_progress_test.go:95,101). Pass nil, which the function already treats as "no cross-repository vouching" (stage_tracker.go:2996). Hive-Run: hivecommons#15320 Hive-Plan: fix-v5-test-failure-15320 Hive-Spec: tests#compile-fix Signed-off-by: onkar717 <shelkeonka@gmail.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should confirm #15324 can be closed as a no-op β #15301 (2f05d8e) already landed this exact two-line fix on v5 before this PR was opened.
This change is already on v5, so merging it would be a no-op.
Verified: src/pkg/dashboard/stage_tracker_linked_progress_test.go at the current v5 tip already reads stageTrackerResolveLinkedPRs(items, nil) at lines 95 and 101 β exactly the two lines this PR changes. That came in with #15301 (merge commit 2f05d8e18, merged 2026-10-29T05:46:51Z), which touched this test file among others; this PR was opened at 05:54:06Z, eight minutes later. The diff here (06e36fc78a β 8fbfdbb58e) is also byte-identical to #15321, which is parked on the same question.
The fix itself is right: stage_tracker.go guards with open == nil || !open(...) and the test never exercises the cross-repo vouching path, so nil is the correct argument β thank you for tracking down the v5 red. There is just nothing left to land.
Flagging for a maintainer: if you agree, this one could be closed as already-fixed by #15301. I have not closed anything.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict requires_human @520092a, 58/58 checks green, DCO yes, soak 3m0s of 30m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
Needs a decision, not a merge:
Head: verdict requires_human @520092a, 58/58 checks green, DCO yes, soak 30m0s elapsed. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
/lgtm Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hivecommons-hive[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@onkar717 this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges. |
|
@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges.
|
|
Closed as superseded by #15506 by @clubanderson from the Hive dashboard. Thanks β this change already landed on v5 via #15506; closing as superseded. |
What
stageTrackerResolveLinkedPRsgained a second parameter,open func(repo string, number int) bool, but the testTestStageTrackerLinkedPRProgressRowsAndEventsinpkg/dashboard/stage_tracker_linked_progress_test.gostill called it with a single argument. That breaks compilation ofpkg/dashboardonv5, which is why the scheduled v5 test run failed on commit4536f90.Why
The real callers (
stage_tracker.go:2266,delegated_pr_context.go:45) already pass this predicate. The function's own doc comment saysopenis used only to "vouch for" a cross-repository PR missing from the snapshot, and is nil-safe (stage_tracker.go:2996:pr == nil && (open == nil || !open(...))). The test doesn't exercise that cross-repo path, sonilis the correct argument.How tested
Could not run
go build/go testwith the pinned Go toolchain in this sandbox (no network access to fetch the pinnedgo1.26.10toolchain). I temporarily lowered thegodirective ingo.mod,go.work, andcrux/go.modto the locally installedgo1.26.5(same minor version, patch-only difference) to verify the fix, then reverted those three files before committing β they carry no changes in this PR. With that local override:gofmt -lon the changed file reports no diff.No changelog fragment: the only change is to a
_test.gofile, which is exempt perCONTRIBUTING.md/AGENTS.md.Closes #15320
β hive: backend=claude model=claude-sonnet-5-5 effort=medium