Skip to content

πŸ› fix(dashboard): pass PR-open predicate to stageTrackerResolveLinkedPRs calls - #15324

Closed
onkar717 wants to merge 1 commit into
hivecommons:v5from
onkar717:fix-dashboard-linked-prs-signature
Closed

onkar717 wants to merge 1 commit into
hivecommons:v5from
onkar717:fix-dashboard-linked-prs-signature

Conversation

@onkar717

Copy link
Copy Markdown
Contributor

What

stageTrackerResolveLinkedPRs gained a second parameter, open func(repo string, number int) bool, but the test TestStageTrackerLinkedPRProgressRowsAndEvents in pkg/dashboard/stage_tracker_linked_progress_test.go still called it with a single argument. That breaks compilation of pkg/dashboard on v5, which is why the scheduled v5 test run failed on commit 4536f90.

Why

pkg/dashboard/stage_tracker_linked_progress_test.go:95:31: not enough arguments in call to stageTrackerResolveLinkedPRs
	have ([]StageTrackerItem)
	want ([]StageTrackerItem, func(repo string, number int) bool)

The real callers (stage_tracker.go:2266, delegated_pr_context.go:45) already pass this predicate. The function's own doc comment says open is used only to "vouch for" a cross-repository PR missing from the snapshot, and is nil-safe (stage_tracker.go:2996: pr == nil && (open == nil || !open(...))). The test doesn't exercise that cross-repo path, so nil is the correct argument.

How tested

Could not run go build/go test with the pinned Go toolchain in this sandbox (no network access to fetch the pinned go1.26.10 toolchain). I temporarily lowered the go directive in go.mod, go.work, and crux/go.mod to the locally installed go1.26.5 (same minor version, patch-only difference) to verify the fix, then reverted those three files before committing β€” they carry no changes in this PR. With that local override:

go test ./pkg/dashboard/...
ok  	github.com/hivecommons/hive/pkg/dashboard	165.052s
ok  	github.com/hivecommons/hive/pkg/dashboard/collect	0.139s
ok  	github.com/hivecommons/hive/pkg/dashboard/theme	0.016s
ok  	github.com/hivecommons/hive/pkg/dashboard/webstatic	24.669s

gofmt -l on the changed file reports no diff.

No changelog fragment: the only change is to a _test.go file, which is exempt per CONTRIBUTING.md/AGENTS.md.

Closes #15320

β€” hive: backend=claude model=claude-sonnet-5-5 effort=medium

…PRs calls

stageTrackerResolveLinkedPRs gained a second open func(repo string,
number int) bool parameter but TestStageTrackerLinkedPRProgressRowsAndEvents
still called it with one argument, breaking the v5 build
(pkg/dashboard/stage_tracker_linked_progress_test.go:95,101). Pass nil,
which the function already treats as "no cross-repository vouching"
(stage_tracker.go:2996).

Hive-Run: hivecommons#15320
Hive-Plan: fix-v5-test-failure-15320
Hive-Spec: tests#compile-fix
Signed-off-by: onkar717 <shelkeonka@gmail.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15647 πŸ› fix(dashboard): pass PR-open predicate to stageTrackerResolveLinkedPRs calls same files src/pkg/dashboard/stage_tracker_linked_progress_test.go

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should confirm #15324 can be closed as a no-op β€” #15301 (2f05d8e) already landed this exact two-line fix on v5 before this PR was opened.

This change is already on v5, so merging it would be a no-op.

Verified: src/pkg/dashboard/stage_tracker_linked_progress_test.go at the current v5 tip already reads stageTrackerResolveLinkedPRs(items, nil) at lines 95 and 101 β€” exactly the two lines this PR changes. That came in with #15301 (merge commit 2f05d8e18, merged 2026-10-29T05:46:51Z), which touched this test file among others; this PR was opened at 05:54:06Z, eight minutes later. The diff here (06e36fc78a β†’ 8fbfdbb58e) is also byte-identical to #15321, which is parked on the same question.

The fix itself is right: stage_tracker.go guards with open == nil || !open(...) and the test never exercises the cross-repo vouching path, so nil is the correct argument β€” thank you for tracking down the v5 red. There is just nothing left to land.

Flagging for a maintainer: if you agree, this one could be closed as already-fixed by #15301. I have not closed anything.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

Head: verdict requires_human @520092a, 58/58 checks green, DCO yes, soak 3m0s of 30m0s.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

Head: verdict requires_human @520092a, 58/58 checks green, DCO yes, soak 30m0s elapsed.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/approve

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hivecommons-hive[bot]
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@onkar717 this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch is behind the base and Hive cannot update it; enable "allow edits by maintainers" or rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges.

@hivecommons-hive hivecommons-hive Bot added the adoption/supersede Owner-delegate request: adopt now in supersede mode label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson asked the hive to adopt this pull request now, without waiting for its author's hive. The hive opens its own PR carrying the author's commits and sign-off unchanged on the pass now running; this PR closes when that copy merges.

Maintainer: fork head is not editable by the App and the author is offline β€” hive adopts and carries this to merge.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closed as superseded by #15506 by @clubanderson from the Hive dashboard.

Thanks β€” this change already landed on v5 via #15506; closing as superseded.

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tests] v5 test failure on 4536f90

1 participant