Repository navigation
🐛 fix(dashboard): pass PR-open predicate to stageTrackerResolveLinkedPRs calls - #15647
hivecommons-hive[bot] wants to merge 2 commits into
Conversation
…PRs calls stageTrackerResolveLinkedPRs gained a second open func(repo string, number int) bool parameter but TestStageTrackerLinkedPRProgressRowsAndEvents still called it with one argument, breaking the v5 build (pkg/dashboard/stage_tracker_linked_progress_test.go:95,101). Pass nil, which the function already treats as "no cross-repository vouching" (stage_tracker.go:2996). Hive-Run: #15320 Hive-Plan: fix-v5-test-failure-15320 Hive-Spec: tests#compile-fix Signed-off-by: onkar717 <shelkeonka@gmail.com>
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether to close this adoption of #15324 as already landed, since v5 already contains the identical two-line test change via #15506.
This is a no-op against v5: the change is already on the base branch.
What I verified
- The whole diff is two call sites in
src/pkg/dashboard/stage_tracker_linked_progress_test.go:95and:101, changingstageTrackerResolveLinkedPRs(items)tostageTrackerResolveLinkedPRs(items, nil). v5HEAD already has exactly those two lines at:95and:101;git diff origin/v5 pr15647 -- src/pkg/dashboard/stage_tracker_linked_progress_test.gois empty. They arrived in6c64b18(#15506, merged 2026-10-29T20:40Z), which added that file tov5in its current form.- The two-arg signature is the one on
v5(src/pkg/dashboard/stage_tracker.go:3157), and the other callers already pass the predicate (stage_tracker.go:2455,delegated_pr_context.go:47), so the compile fix this PR targeted (#15320) is already in place.
Nothing is wrong with the change itself — it is just already merged. Flagging for a maintainer: if you agree, this one (and its fork original #15324, same head 520092a) could be closed as superseded by #15506. I have not closed anything.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Needs a decision, not a merge:
Head: verdict requires_human @282b1a7, 40/44 checks green, 4 pending, DCO yes, soak 0s of 30m0s. What to do: approve this head ( How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
|
Closed as superseded by #15506 by @clubanderson from the Hive dashboard. Already landed on v5 via #15506; closing as superseded. |
…sted PR An issue with several linked PRs draws a sub-row per PR; when one parked PR asks, stageTrackerDecisionTarget resolved the issue row's lead to that PR as well, so the same 'Let hive decide' button appeared on the parent header and on the sub-row (hive#15320 → #15647, hive#15338 → #15648). stageTrackerLeadActionOnRow drops the parent's lead when it acts on a nested PR that is drawn as a sub-row and renders its own; the parent's ⋯ menu keeps 'Decide PR #N…'. Test: a parent + nested-PR pair yields one button. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…seded (#15664) * 🐛 tracker: a PR waiting on its author never leads with Close as superseded A human-authored PR the review swarm sent back for changes rendered the red inline 'Close as superseded' button: stageTrackerLeadActions flagged every server decide:* option not already in the Decide… submenu as lead, and once delegate/hold were taken the first leftover was the close. - StageTrackerDecisionOption gains Lead (json lead); the server sets it only where a close is the answer (decisionLeadWithCloseSuperseded, the reviewer's RedundantOf). - The SPA never leads a row with a danger option unless o.lead, and the Decide… fallback skips danger entries; the ⋯ menu is unchanged. - The waiting pill for a person's own PR reads 'waiting on @x to push' and the popover question no longer asks 'or close it?'. - Tests updated; focused cases for waiting-on-author (no close lead), the live 085 sent-back shape, and redundant-of (close still leads). Signed-off-by: Andrew Anderson <andy@clubanderson.com> * 🐛 tracker: render Let hive decide once for an issue and its asking nested PR An issue with several linked PRs draws a sub-row per PR; when one parked PR asks, stageTrackerDecisionTarget resolved the issue row's lead to that PR as well, so the same 'Let hive decide' button appeared on the parent header and on the sub-row (hive#15320 → #15647, hive#15338 → #15648). stageTrackerLeadActionOnRow drops the parent's lead when it acts on a nested PR that is drawn as a sub-row and renders its own; the parent's ⋯ menu keeps 'Decide PR #N…'. Test: a parent + nested-PR pair yields one button. Signed-off-by: Andrew Anderson <andy@clubanderson.com> * 📖 changelog: cover the duplicate Let hive decide fix Signed-off-by: Andrew Anderson <andy@clubanderson.com> * 🌱 test: the sent-back 085 row keeps its close inside the Decide… submenu Signed-off-by: Andrew Anderson <andy@clubanderson.com> * 🐛 tracker: a server-marked lead heads the row even when the Decide… submenu lists its verb Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Supersedes #15324 (adopted after CI went red and the contributor was unavailable; original commits by @onkar717 preserved).
Closes #15320
This branch is #15324's head
520092a87258as pushed by @onkar717 (forkonkar717/hivecommons-hive), unchanged. Last lane reason on the original:fork-not-editable.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.