Skip to content

πŸ› review: hive-authored adoption PRs parked at 085 asking a person to close them as already landedΒ #15670

Closed

Description

@clubanderson

Hive-authored adoption PRs #15647 (adopted from #15324) and #15648 (adopted from #15343) were parked at stage/085-needs-decision with log stage labels: reviewer verdict route … lane=self-authored raw_verdict=requires_human decision_requested=true and the entry comment "reviewer question: @clubanderson should decide whether to close this adoption of #15324 as already landed, since v5 already contains the identical two-line test change via #15506" (and for #15648: "#15341 (same author) removed the identical section").

The owner's rule: the hive must not ask a person to decide about its own PRs when the review found no security/trust concern β€” "already landed / redundant / no-op" is a decision the hive takes itself: close as superseded by the PR that landed it.

Root cause: the empty-diff closer (#15499) did run on the 085 route, but its freshness guard read the PR's updated_at, which the hive's own labels/comments bump every pass, so the head was "too fresh" forever and the PR fell through to 085.

Fix: for a hive-authored PR whose verdict says the change is already on the base (hive-redundant-of marker, or conservative "already landed … via #N" wording), the stage engine takes the supersede-close path instead of 085: closes the PR as superseded by #N (freshness guard waived since a reviewer confirmed the head; files byte-identical on the base tip count as empty), settles the adopted originals' lineage (closed as superseded, store marked so orphan recovery does not re-adopt), closes the parent issue, and logs one INFO line with reason self-authored:already-landed.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  2. added 2 commits that reference this issue on Oct 30, 2026
    27dde87
    2da97b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions